Re: [9front] [PATCH] syscall: utility overhaul

[ori@eigenstate.org]

> Following is a list of functional changes:
> 
> * The -o flag outputs the entire buffer to the length returned
>   by the syscall, or, in case of fd2path(2) and errstr(2), to '\0'.
> * The -x flag is removed; the above makes it possible to pipe
>   into xd(1) to get the same result.
> * The -s flag uses dirfmt(2) to format the stat message, instead
>   of trying to imitate ls(1).
> * Stderr reports are normalized and made easier to parse.
> 
> The code also suffered a number of stylistic changes.
> 
> diff -r d947a4c5d7fa sys/man/1/syscall
> --- a/sys/man/1/syscall	Thu Sep 03 20:07:44 2020 -0700
> +++ b/sys/man/1/syscall	Sat Sep 19 15:04:17 2020 +0200
> 
> +		switch(i){
> +		case _ERRSTR: case ERRSTR: case FD2PATH:
> +			nbuf = strlen(buf);
>  		}
> 
> Is buf guaranteed to be nul terminated here? I think
> we're likely to be ok here, but I'd be more comfortable
> if we had the last byte explicitly set before calling
> strlen.
> 
> Other than that, it lkooks good to me.

(Actually, ignore that, those syscalls nul terminate)