From: qwx <qwx@sciops.net>
To: 9front@9front.org
Subject: Re: [9front] Re: games/snes audio patches
Date: Mon, 22 Feb 2021 01:32:58 +0100 [thread overview]
Message-ID: <A7A701E5E9CE5C3CD8B3C9BC16835F93@wopr.sciops.net> (raw)
In-Reply-To: <3TYJK0YCE3OF6.2G7TZ7NP81HEX@mforney.org>
Hi,
[...]
> I do think we should try to reuse the pcmconv code since it's already
> there and works well, but this is not something I plan on working
> on in the near future. For now, I think we should just change it
> to hermite or linear, since they can be implemented in just a few
> lines of code, and I'm not sure I could tell the difference between
> them and pcmconv for actual game audio.
>
> I attached a patch for hermite interpolation if that is preferred
> over linear. I'd be happy with either of them for now.
Great work! Looks good to me.
pcmconv might be best, but I agree it's fine to use a simpler fix for
now. Since you already provide a patch for hermite, and it looks like
it yields good results, I'd merge that.
If there are no objections, I'll push that patch.
Thanks again!
qwx
next prev parent reply other threads:[~2021-02-22 0:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 10:25 [9front] " Michael Forney
2021-02-15 10:55 ` Steve Simon
2021-02-17 0:05 ` qwx
2021-02-17 5:31 ` Amavect
2021-02-17 9:10 ` hiro
2021-02-17 9:32 ` Steve Simon
2021-02-17 9:57 ` hiro
2021-02-17 10:24 ` qwx
2021-02-17 10:53 ` hiro
2021-02-21 11:06 ` [9front] " Michael Forney
2021-02-22 0:32 ` qwx [this message]
2021-02-22 15:15 ` qwx
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A7A701E5E9CE5C3CD8B3C9BC16835F93@wopr.sciops.net \
--to=qwx@sciops.net \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).