From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 17654 invoked from network); 22 Feb 2021 00:40:51 -0000 Received: from 1ess.inri.net (216.126.196.35) by inbox.vuxu.org with ESMTPUTF8; 22 Feb 2021 00:40:51 -0000 Received: from wopr.sciops.net ([216.126.196.60]) by 1ess; Sun Feb 21 19:33:08 -0500 2021 Received: (qmail 87400 invoked from network); 21 Feb 2021 16:33:00 -0800 Received: from 100.43.142.88.rev.sfr.net (HELO aib.nope) (qwx@88.142.43.100) by wopr.sciops.net with SMTP; 21 Feb 2021 16:33:00 -0800 Message-ID: From: qwx Date: Mon, 22 Feb 2021 01:32:58 +0100 To: 9front@9front.org In-Reply-To: <3TYJK0YCE3OF6.2G7TZ7NP81HEX@mforney.org> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit List-ID: <9front.9front.org> List-Help: X-Glyph: ➈ X-Bullshit: proven virtualized app configuration full-stack scripting solution Subject: Re: [9front] Re: games/snes audio patches Reply-To: 9front@9front.org Precedence: bulk Hi, [...] > I do think we should try to reuse the pcmconv code since it's already > there and works well, but this is not something I plan on working > on in the near future. For now, I think we should just change it > to hermite or linear, since they can be implemented in just a few > lines of code, and I'm not sure I could tell the difference between > them and pcmconv for actual game audio. > > I attached a patch for hermite interpolation if that is preferred > over linear. I'd be happy with either of them for now. Great work! Looks good to me. pcmconv might be best, but I agree it's fine to use a simpler fix for now. Since you already provide a patch for hermite, and it looks like it yields good results, I'd merge that. If there are no objections, I'll push that patch. Thanks again! qwx