From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4
Received: (qmail 25263 invoked from network); 24 Apr 2023 18:54:31 -0000
Received: from 9front.inri.net (168.235.81.73)
  by inbox.vuxu.org with ESMTPUTF8; 24 Apr 2023 18:54:31 -0000
Received: from wopr.sciops.net ([216.126.196.60]) by 9front; Mon Apr 24 14:52:40 -0400 2023
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sciops.net; s=20210706;
	t=1682362240;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:  in-reply-to:in-reply-to;
	bh=l4fpDo2+Mamg/NTn/q8GxUEWD08wTGObNgGO8vxjmAg=;
	b=Y02cYceWrdewk0+4nxhesgHgEqtPinhSaLitToxVkuhI2LuPkba/LqB1W8QO3uQezNCosF
	wivQZQnroXEtwQqEiNqR+j0+Q8+LaC4lqvcRB4Q1HOjUiNn+pLXdq9TgMeEGO1rOTavzHU
	OmRu12zzFENZqlc60GsP9/2jSSjvnAo=
Received: 
	by wopr.sciops.net (OpenSMTPD) with ESMTPSA id ae7c9dd8 (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO)
	for <9front@9front.org>;
	Mon, 24 Apr 2023 11:50:38 -0700 (PDT)
Message-ID: <AE892D9B051D2B522B1FA655C59ED603@wopr.sciops.net>
Date: Mon, 24 Apr 2023 20:52:31 +0200
From: qwx@sciops.net
To: 9front@9front.org
In-Reply-To: <5CDF6C358171BFB3DCDAEE0C0B1F080F@smtp.pobox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: mobile structured browser base XML over SOAP full-stack-scale framework solution 
Subject: Re: [9front] displayport thinkpad x230 external monitor black screen
Reply-To: 9front@9front.org
Precedence: bulk

On Wed Apr 19 22:51:39 +0200 2023, unobe@cpan.org wrote:
> I attempted to, but apparently failed.  Admittedly, it was a manual
> check on my part.  C programming is not yet native to me, and I'm
> still trying to learn the formatting style.  Is style(6) still the
> standard?  Or is there a C beautifier that can be used so that this
> (valid) sort of criticism is then a simple matter of just having the
> contributor run a script over the code?  That is, if I run cb(1) using
> the '-s' flag, will that suffice?  Gofmt was a smart move.  Perl::Tidy
> (which I used in my day job) helps with this sort of thing as well,
> and allows a comment to "turn off" beautifying for a section of code.
> That sort of thing is helpful when the formatting itself is
> non-standard yet provides clarity to the code.  I didn't see the same
> ability with cb(1), other than it not reformatting structure
> initializers.
> 
> > The only other thing:
> > 
> > > +	while(--i){
> > > +		if(memcmp(tmp+i, magic, 8) == 0){
> > > +			trace("magic begins at index %d, shifting\n", i);
> > > +			memcpy(buf, tmp+i, 256-i);
> > > +			memcpy(buf+(256-i), tmp, i);
> > > +			i = 1;
> > > +		}
> > > +	}
> > 
> > Why not just a `break;' there?  Anyway, not important.
> 
> I vacillated on this exact thing, and apparently chose the road less
> traveled by, and that has made all the difference.

Alright, since there are no reports for breakage, I suggest that we --
you or me, as you prefer -- make a few minor edits as mentioned, make
a new diff and just push it.  Apologies for the delays!

Thanks again,
qwx