From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED
	autolearn=no autolearn_force=no version=3.4.4
Received: (qmail 8886 invoked from network); 30 Oct 2022 04:36:55 -0000
Received: from 9front.inri.net (168.235.81.73)
  by inbox.vuxu.org with ESMTPUTF8; 30 Oct 2022 04:36:55 -0000
Received: from mail-pj1-f52.google.com ([209.85.216.52]) by 9front; Sun Oct 30 00:35:45 -0400 2022
Received: by mail-pj1-f52.google.com with SMTP id m2so7840963pjr.3
        for <9front@9front.org>; Sat, 29 Oct 2022 21:35:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=mforney.org; s=google;
        h=content-transfer-encoding:mime-version:to:subject:date:from
         :message-id:from:to:cc:subject:date:message-id:reply-to;
        bh=Fw+0GjX0NxWbisQtP+iJAFCSqOiW/aPfSRiFSVgQptM=;
        b=Rgwfr7Wkkt1zpeAaLNGlamxKuSJcVoxYBJBMiTWwnnTXfMIkEukApQ7bhXedSxnNKT
         UjDjCg1TohrATLm3rF4JE3AD/8JAw9gvpRXTsJAGEDM83R2ozbS7c1RFmhGWa/6oXCUA
         p9PvyeXud04uHzz3cpmPmDi73DFzczgm1k/61rUgO/8AgFrjxNDYeKvWi0xnG/Q2k2HR
         g+CONiHEfYjGZoKisPeGx1wW3VJnHLUKP7KymdI6MMpAVS30uLy+ghLIFwi6Khy8gsXK
         aZVc+cCbsBGDabgwxWjPr7gVzNg0F9Kglil2X6Kz8JUVGAHgG0oLgKHVPToqoeppX3Fm
         QPHg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:mime-version:to:subject:date:from
         :message-id:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=Fw+0GjX0NxWbisQtP+iJAFCSqOiW/aPfSRiFSVgQptM=;
        b=3aN3OErQGirtvLLqxiI3H4ildOAXpEWcq2+mnyJVr2s9NW55gHrWZnCmGwCSeRsDL2
         pAeB6BLr1xGXgpPDbQdthFi/UJUGFSKL5sFmu9lHlvxM/zrn6nn1EiQhGPO+j+vHy+Sl
         uV1yx2n7EA/wApzU3Wyu+SOqg9y2BxiudciaBYcDznki5gp7yw3rkIYk0WihaxUFuJuq
         WitTzeHpmZ0YrHETuhc1l+tE1y2Z5OKKJn6gjD52EMvGPqsPJMSqeWD0SKrRiT3mHuSl
         X9i3YNB1XGUQNBmz2sTTmAGZm5SnYHwAtI7rNZQfBq7y49PTrogKiovSaSK0yCB2xsnH
         LIEg==
X-Gm-Message-State: ACrzQf3fb0QTxOzlU+I8eEcx2GmCfaT6dDNOOL9NkrRMssi3nRMsHLqt
	SrhRg+g/MwWz6OvoXuDnHa8Evt3QJEJ9iqR+fW0=
X-Google-Smtp-Source: AMsMyM5CqOqiJF6FJF1cD5ixKyXbc7jngR47yAryVMcVvvpIWHkkpGiKflgvErhTLXotjeODqgGAWA==
X-Received: by 2002:a17:902:e80b:b0:183:7463:f628 with SMTP id u11-20020a170902e80b00b001837463f628mr7553181plg.19.1667104541291;
        Sat, 29 Oct 2022 21:35:41 -0700 (PDT)
Return-Path: <mforney@mforney.org>
Received: from novus.hsd1.ca.comcast.net ([98.45.132.135])
        by smtp.gmail.com with ESMTPSA id c2-20020a17090ab28200b002135a57029dsm1763828pjr.29.2022.10.29.21.35.40
        for <9front@9front.org>
        (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256);
        Sat, 29 Oct 2022 21:35:40 -0700 (PDT)
Message-ID: <AFBE5AB0C7B1923FE94D4C10DBC9E7D6@mforney.org>
From: Michael Forney <mforney@mforney.org>
Date: Sun, 30 Oct 2022 04:34:44 +0000
To: 9front@9front.org
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: patented generic rails SVG rails-scale factory 
Subject: [9front] [PATCH] rc: make `flag f [+-]` clear status on success
Reply-To: 9front@9front.org
Precedence: bulk


Otherwise, the old status will be retained, which may be non-empty if
it follows an if command whose branch wasn't taken.  This is
problematic for scripts using -e.
---
diff 2e1ac96d3f6ff85ccac1681631d09d60953cf8a6 d07ea0f0bffab3999e873ea035e08904749ba581
--- a/sys/src/cmd/rc/simple.c
+++ b/sys/src/cmd/rc/simple.c
@@ -445,10 +445,12 @@
 		if(strlen(letter)==1){
 			if(strcmp(val, "+")==0){
 				flag[(unsigned char)letter[0]] = flagset;
+				setstatus("");
 				break;
 			}
 			if(strcmp(val, "-")==0){
 				flag[(unsigned char)letter[0]] = 0;
+				setstatus("");
 				break;
 			}
 		}