9front - general discussion about 9front
 help / color / mirror / Atom feed
* [9front] Patch for 9pfid(2) manpage
@ 2021-05-17 15:56 kjn
  2021-05-17 16:17 ` ori
  0 siblings, 1 reply; 2+ messages in thread
From: kjn @ 2021-05-17 15:56 UTC (permalink / raw)
  To: 9front

I think we should mention the pointer to the Srv in 9pfid(2).  This
reference is useful, for example, when one needs to call srvrelease()
and srvacquire() while handling requests.  I didn't discover the
pointer was available through the Req struct until I looked through
the headers.

diff -r 99d7d683afa4 sys/man/2/9pfid
--- a/sys/man/2/9pfid	Tue Apr 27 16:08:06 2021 +0200
+++ b/sys/man/2/9pfid	Mon May 17 10:50:11 2021 -0500
@@ -51,6 +51,7 @@
 	Fid	*fid;
 	Fid	*afid;
 	Fid	*newfid;
+	Srv	*srv;
 	\fI...\fP
 } Req;
 .fi


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [9front] Patch for 9pfid(2) manpage
  2021-05-17 15:56 [9front] Patch for 9pfid(2) manpage kjn
@ 2021-05-17 16:17 ` ori
  0 siblings, 0 replies; 2+ messages in thread
From: ori @ 2021-05-17 16:17 UTC (permalink / raw)
  To: 9front

Quoth kjn@9project.net:
> I think we should mention the pointer to the Srv in 9pfid(2).  This
> reference is useful, for example, when one needs to call srvrelease()
> and srvacquire() while handling requests.  I didn't discover the
> pointer was available through the Req struct until I looked through
> the headers.
> 
> diff -r 99d7d683afa4 sys/man/2/9pfid
> --- a/sys/man/2/9pfid	Tue Apr 27 16:08:06 2021 +0200
> +++ b/sys/man/2/9pfid	Mon May 17 10:50:11 2021 -0500
> @@ -51,6 +51,7 @@
>  	Fid	*fid;
>  	Fid	*afid;
>  	Fid	*newfid;
> +	Srv	*srv;
>  	\fI...\fP
>  } Req;
>  .fi
> 

Applied.

The only reason to leave it undocumented would
be to leave us open to change the API, but I
don't see a reason to -- and it's not in the
implementation specific bit of the struct.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-18 13:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-17 15:56 [9front] Patch for 9pfid(2) manpage kjn
2021-05-17 16:17 ` ori

9front - general discussion about 9front

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/9front

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 9front 9front/ http://inbox.vuxu.org/9front \
		9front@9front.org
	public-inbox-index 9front

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.9front


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git