* [9front] libdraw: remove drawsetdebug() ?
@ 2021-01-01 18:07 telephil9
2021-01-01 18:29 ` hiro
0 siblings, 1 reply; 2+ messages in thread
From: telephil9 @ 2021-01-01 18:07 UTC (permalink / raw)
To: 9front
Hi,
drawsetdebug() is now a no-op on devdraw side. It seems (I let hiro confirm) that it still works with vncs though.
Two options:
1) It is a no-op everywhere and we should remove it from libdraw
2) It is still of use somewhere but then draw(2) should reflect the fact that it does nothing
I can provide a patch for either scenario.
--phil
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [9front] libdraw: remove drawsetdebug() ?
2021-01-01 18:07 [9front] libdraw: remove drawsetdebug() ? telephil9
@ 2021-01-01 18:29 ` hiro
0 siblings, 0 replies; 2+ messages in thread
From: hiro @ 2021-01-01 18:29 UTC (permalink / raw)
To: 9front
well, in devdraw it does exactly one thing: it doesn't error, and
successfully allows devdraw to continue with the next RPC.
we can not remove it from devdraw.
i don't know what is in libdraw, but i guess one could notice in it's
man page that for this to be of any use to anybody they would have to
run their own modified devdraw that actually handles this case in a
dedicated logging procedure...
On 1/1/21, telephil9@gmail.com <telephil9@gmail.com> wrote:
> Hi,
>
> drawsetdebug() is now a no-op on devdraw side. It seems (I let hiro confirm)
> that it still works with vncs though.
> Two options:
> 1) It is a no-op everywhere and we should remove it from libdraw
> 2) It is still of use somewhere but then draw(2) should reflect the fact
> that it does nothing
>
> I can provide a patch for either scenario.
>
> --phil
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-01 18:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-01 18:07 [9front] libdraw: remove drawsetdebug() ? telephil9
2021-01-01 18:29 ` hiro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).