From: cinap_lenrek@felloff.net
To: 9front@9front.org
Subject: Re: [9front] man rc patch
Date: Thu, 15 Nov 2018 19:00:05 +0100 [thread overview]
Message-ID: <BF76DDEC3ABAB8EB078F0BDE14A1B4FD@felloff.net> (raw)
In-Reply-To: 20181111171607.GA9751@master
but thats not what the patch is doing :-)
+ if(star && 1<=n && n<=count(star)){
+ while(--n) star = star->next;
+ a = newword(star->word, a);
+ }
this means for $"n where n is out of range, it would still
yield a null list.
also, i do not like how Xqdol() duplicates the logic.
it really should be two separate instructions. Xdol
doing the dereference of the variable, handling the special
star variables... and another instruction Xqote or something
that flattens it out to a single string where () becomes
the empty string.
--
cinap
next reply other threads:[~2018-11-15 18:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 18:00 cinap_lenrek [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-11-16 7:32 cinap_lenrek
2018-11-16 0:47 Alex Musolino
2018-11-15 19:17 cinap_lenrek
2018-11-11 6:59 Alex Musolino
2018-11-11 11:32 ` Ethan Gardener
2018-11-11 17:14 ` Joe M
2018-11-11 17:16 ` Joe M
2018-11-14 15:56 ` Ethan Gardener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BF76DDEC3ABAB8EB078F0BDE14A1B4FD@felloff.net \
--to=cinap_lenrek@felloff.net \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).