From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_ADSP_CUSTOM_MED,
	DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.4
Received: (qmail 1695 invoked from network); 26 Mar 2022 02:16:45 -0000
Received: from 4ess.inri.net (216.126.196.42)
  by inbox.vuxu.org with ESMTPUTF8; 26 Mar 2022 02:16:45 -0000
Received: from mail-io1-f54.google.com ([209.85.166.54]) by 4ess; Fri Mar 25 22:04:59 -0400 2022
Received: by mail-io1-f54.google.com with SMTP id e22so10897711ioe.11
        for <9front@9front.org>; Fri, 25 Mar 2022 19:04:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=from:content-transfer-encoding:mime-version:subject:message-id:date
         :to;
        bh=DQHXm9TQAW0UaX4qEIaverVzGMkvRSEK8+JAu5TsytY=;
        b=pUvSrckV/j3GUpalBXX0AMTURZ5nldQRZTqFHjElskBFSAUksCoy+EheoPAalZNm0U
         pgjmELS7rsG0QDIMaRzGI7v4VdBwJmZCSCkSr3zt2BGzmUkmQQgrpeCS58W+jh+mQOcR
         LTYa0cIkpPF+RQgJj7frES/PlQjwzEpmZPfSVWOZfOHUtGXOocBmB36iUKHoTMH4XL52
         cLXk2wDaFqpw74bGiBQJjRvyhuAYamt8sgPVKONQ+NI6NgJN623ppn/ljn6Y2hgDoJwr
         KEtGU0OA5+vstKjhI0yK8+B9yVZbSIc4+w2x4Imv8bPCpaMJsFLCWDEvDyghLnn/mSun
         AOWw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:from:content-transfer-encoding:mime-version
         :subject:message-id:date:to;
        bh=DQHXm9TQAW0UaX4qEIaverVzGMkvRSEK8+JAu5TsytY=;
        b=NJ5AyBVA+zgvB8oceXhIytRjIdSO0QMrxo/paGxuEu6+thd6YbJ4Km9qU28WYmSDUA
         clmO7qJTNQFXGbR+LrhynnGVFqbw6a+VDSPt045Vg7i/Z8hKDvoimJEc/HNEJz8RQdH+
         dQ0WsOxUqm46e0SBD0nlqurua+yvK6S1Zy3oTAsIPadv78HS9Z6Slxcpa47M9+trCCXE
         j4Y4p5XevZlUwoWNjyd9jG3H2ZEAkvBIYlLyCYkntdBSzHs2kxoqQAMWEcIqi9WR5ey/
         wmex/9Ui77vTrFHrwPof8uWFGz24EMWOIFsjca9bhsDuKvDJbtj5NFAacL6GYxtYfNR1
         8fRw==
X-Gm-Message-State: AOAM530MphUbTRhRevk1i82iqLu0Gzj6dQXpSejqUOfGc4QgyX2gm4Ns
	VFvW5staZdlC9fsiDQ9r0FrK+gDDfuo=
X-Google-Smtp-Source: ABdhPJwPzoymCgwwBNzkzR1k1X/yF3zqMRgQinoezcgwkA1BEziMjHprHIlKs3o9VvJ2kAjLeV8C1Q==
X-Received: by 2002:a05:6638:2587:b0:31d:5878:6e96 with SMTP id s7-20020a056638258700b0031d58786e96mr7806927jat.6.1648260292479;
        Fri, 25 Mar 2022 19:04:52 -0700 (PDT)
Return-Path: <meta.jxy@gmail.com>
Received: from smtpclient.apple (c-67-184-39-205.hsd1.il.comcast.net. [67.184.39.205])
        by smtp.gmail.com with ESMTPSA id h1-20020a92c261000000b002c81ef3b36fsm3974625ild.35.2022.03.25.19.04.51
        for <9front@9front.org>
        (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
        Fri, 25 Mar 2022 19:04:52 -0700 (PDT)
From: Xiao-Yong Jin <meta.jxy@gmail.com>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\))
Message-Id: <C63CA261-40B7-43A0-B257-C10D0BEC8403@gmail.com>
Date: Fri, 25 Mar 2022 21:04:50 -0500
To: 9front@9front.org
X-Mailer: Apple Mail (2.3696.80.82.1.1)
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: content-addressed just-in-time factory hypervisor 
Subject: [9front] drawterm convM2A should return -m if form1M2B()<0 ?
Reply-To: 9front@9front.org
Precedence: bulk

Do I understand it correctly?

diff --git a/libauthsrv/convM2A.c b/libauthsrv/convM2A.c
index 0da7865..5f7bd2f 100644
--- a/libauthsrv/convM2A.c
+++ b/libauthsrv/convM2A.c
@@ -23,7 +23,7 @@ convM2A(char *ap, int n, Authenticator *f, Ticket *t)
 			return -m;
 		memmove(buf, ap, m);
 		if(form1M2B((char*)buf, m, t->key) < 0)
-			return m;
+			return -m;
 	}
 	p = buf;
 	f->num = *p++;