* [PATCH] upas/Mail: add In-Reply-To to replies
@ 2020-02-16 23:34 Drew DeVault
2020-02-16 23:54 ` [9front] " Alex Musolino
0 siblings, 1 reply; 3+ messages in thread
From: Drew DeVault @ 2020-02-16 23:34 UTC (permalink / raw)
To: 9front, sir
# HG changeset patch
# User Drew DeVault <sir@cmpwn.com>
# Date 1581895466 18000
# Node ID 5142c37315c57642b747aae1b16b8562d5482d21
# Parent 1d345066125a340bfae117459393f4167700096c
upas/Mail: add In-Reply-To to replies
diff -r 1d345066125a -r 5142c37315c5 sys/src/cmd/upas/Mail/dat.h
--- a/sys/src/cmd/upas/Mail/dat.h Fri Oct 04 18:54:01 2019 +0200
+++ b/sys/src/cmd/upas/Mail/dat.h Sun Feb 16 18:24:26 2020 -0500
@@ -70,6 +70,7 @@
char *disposition;
char *filename;
char *digest;
+ char *messageid;
Message *next; /* next in this mailbox */
Message *prev; /* prev in this mailbox */
diff -r 1d345066125a -r 5142c37315c5 sys/src/cmd/upas/Mail/mesg.c
--- a/sys/src/cmd/upas/Mail/mesg.c Fri Oct 04 18:54:01 2019 +0200
+++ b/sys/src/cmd/upas/Mail/mesg.c Sun Feb 16 18:24:26 2020 -0500
@@ -129,7 +129,7 @@
/* m->inreplyto = */ free(line(p, &p));
/* m->date = */ free(line(p, &p));
/* m->sender = */ free(line(p, &p));
- /* m->messageid = */ free(line(p, &p));
+ m->messageid = line(p, &p);
/* m->lines = */ free(line(p, &p));
/* m->size = */ free(line(p, &p));
/* m->flags = */ free(line(p, &p));
diff -r 1d345066125a -r 5142c37315c5 sys/src/cmd/upas/Mail/reply.c
--- a/sys/src/cmd/upas/Mail/reply.c Fri Oct 04 18:54:01 2019 +0200
+++ b/sys/src/cmd/upas/Mail/reply.c Sun Feb 16 18:24:26 2020 -0500
@@ -115,6 +115,8 @@
Bprint(r->w->body, "CC: %s\n", m->cc);
}
}
+ if(strlen(m->messageid) > 0)
+ Bprint(r->w->body, "In-Reply-To: %s\n", m->messageid);
if(strlen(m->subject) > 0){
t = "Subject: Re: ";
if(strlen(m->subject) >= 3)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [9front] [PATCH] upas/Mail: add In-Reply-To to replies
2020-02-16 23:34 [PATCH] upas/Mail: add In-Reply-To to replies Drew DeVault
@ 2020-02-16 23:54 ` Alex Musolino
2020-02-17 0:55 ` ori
0 siblings, 1 reply; 3+ messages in thread
From: Alex Musolino @ 2020-02-16 23:54 UTC (permalink / raw)
To: 9front
> + if(strlen(m->messageid) > 0)
> + Bprint(r->w->body, "In-Reply-To: %s\n", m->messageid);
You need to enclose the messageid with angle brackets, i.e.
Bprint(r->w->body, "In-Reply-To: <%s>\n", m->messageid);
--
Cheers,
Alex Musolino
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [9front] [PATCH] upas/Mail: add In-Reply-To to replies
2020-02-16 23:54 ` [9front] " Alex Musolino
@ 2020-02-17 0:55 ` ori
0 siblings, 0 replies; 3+ messages in thread
From: ori @ 2020-02-17 0:55 UTC (permalink / raw)
To: alex, 9front
>> + if(strlen(m->messageid) > 0)
>> + Bprint(r->w->body, "In-Reply-To: %s\n", m->messageid);
>
> You need to enclose the messageid with angle brackets, i.e.
>
> Bprint(r->w->body, "In-Reply-To: <%s>\n", m->messageid);
>
...Also, this was fixed (by you, Alex) in marshal.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-17 0:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-16 23:34 [PATCH] upas/Mail: add In-Reply-To to replies Drew DeVault
2020-02-16 23:54 ` [9front] " Alex Musolino
2020-02-17 0:55 ` ori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).