From: ori@eigenstate.org
To: telephil9@gmail.com, ori@eigenstate.org, 9front@9front.org
Subject: Re: [9front] Re: [PATCH] fix APE sscanf [ specifier
Date: Sat, 9 May 2020 15:13:44 -0700 [thread overview]
Message-ID: <C6CE60EAEECEF91BB2331A4849ECB4FE@eigenstate.org> (raw)
In-Reply-To: <234E94F01BC6BF327EF85739F792DF2B@gmail.com>
> Hi,
>
> Thank you for the feedback Ori.
>
>> Looks good to me -- will commit. Note, this still isn't fully up to
>> spec, since it should in theory handle length modifiers for unicode,
>> but I think it covers everything we're likely to see.
>
> Regarding unicode you are right, but you surely have noted that our versions of vfscanf are not unicode aware at all. At least, this is document in the manual (see BUGS in sscanf(2)).
>
> Below is a new version of the patch that includes a fix for an additionnal issue found with %n directive this time.
> vfscanf is returning as soon as it reaches the end of the input stream which will prevent any trailing %n directives from being processed.
> This bug can be observed in the following call:
> sscanf("z", " %1[Zz] %n ", s, &n);
> Here n will not be set as the %n directive is never reached.
>
Committed, thanks!
prev parent reply other threads:[~2020-05-09 22:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 7:49 telephil9
2020-05-07 16:24 ` telephil9
2020-05-08 15:11 ` [9front] " ori
2020-05-09 6:40 ` telephil9
2020-05-09 22:13 ` ori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C6CE60EAEECEF91BB2331A4849ECB4FE@eigenstate.org \
--to=ori@eigenstate.org \
--cc=9front@9front.org \
--cc=telephil9@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).