From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham
	autolearn_force=no version=3.4.4
Received: (qmail 22039 invoked from network); 9 Aug 2021 06:33:10 -0000
Received: from 1ess.inri.net (216.126.196.35)
  by inbox.vuxu.org with ESMTPUTF8; 9 Aug 2021 06:33:10 -0000
Received: from mimir.eigenstate.org ([206.124.132.107]) by 1ess; Sun Aug  8 19:55:15 -0400 2021
Received: from abbatoir.myfiosgateway.com (pool-74-108-56-225.nycmny.fios.verizon.net [74.108.56.225])
	by mimir.eigenstate.org (OpenSMTPD) with ESMTPSA id 4f7efe83 (TLSv1.2:ECDHE-RSA-AES256-SHA:256:NO)
	for <9front@9front.org>;
	Sun, 8 Aug 2021 16:54:36 -0700 (PDT)
Message-ID: <C8110E3CA838776F2677C9CCAF0EAF30@eigenstate.org>
To: 9front@9front.org
Date: Sun, 08 Aug 2021 19:54:34 -0400
From: ori@eigenstate.org
In-Reply-To: <CAGw6cBszWrCEW=wjAULMk11MK9To_1Qv1JFOsqcFYW0f3ENefw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: factory realtime-java CSS-based control 
Subject: Re: [9front] letsencrypt vs rsa2csr
Reply-To: 9front@9front.org
Precedence: bulk

Quoth Michael Forney <mforney@mforney.org>:
> 
> You could go a step further and remove the if-statement as well. It is
> already taken care of by the initial for-loop condition.

Good point. Updated.

--- //.git/fs/object/3909b83a90ff0c820ef7c903a03fc12b043ebfea/tree/sys/src/libsec/port/x509.c
+++ sys/src/libsec/port/x509.c
@@ -1025,13 +1025,11 @@
 			el = e.val.u.setval;
 		else
 			err = ASN_EINVAL;
-		if(el != nil) {
-			*pconstr = CONSTR_MASK;
-			for(; el != nil; el = el->tl) {
-				err = enc(&p, el->hd, lenonly);
-				if(err != ASN_OK)
-					break;
-			}
+		*pconstr = CONSTR_MASK;
+		for(; el != nil; el = el->tl) {
+			err = enc(&p, el->hd, lenonly);
+			if(err != ASN_OK)
+				break;
 		}
 		break;