Re: [9front] exportfs: fix debug logging

[Stuart Morrow <morrow.stuart@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

On 13/08/2021, unobe@cpan.org <unobe@cpan.org> wrote:
> I know you already created a different patch, but this part of the
> patch looks pointless, but I don't program in C a lot so maybe I can
> learn something new.  I thought declarations generally go together, so
> why move this one declaration down to after initializations?

In Plan 9 C you *can't* put declarations just anywhere, if you wanted
to. Found this out doing a personal Abaco mod, attached for who may
want it.

[-- Attachment #2: abaco --]
[-- Type: application/octet-stream, Size: 1733 bytes --]

rationale for this is, there was going to be a cursor in the status
bar anyway (and it was going to be ugly anyway), so might as well
put it to use

--- //.git/fs/object/2af46e406bbd443ae10025777247798a685afc3c/tree/sys/src/cmd/abaco/html.c
+++ sys/src/cmd/abaco/html.c
@@ -458,7 +458,7 @@
 void
 mouselink(Box *b, Page *p, int but)
 {
-	Runestr rs;
+	Runestr url, base;
 	Anchor *a;
 
 	/* eat mouse */
@@ -477,18 +477,30 @@
 		return;
 
 	p = whichtarget(p, a->target);
-	rs.r = urlcombine(getbase(p), a->href);
-	if(rs.r == nil)
+	base.r = getbase(p);
+	url.r = urlcombine(base.r, a->href);
+	if(url.r == nil)
 		return;
-	rs.nr = runestrlen(rs.r);
+	url.nr = runestrlen(url.r);
 
-	if(but == 1)
-		pageget(p, &rs, nil, HGet, p==&p->w->page);
-	else if(but == 2)
-		textset(&p->w->status, rs.r, rs.nr);
-	else if(but == 3)
-		plumbrunestr(&rs, nil);
-	closerunestr(&rs);
+	switch(but){
+	case 1:
+		pageget(p, &url, nil, HGet, p==&p->w->page);
+		break;
+	case 2: {
+		Text *status = &p->w->status;
+		int i = min(url.nr, runestrdiff(url.r, base.r));
+
+		textset(status, url.r, url.nr);
+		textsetselect(status, i, i);
+		break;
+		}
+	case 3:
+		plumbrunestr(&url, nil);
+		break;
+	}
+	closerunestr(&url);
+	/* and not needed for &base */
 }
 
 static
--- //.git/fs/object/2af46e406bbd443ae10025777247798a685afc3c/tree/sys/src/cmd/abaco/util.c
+++ sys/src/cmd/abaco/util.c
@@ -14,7 +14,7 @@
 #include "dat.h"
 #include "fns.h"
 
-static	Point		prevmouse;
+static	Point	prevmouse;
 static	Window	*mousew;
 
 int
@@ -149,6 +149,16 @@
 	if(n1 != n2)
 		return FALSE;
 	return memcmp(s1, s2, n1*sizeof(Rune)) == 0;
+}
+
+int
+runestrdiff(Rune *s1, Rune *s2)
+{
+	int n = 0;
+
+	while(*s1++ == *s2++)
+		n++;
+	return n;
 }
 
 void