From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wr1-f46.google.com ([209.85.221.46]) by ewsd; Mon Jun 22 13:37:34 EDT 2020
Received: by mail-wr1-f46.google.com with SMTP id b6so17526067wrs.11
        for <9front@9front.org>; Mon, 22 Jun 2020 10:37:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:from:date:message-id:subject:to;
        bh=EDdib67N0Uw2m7YYgjeaoMQdJXxhhxwGQcGI1ZLcfu0=;
        b=QCOf+nk9qnfK5HprMRVK47gBPaLNOE2Bm6tFJy7m+P9XZuR10/T7RjU5Sa+/HK73/A
         4qHPPcB4vQ/I4uSRFslH1CKJqCIv1WIZ7A5pVjOohfiMxeRvcFZ8yoCKGKI9nUzsidcq
         n5P1PnGVF21VIvkP5bmf74i/hy+pcjBBaDquK0b1jUUrHl/7H1buzpbgENyKaNBlPZ1f
         qV61GRmP5+oKd2ii8xH17YH9iUI8P+4LrR3RFgGsdk0ad/2LfnX30SjFsr8VbYM32E7E
         nojGhDRqv/1Zit0X3BhED74oBrkokB/UitKDVujM3MisRDxx1k6Vv9lWAQjO7TNk1NsE
         ajVA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
        bh=EDdib67N0Uw2m7YYgjeaoMQdJXxhhxwGQcGI1ZLcfu0=;
        b=lFhxyDGAntJJfjbdmSyyped1AVtBEXP63nbmsL6N9QnXwT9OuHc+wdwizV4j/+tIhw
         07rJAG6ei7AOmgQ9NLLWYz8ACQXR/m3CUxHlh0ZeiOc+DWAEmlNQtn1fczTPlUMDdqZm
         BvuzAB+y0hm8kg1Y+Hjr2mpktUoLUIUYS0tr/I39A7WgLLhZpWh2H1Bm+m/1aUkc+t0O
         GSU4s8HTw8Qj3lXe0ijedQ+qqn/ekm/a2uwELrlsFqK1sdu1bKKIwWOB6lKvWw04hnTJ
         VgmJezlZmfejpTWGWdIn/0Ad8fLJtj4YOSpkA5zCEb4e9odddPBEAEGqc7jC5cuGE/s2
         q5CA==
X-Gm-Message-State: AOAM531JsZuzfspU11VRDH0Ore6sRE1Nd791wyYLN6WMHJhARFqNvp0Z
	lHJRVfTozyGizXj3JgkLdwdtKTJfizT1aYbNTzhgNziNWTk=
X-Google-Smtp-Source: ABdhPJxy3i6KWPXsc/z40D0lINU4qG/Epr6wcde88saBXoypji0Z4/zgvuDrS0gx5e3knssoIS1KGsfs1Z1bWbK/6Mg=
X-Received: by 2002:a5d:4c87:: with SMTP id z7mr20255486wrs.100.1592847450646;
 Mon, 22 Jun 2020 10:37:30 -0700 (PDT)
MIME-Version: 1.0
From: =?UTF-8?Q?Iruat=C3=A3_Souza?= <iru.muzgo@gmail.com>
Date: Mon, 22 Jun 2020 19:37:19 +0200
Message-ID: <CABJnqBT0Q8cweG-H_A7jzcH_yVk0ubg_gycSzzEA9oBvSBmXww@mail.gmail.com>
Subject: vncv(1): support for RFB 3.8
To: 9front@9front.org
Content-Type: text/plain; charset="UTF-8"
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: managed information-based session-scale grid browser controller 

Hi,

The following patch adds support for RFB 3.8 in vncv(1).
It has been tested by connecting to a screen shared by gnome3 on
linux. Please let me know if it introduces any regressions.

diff -r 19baa5600a90 sys/man/1/vnc
--- a/sys/man/1/vnc    Mon Apr 06 01:31:35 2020 +0200
+++ b/sys/man/1/vnc    Mon Jun 22 19:25:55 2020 +0200
@@ -204,6 +204,3 @@
 .I Vncv
 does no verification of the TLS certificate presented
 by the server.
-.PP
-.I Vncv
-supports only version 3.3 of the RFB protocol.
diff -r 19baa5600a90 sys/src/cmd/vnc/auth.c
--- a/sys/src/cmd/vnc/auth.c    Mon Apr 06 01:31:35 2020 +0200
+++ b/sys/src/cmd/vnc/auth.c    Mon Jun 22 19:25:55 2020 +0200
@@ -9,14 +9,16 @@
     VerLen    = 12
 };

-static char version[VerLen+1] = "RFB 003.003\n";
+static char version33[VerLen+1] = "RFB 003.003\n";
+static char version38[VerLen+1] = "RFB 003.008\n";
+static int srvversion;

 int
 vncsrvhandshake(Vnc *v)
 {
     char msg[VerLen+1];

-    strecpy(msg, msg+sizeof msg, version);
+    strecpy(msg, msg+sizeof msg, version33);
     if(verbose)
         fprint(2, "server version: %s\n", msg);
     vncwrbytes(v, msg, VerLen);
@@ -35,18 +37,51 @@

     msg[VerLen] = 0;
     vncrdbytes(v, msg, VerLen);
-    if(strncmp(msg, "RFB ", 4) != 0){
+    if(strncmp(msg, "RFB 003.", 8) != 0) {
         werrstr("bad rfb version \"%s\"", msg);
         return -1;
     }
+    if(strncmp(msg, "RFB 003.008\n", VerLen) == 0)
+        srvversion = 38;
+    else
+        srvversion = 33;
+
     if(verbose)
         fprint(2, "server version: %s\n", msg);
-    strcpy(msg, version);
+    strcpy(msg, version38);
     vncwrbytes(v, msg, VerLen);
     vncflush(v);
     return 0;
 }

+ulong
+sectype38(Vnc *v)
+{
+    ulong auth, type;
+    int i, ntypes;
+
+    ntypes = vncrdchar(v);
+    if (ntypes == 0) {
+        werrstr("no security types from server");
+        return AFailed;
+    }
+
+    /* choose the "most secure" security type */
+    auth = AFailed;
+    for (i = 0; i < ntypes; i++) {
+        type = vncrdchar(v);
+        if(verbose){
+            fprint(2, "auth type %s\n",
+                type == AFailed ? "Invalid" :
+                type == ANoAuth ? "None" :
+                type == AVncAuth ? "VNC" : "Unknown");
+        }
+        if(type > auth)
+            auth = type;
+    }
+    return auth;
+}
+
 int
 vncauth(Vnc *v, char *keypattern)
 {
@@ -56,7 +91,9 @@

     if(keypattern == nil)
         keypattern = "";
-    auth = vncrdlong(v);
+
+    auth = srvversion == 38 ? sectype38(v) : vncrdlong(v);
+
     switch(auth){
     default:
         werrstr("unknown auth type 0x%lux", auth);
@@ -65,6 +102,7 @@
         return -1;

     case AFailed:
+    failed:
         reason = vncrdstring(v);
         werrstr("%s", reason);
         if(verbose)
@@ -72,11 +110,20 @@
         return -1;

     case ANoAuth:
+        if(srvversion == 38){
+            vncwrchar(v, auth);
+            vncflush(v);
+        }
         if(verbose)
             fprint(2, "no auth needed\n");
         break;

     case AVncAuth:
+        if(srvversion == 38){
+            vncwrchar(v, auth);
+            vncflush(v);
+        }
+
         vncrdbytes(v, chal, VncChalLen);
         if(auth_respond(chal, VncChalLen, nil, 0, chal, VncChalLen,
auth_getkey,
             "proto=vnc role=client server=%s %s", serveraddr,
keypattern) != VncChalLen){
@@ -84,13 +131,20 @@
         }
         vncwrbytes(v, chal, VncChalLen);
         vncflush(v);
+        break;
+    }

-        auth = vncrdlong(v);
+    /* in version 3.8 the auth status is always sent, in 3.3 only in
AVncAuth */
+    if(srvversion == 38 || auth == AVncAuth){
+        auth = vncrdlong(v); /* auth status */
         switch(auth){
         default:
             werrstr("unknown server response 0x%lux", auth);
             return -1;
         case VncAuthFailed:
+            if (srvversion == 38)
+                goto failed;
+
             werrstr("server says authentication failed");
             return -1;
         case VncAuthTooMany:
@@ -99,7 +153,6 @@
         case VncAuthOK:
             break;
         }
-        break;
     }
     return 0;
 }