From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 13349 invoked from network); 10 Aug 2021 09:10:21 -0000 Received: from 1ess.inri.net (216.126.196.35) by inbox.vuxu.org with ESMTPUTF8; 10 Aug 2021 09:10:21 -0000 Received: from mail-ua1-f42.google.com ([209.85.222.42]) by 1ess; Mon Aug 9 08:14:05 -0400 2021 Received: by mail-ua1-f42.google.com with SMTP id d6so6903265uav.2 for <9front@9front.org>; Mon, 09 Aug 2021 05:13:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=np5WBK6uLizfyhi8/12CEqBNnJFMJK8HdC8Ttch+Wic=; b=cqp9SaqX9pjmFwnOhYntD6OvClV5PfjSXYgNJUR0Y7YrjkFMRisnGjgjKC7rgQIn3V FzVL6WC5mu0dCl8UBQy/HI5wm4Q2BiOq/pieIgJwFnzJoHEUBMRU2hZI/SM4zeEJ654r Egd/180omtC4GMoV8WJ6UJHGgDX46VpNa2Dsy47oLPP7n3Ax2VdMeRgaks253F8r+Hte LJzuMQA7b/grKIvNFoEFiQO3lfGp99AiNqbiWNZhXK1VcAWHUM+beFLaUDH/XhgEpln5 ZbwaR7wIxSS1HydvrK2iv7cEefCo1ULE/Kgd7iFhLikWYLoflGzTbOnkCGqICM0Pkv6/ CF+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=np5WBK6uLizfyhi8/12CEqBNnJFMJK8HdC8Ttch+Wic=; b=WJEvhaeHKVh5fR+eOqoES6MiW0ClC1t5+FeJWJHWwRWAw3d2SiFz+gHsJaAT1z3qUS jOKGzYbWJ5CfyZb+wQTc+oNXLZsKr2pAxfVFiMvu5ODkEwiJBIhtbWJbu/7fUdFIlxW4 0Fv+fI9AeAEWF3rTv4gVJ36zZJo24c80U/yPA4oB2kFBAUqYV9kJt/LSBkvOTvk/tlfR tSpgnt9sExLWbQi6b58bkfi1N4V+15UN69fVvYcPHqx5z3OvjWov551dYmIRbnVPkNns WDhL9pUr6FRg2GgcAjYbanZP9pBJI2FoSEVPYuM4qgLVDusJtWZwYjh9iHF+beTMAFbB Szkg== X-Gm-Message-State: AOAM530NEjbv0fZAI11a8BuI/52q1i2lj1b9uG7JDRvLtZHIwDSBs1YV ncBH8fJz4KjzvY3G7/TenCsVo49jM6LxgzRztyjfBYGYSZc= X-Google-Smtp-Source: ABdhPJx3K2QKgFThBKTfAcW0PNrsWp+pJNXkLegPN0N4vsbEkhK6pcGOFjU61Ps9MZA2/BekXm3h5sm/NbULXqfGII4= X-Received: by 2002:a9d:2601:: with SMTP id a1mr9353223otb.122.1628510739893; Mon, 09 Aug 2021 05:05:39 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ac9:5981:0:0:0:0:0 with HTTP; Mon, 9 Aug 2021 05:05:39 -0700 (PDT) In-Reply-To: References: <4FC920AD055DC731A863EDE8BD601178@felloff.net> From: kemal Date: Mon, 9 Aug 2021 12:05:39 +0000 Message-ID: To: 9front@9front.org Content-Type: multipart/mixed; boundary="0000000000002a354d05c91f34a1" List-ID: <9front.9front.org> List-Help: X-Glyph: ➈ X-Bullshit: blockchain engine cache-oriented enhancement-based polling locator Subject: Re: [9front] driver for intel wireless 7260? Reply-To: 9front@9front.org Precedence: bulk --0000000000002a354d05c91f34a1 Content-Type: text/plain; charset="UTF-8" 2021-08-07 22:14 GMT, kemal : > for some reason, any command on rxoff7000 fails with > BAD_COMMAND. i didn't see anything wrong with command > data, and 7260 supports these, so i am kind of puzzled why it > happens. will look into it tommorow. i looked more into this. 3 things: 1. *only* settimeevent fails. the other errors are produced because driver does not reset the card after the error. 2. settimeevent does not have anything wrong in it's command data. so it's probably not caused by that. 3. apparently, time event command had an older api. it was removed from openbsd cuz apparently all supported fw versions support it, but i have a suspicion. what if *-17 actually requires the old api? in addition that change was added as a patch, perhaps it was not tested well. a diff is attached that now checks if card actually supports api v2, and if not send the command in the v1 format. --0000000000002a354d05c91f34a1 Content-Type: text/plain; charset="US-ASCII"; name="diff.txt" Content-Disposition: attachment; filename="diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: file0 LS0tIC9zeXMvc3JjLzkvcGMvZXRoZXJpd2wuYworKysgL3N5cy9zcmMvOS9wYy9ldGhlcml3bC5j CkBAIC0zMjksNyArMzI5LDI1IEBACiAJU2NoZWRUcmFuc1RibE9mZgk9IDB4N0UwLAkJLy8gK3Eq MgogfTsKIAorLyoKKyAqIHVDb2RlIEFQSSBmbGFncworICovCiBlbnVtIHsKKwlVY29kZUZsZ1Rl Mgk9IDE8PDksCit9OworCisvKgorICogdUNvZGUgY2FwYWJpbGl0aWVzCisgKi8KK2VudW0gewor CS8qIGNhcGFbMF0gKi8KKwlVY29kZUNhcExhcgk9IDE8PDEsCisJCisJLyogY2FwYVsyXSAqLwor CVVjb2RlQ2FwTGFyMgk9IDE8PDksCit9OworCitlbnVtIHsKIAlGaWx0ZXJQcm9taXNjCQk9IDE8 PDAsCiAJRmlsdGVyQ3RsCQk9IDE8PDEsCiAJRmlsdGVyTXVsdGljYXN0CQk9IDE8PDIsCkBAIC00 MTgsNiArNDM2LDcgQEAKIAl1aW50CWJ1aWxkOwogCWNoYXIJZGVzY3JbNjQrMV07CiAKKwl1MzJp bnQJZmxhZ3M7CiAJdTMyaW50CWNhcGFbNF07CiAJdTMyaW50CWFwaVs0XTsKIApAQCAtNjM1LDcg KzY1NCw3IEBACiAJVHlwZTIwMzAJPSAxMiwKIAlUeXBlMjAwMAk9IDE2LAogCi0JVHlwZTcyNjAJ PSAzMCwKKwlUeXBlNzI2MAk9IDIwLAogCVR5cGU4MjY1CT0gMzUsCiB9OwogCkBAIC0xNDc4LDYg KzE0OTcsMTEgQEAKIAkJCQlzID0gJmktPmJvb3QudGV4dDsKIAkJCQlzLT5hZGRyID0gMHgwMDAw MDAwMDsKIAkJCQlnb3RvIFNlY3Q7CisJCQljYXNlIDE4OgorCQkJCWlmKGwgPCA0KQorCQkJCQln b3RvIFRvb3Nob3J0OworCQkJCWktPmZsYWdzID0gZ2V0MzIocCk7CisJCQkJYnJlYWs7CiAJCQlj YXNlIDE5OgogCQkJCWlmKGktPm1haW4ubnNlY3QgPj0gbmVsZW0oaS0+bWFpbi5zZWN0KSkKIAkJ CQkJcmV0dXJuICJ0b28gbWFueSBtYWluIHNlY3Rpb25zIjsKQEAgLTE5ODQsNyArMjAwOCw3IEBA CiAJKnArKyA9IG1jY1swXTsKIAkqcCsrID0gMDsKIAkqcCsrID0gMDsJLy8gcmVzZXJ2ZWQKLQlp ZigxKXsKKwlpZihjdGxyLT5mdy0+Y2FwYVsyXSAmIFVjb2RlQ2FwTGFyMil7CiAJCXAgKz0gNDsK IAkJcCArPSA1KjQ7CiAJfQpAQCAtMjI3Miw3ICsyMjk2LDkgQEAKIAkJCWVhWzVdID0gYTEgPj4g MDsKIAkJfQogCX0gZWxzZSB7Ci0JCXJlYWRudm1zZWN0KGN0bHIsIDAsIGVhLCBFYWRkcmxlbiwg MHgxNTw8MSk7CisJCS8qIGZ3IGdldHMgYW5ncnkgaWYgd2UgcmVhZCA2IGJ5dGVzIGluc3RlYWQg b2YgOCAqLworCQlyZWFkbnZtc2VjdChjdGxyLCAwLCBidWYsIDgsIDB4MTU8PDEpOworCQltZW1t b3ZlKGVhLCBidWYsIEVhZGRybGVuKTsKIAl9CiAJbWVtbW92ZShjdGxyLT5lZGV2LT5hZGRyLCBl YSwgRWFkZHJsZW4pOwogCkBAIC0yNjQxLDcgKzI2NjcsNyBAQAogc2V0dGltZWV2ZW50KEN0bHIg KmN0bHIsIGludCBhbXIsIGludCBpdmFsKQogewogCWludCBkdXJhdGlvbiwgZGVsYXksIHRpbWVp ZDsKLQl1Y2hhciBjWzkqNF0sICpwOworCXVjaGFyIGNbMTQqNF0sICpwOwogCWNoYXIgKmVycjsK IAogCXN3aXRjaChhbXIpewpAQCAtMjY4MiwxNiArMjcwOCw0MCBAQAogCXAgKz0gNDsKIAlwdXQz MihwLCBkZWxheSk7CiAJcCArPSA0OworCWlmKChjdGxyLT5mdy0+ZmxhZ3MgJiBVY29kZUZsZ1Rl MikgPT0gMCl7CisJCXB1dDMyKHAsIDApOyAJLy8gZGVwIHBvbGljeQorCQlwICs9IDQ7CisJfQog CXB1dDMyKHAsIDApOwkvLyBkZXBlbmRzIG9uCiAJcCArPSA0OwotCXB1dDMyKHAsIDEpOwkvLyBp bnRlcnZhbAotCXAgKz0gNDsKLQlwdXQzMihwLCBkdXJhdGlvbik7Ci0JcCArPSA0OwotCSpwKysg PSAxOwkvLyByZXBlYXQKLQkqcCsrID0gMDsJLy8gbWF4IGZyYWdzCi0JcHV0MTYocCwgMTw8MCB8 IDE8PDEgfCAxPDwxMSk7CS8vIHBvbGljeQotCXAgKz0gMjsKKwlpZigoY3Rsci0+ZnctPmZsYWdz ICYgVWNvZGVGbGdUZTIpID09IDApeworCQlwdXQzMihwLCAwKTsJLy8gaXMgcHJlc2VudCAocmV2 ZXJzZSBvZiBhYnNlbmNlIGZsYWcpCisJCXAgKz0gNDsKKwl9CisJCisJaWYoY3Rsci0+ZnctPmZs YWdzICYgVWNvZGVGbGdUZTIpeworCQlwdXQzMihwLCAxKTsJLy8gaW50ZXJ2YWwKKwkJcCArPSA0 OworCQlwdXQzMihwLCBkdXJhdGlvbik7CisJCXAgKz0gNDsKKwkJKnArKyA9IDE7CS8vIHJlcGVh dAorCQkqcCsrID0gMDsJLy8gbWF4IGZyYWdzCisJCXB1dDE2KHAsIDE8PDAgfCAxPDwxIHwgMTw8 MTEpOwkvLyBwb2xpY3kKKwkJcCArPSAyOworCX1lbHNleworCQlwdXQzMihwLCAwKTsJLy8gbWF4 IGZyYWdzCisJCXAgKz0gNDsKKwkJcHV0MzIocCwgMSk7CS8vIGludGVydmFsCisJCXAgKz0gNDsK KwkJcHV0MzIocCwgMCk7CS8vIGludGVydmFsIHJlY2lwcm9jYWwgKFVOVVNFRCkKKwkJcCArPSA0 OworCQlwdXQzMihwLCBkdXJhdGlvbik7CisJCXAgKz0gNDsKKwkJcHV0MzIocCwgMSk7CS8vIHJl cGVhdAorCQlwICs9IDQ7CisJCXB1dDMyKHAsIDE8PDAgfCAxPDwxKTsJLy8gbm90aWZ5CisJCXAg Kz0gNDsKKwl9CiAKIAljdGxyLT50ZS5hY3RpdmUgPSAwOwogCWlmKChlcnIgPSAgY21kKGN0bHIs IDQxLCBjLCBwIC0gYykpICE9IG5pbCkKQEAgLTI4MjIsMTMgKzI4NzIsMTMgQEAKIAlyZXR1cm4g Y21kKGN0bHIsIDIxMCwgYywgMTEqNCk7CiB9CiAKLXN0YXRpYyB2b2lkCitzdGF0aWMgY2hhcioK IHR0dHhiYWNrb2ZmKEN0bHIgKmN0bHIpCiB7CiAJdWNoYXIgY1s0XTsKIAkKIAlwdXQzMihjLCAw KTsKLQljbWQoY3RsciwgMTI2LCBjLCBzaXplb2YoYykpOworCXJldHVybiBjbWQoY3RsciwgMTI2 LCBjLCBzaXplb2YoYykpOwogfQogCiBzdGF0aWMgY2hhcioKQEAgLTI4OTcsMTYgKzI5NDcsMTYg QEAKIAogCQkvKiBJbml0aWFsaXplIHR4IGJhY2tvZmZzIHRvIHRoZSBtaW5pbXVtLiAqLwogCQlp ZihjdGxyLT5mYW1pbHkgPT0gNzAwMCkKLQkJCXR0dHhiYWNrb2ZmKGN0bHIpOworCQkJaWYoKGVy ciA9IHR0dHhiYWNrb2ZmKGN0bHIpKSAhPSBuaWwpCisJCQkJcmV0dXJuIGVycjsKIAogCQlpZigo ZXJyID0gdXBkYXRlZGV2aWNlcG93ZXIoY3RscikpICE9IG5pbCl7CiAJCQlwcmludCgiY2FuJ3Qg dXBkYXRlIGRldmljZSBwb3dlcjogJXNcbiIsIGVycik7CiAJCQlyZXR1cm4gZXJyOwogCQl9Ci0J CWlmKChlcnIgPSBzZW5kbWNjdXBkYXRlKGN0bHIsICJaWiIpKSAhPSBuaWwpewotCQkJcHJpbnQo ImNhbid0IGRpc2FibGUgYmVhY29uIGZpbHRlcjogJXNcbiIsIGVycik7Ci0JCQlyZXR1cm4gZXJy OwotCQl9CisJCWlmKGN0bHItPmZ3LT5jYXBhWzBdICYgVWNvZGVDYXBMYXIpCisJCQlpZigoZXJy ID0gc2VuZG1jY3VwZGF0ZShjdGxyLCAiWloiKSkgIT0gbmlsKQorCQkJCXJldHVybiBlcnI7CiAJ CWlmKChlcnIgPSBkaXNhYmxlYmVhY29uZmlsdGVyKGN0bHIpKSAhPSBuaWwpewogCQkJcHJpbnQo ImNhbid0IGRpc2FibGUgYmVhY29uIGZpbHRlcjogJXNcbiIsIGVycik7CiAJCQlyZXR1cm4gZXJy OwpAQCAtMzQxOCw2ICszNDY4LDcgQEAKIHN0YXRpYyBjaGFyKgogcWNtZChDdGxyICpjdGxyLCB1 aW50IHFpZCwgdWludCBjb2RlLCB1Y2hhciAqZGF0YSwgaW50IHNpemUsIEJsb2NrICpibG9jaykK IHsKKwljaGFyICplcnI7CiAJaW50IGhkcmxlbjsKIAlCbG9jayAqYmNtZDsKIAl1Y2hhciAqZCwg KmM7CkBAIC0zNDUyLDEwICszNTAzLDEwIEBACiAJCXJldHVybiAicWNtZDogYnJva2VuIjsKIAl9 CiAJLyogd2FrZSB1cCB0aGUgbmljIChqdXN0IG5lZWRlZCBmb3IgN2spICovCi0JaWYoY3Rsci0+ ZmFtaWx5ID09IDcwMDAgJiYgcS0+biA9PSAwKQotCQlpZihuaWNsb2NrKGN0bHIpICE9IG5pbCl7 CisJaWYoY3Rsci0+ZmFtaWx5ID09IDcwMDAgJiYgcWlkID09IDQgJiYgcS0+biA9PSAwKQorCQlp ZigoZXJyID0gbmljbG9jayhjdGxyKSkgIT0gbmlsKXsKIAkJCWl1bmxvY2soY3Rscik7Ci0JCQly ZXR1cm4gInFjbWQ6IGJ1c3kiOworCQkJcmV0dXJuIGVycjsKIAkJfQogCXEtPm4rKzsKIAlxLT5s YXN0Y21kID0gY29kZTsKQEAgLTQyODMsOCArNDMzNCw4IEBACiAJCWlmKHR4ICE9IG5pbCAmJiB0 eC0+biA+IDApewogCQkJdHgtPm4tLTsKIAkJCXdha2V1cCh0eCk7Ci0JCQkvKiB1bmxvY2sgN2sg ZmFtaWx5IG5pY3MgYXMgYWxsIGNvbW1hbmRzIGFyZSBkb25lICovCi0JCQlpZihjdGxyLT5mYW1p bHkgPT0gNzAwMCAmJiB0eC0+biA9PSAwKQorCQkJLyogdW5sb2NrIDdrIGZhbWlseSBuaWNzIGFz IHRoZSBjb21tYW5kIGlzIGRvbmUgKi8KKwkJCWlmKGN0bHItPmZhbWlseSA9PSA3MDAwICYmIHFp ZCA9PSA0ICYmIHR4LT5uID09IDApCiAJCQkJbmljdW5sb2NrKGN0bHIpOwogCQl9CiAJfQo= --0000000000002a354d05c91f34a1--