From: kemal <kemalinanc8@gmail.com>
To: 9front@9front.org
Subject: Re: [9front] libsec: fix bugs in tls extension handling
Date: Mon, 18 Oct 2021 12:36:17 +0000 [thread overview]
Message-ID: <CABO6shc=xG4m5YdUxZVf0VwLhZxnDeNYYxn5oNoRWxg-ehMQog@mail.gmail.com> (raw)
In-Reply-To: <1377E3A11595780C9A5DE8671CDBA417@felloff.net>
> seems good, except the following, which seems wrong as the
> size calculation puts n twice, but they are different things.
>
> i do not see why it needs to be modified. also it is not
> explained in the commit.
i removed the pointformats array because rfc 8422 deprecated
point formats other than uncompressed, so i thought it would be
fine to just hardcode uncompressed point format.
A client compliant with this specification that supports no other
curves MUST send the following octets; note that the first two octets
indicate the extension type (Supported Point Formats Extension):
00 0B 00 02 01 00
so it's not a critical change.
about why i put n twice to the realloc size, well i think i did that
accidentally. "2+2+1+n" should be "2+2+1+1".
next prev parent reply other threads:[~2021-10-18 14:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-17 17:38 kemal
2021-10-17 23:15 ` cinap_lenrek
2021-10-18 12:36 ` kemal [this message]
2021-10-18 16:22 ` cinap_lenrek
2021-10-17 23:36 ` cinap_lenrek
2021-10-17 23:46 ` cinap_lenrek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABO6shc=xG4m5YdUxZVf0VwLhZxnDeNYYxn5oNoRWxg-ehMQog@mail.gmail.com' \
--to=kemalinanc8@gmail.com \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).