From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: * X-Spam-Status: No, score=1.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,RDNS_NONE autolearn=no autolearn_force=no version=3.4.4 Received: (qmail 32291 invoked from network); 18 Oct 2021 14:42:47 -0000 Received: from unknown (HELO 4ess.inri.net) (216.126.196.42) by inbox.vuxu.org with ESMTPUTF8; 18 Oct 2021 14:42:47 -0000 Received: from mail-ot1-f42.google.com ([209.85.210.42]) by 4ess; Mon Oct 18 08:44:44 -0400 2021 Received: by mail-ot1-f42.google.com with SMTP id l24-20020a9d1c98000000b00552a5c6b23cso2277919ota.9 for <9front@9front.org>; Mon, 18 Oct 2021 05:44:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=LivaiH3UgH2LbGzKj+BUSpiV6ueeL5E4QtGhxBHjE2A=; b=OvOcGUuo6VijCaYXErUFtFacWqi4KsIIjNrI0q2ls0Zki7KSPzpUizCampSXvxXFko 8sWA74TkaZ/xF/Xfy/WBnSobu2VFZUs2+gij5xRPP4jVT+uXYFwUU4StGgurkugyH9h9 GpXEnHTCUq9itNg/Snm7BVnwJHK58/R7UEQNGPnLxUoiO8w/XHdOHsftD4mVGF6vKjYz AtLAe6iVbzuijpzPrn4+IoT2unMD9XSiPS374M27a2gb2zsgBi76I3dCDYHJ+PZA5Wwk dTGmccOJJGWjR1bEF2d83YGRZZtCCyF0O4lPDsE58mUT+pRmZgoI2acLe2BAVIJ19Ojb nV7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=LivaiH3UgH2LbGzKj+BUSpiV6ueeL5E4QtGhxBHjE2A=; b=YzCWQXT3xJzn8XZZLL0bNTT0LJrXyBiwnpU0lSJyY74WJT98+xJz6wIX828GAr8eKw uSBuX0n3vbmyiZ6vcsWpLV2nQ2Xay5ZvN4m5QDaq4ICWcr+kQWiXCyXQZBkkw7EzD215 PX/IpQ4ivBsEguQGGycGyyAsRwm/5p+5rY/Zf0NzTAUzVgTNK7srT00qpeGpI54KfM/c 84EnQPPlFw8JzTppBdnwjYXV6+qZJQib1cABItdnbGK/Zdw1Cbi1C/AAGzqquvId5OjJ WFpfzh0oL6UGQRZRwY6F9li4aYrJBR6BPIoFcsh+IiBh9M49zwky3I0E+zAMvXxjsMce ZHbg== X-Gm-Message-State: AOAM530BMmf1F61PH8oYzKLC0471DKXXJSeCC+4bRkusbg3wwgRfWMnk O+ANrBpQXP4ISQlq0fWvJI+7vqiWRCbU2hkfs3CndMimFeaReQ== X-Google-Smtp-Source: ABdhPJxJQL0YYwg0cDQ9uQrN9tE+Qd4h/pCl1PSsH5Skq33Y0aHAKGDAq/IJe3TaxqLbgmr89CHm5ePx4AgUXXaxrro= X-Received: by 2002:a25:df84:: with SMTP id w126mr28352435ybg.109.1634560589352; Mon, 18 Oct 2021 05:36:29 -0700 (PDT) MIME-Version: 1.0 References: <1377E3A11595780C9A5DE8671CDBA417@felloff.net> In-Reply-To: <1377E3A11595780C9A5DE8671CDBA417@felloff.net> From: kemal Date: Mon, 18 Oct 2021 12:36:17 +0000 Message-ID: To: 9front@9front.org Content-Type: text/plain; charset="UTF-8" List-ID: <9front.9front.org> List-Help: X-Glyph: ➈ X-Bullshit: GPU strategy WEB2.0 app realtime optimizer Subject: Re: [9front] libsec: fix bugs in tls extension handling Reply-To: 9front@9front.org Precedence: bulk > seems good, except the following, which seems wrong as the > size calculation puts n twice, but they are different things. > > i do not see why it needs to be modified. also it is not > explained in the commit. i removed the pointformats array because rfc 8422 deprecated point formats other than uncompressed, so i thought it would be fine to just hardcode uncompressed point format. A client compliant with this specification that supports no other curves MUST send the following octets; note that the first two octets indicate the extension type (Supported Point Formats Extension): 00 0B 00 02 01 00 so it's not a critical change. about why i put n twice to the realloc size, well i think i did that accidentally. "2+2+1+n" should be "2+2+1+1".