From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 Received: (qmail 24021 invoked from network); 22 Jul 2023 21:58:49 -0000 Received: from 9front.inri.net (168.235.81.73) by inbox.vuxu.org with ESMTPUTF8; 22 Jul 2023 21:58:49 -0000 Received: from mail-wm1-f52.google.com ([209.85.128.52]) by 9front; Sat Jul 22 17:54:01 -0400 2023 Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-3fbd33a57b6so29160385e9.2 for <9front@9front.org>; Sat, 22 Jul 2023 14:53:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690062839; x=1690667639; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=rrssbZm4kYxAMAYWkrm/I3DDLgJE6QbGLNEeRZVCaLs=; b=PNJaV1/hA9DmyvSIZlYqdmCNaymH4xx/XPyqf7EQMmebTBEoUbpehoVRtnrtSLZEX4 ueHlEVkR19gfDTZLgCCsTxPNhtVLsWwjBSU1ZCWvRUpm8YcV8lLpx2dZybhpXvWhAPsf +mO6SQEN7qqxfTdkWM0WYTd1VeygPZ6dLUCsnbsWonxeLxgvElHHioh4Bh0iAtZAS5Jv 7oel1UvGGWr/BmRocGTo3BAHhzlXtu0fZ/aZmbBiYSTG2xB/7QAegdorifendVaVI3wK jCOeqoFxiFoMEwCSbUYKt/C1Lm/9cHShtcmTM7qAenqfkIoUEr1GtX93vmXHYSAogOml SQ8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690062839; x=1690667639; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rrssbZm4kYxAMAYWkrm/I3DDLgJE6QbGLNEeRZVCaLs=; b=S0Qqjxr9PIA/p57GxfcjxziFM1leNgKAoC4tujJBDzC9TxTrOlEi7rUTSYJmcjEIZY RdmLIoatWKLRKc9Z22nXHM8QjKc+MfXutY33UMMA4Ku9qOpBTvXDa3GRXJIHRVO8F4qG N5KrYXAMcbzXaHLz5W7wwj3XruB2Kh3MBpAHVIQB9cJnppbZk22MoMRjqx0K4XpHAfWJ 4PxlQexmNCyxS1M07BwBwKFc6+rfZrz4oL0lpxlUw/lS1zgY32JmjvjAJHivRlYB2NvX TIq6rjckgZhzHU2VMu6IgphfgM8adOBJ9IgmAwEjo+mBUbisstcWOvnjH1lV8tycwbrG DIog== X-Gm-Message-State: ABy/qLbBPEqTSjfDXPYg+N7Z4Dc1X3fFbv39JuG4zQ9pWUXrkRRctuZv XYNPL/xl3/SRdLk9hCsEMTa/wl/lkEjmNQTfruoSY8G6 X-Google-Smtp-Source: APBJJlFAm+/xSgYl6nxaVSURXpSa9IeyRSz5qsjtspCTdIMZqP2rdORxvCHiuwRyqTAtMndI750J6KSPYLh04lX4Auc= X-Received: by 2002:aa7:c94f:0:b0:522:1a98:3cad with SMTP id h15-20020aa7c94f000000b005221a983cadmr1655995edt.22.1690055598823; Sat, 22 Jul 2023 12:53:18 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a05:7208:6008:b0:6d:9fbe:181 with HTTP; Sat, 22 Jul 2023 12:53:17 -0700 (PDT) In-Reply-To: References: From: kemal Date: Sat, 22 Jul 2023 22:53:17 +0300 Message-ID: To: 9front@9front.org Content-Type: multipart/mixed; boundary="0000000000009e8cad060118bbf9" List-ID: <9front.9front.org> List-Help: X-Glyph: ➈ X-Bullshit: encrypted rich-client extension-oriented framework Subject: Re: [9front] Free Carrots #6: Tools For Fighting WiFi Inequality Reply-To: 9front@9front.org Precedence: bulk --0000000000009e8cad060118bbf9 Content-Type: text/plain; charset="UTF-8" > > i'm 99% sure it's coincidence, the pcie version or connector shape > > shouldn't matter. it both does and doesn't intel changed the firmware significantly in the 7000 series, which coincides with intel's mpcie->m2 switch in wifi cards there are both 6000 series m2 cards as you mentioned and 7000 series mpcie cards (7260-7265 have mpcie versions to my knowledge) so this problem is about 7000+ series of cards (3000 series are 1x1 versions of 7000) because of this a different code path exists for initialization, there's probably some bug in it. i checked the latest patch i prepared a long time ago for 7260 support and i realized there was a change i made that i forgot about (maybe i didn't send that patch at all, i don't remember...) the calibration commands in the main firmware initialization doesn't include type+length in the command itself and simply sends the calibration block it may have caused the firmware to ignore calibration commands, which would result in botched calibration+slow speeds. (although if this was the case i'd expect the firmware returning a error to the driver, so i'm not sure on this) i prepared a patch to include this change i also cleaned up fw capability checking and added pci ids for 3165-3168 as those should work out of the box with the current code i can't test this patch, so i will attach it for those who want to test it can get pushed if it works --0000000000009e8cad060118bbf9 Content-Type: application/octet-stream; name="etheriwl.diff" Content-Disposition: attachment; filename="etheriwl.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lkeevl7s0 ZGlmZiBmNmFjMTgyZjg2YmYwYmNjNzc3YTc2ZGI1MGY5NDIyN2VmNmY3OTYyIHVuY29tbWl0dGVk Ci0tLSBhL3N5cy9zcmMvOS9wb3J0L2V0aGVyaXdsLmMKKysrIGIvc3lzL3NyYy85L3BvcnQvZXRo ZXJpd2wuYwpAQCAtMzMwLDI1ICszMzAsMTQgQEAKIH07CiAKIC8qCi0gKiB1Q29kZSBUTFYgYXBp Ci0gKi8KLWVudW0gewotCS8qIGFwaVswXSAqLwotCVVjb2RlQXBpU3RhCT0gMTw8MzAsCi19Owot Ci0vKgogICogdUNvZGUgY2FwYWJpbGl0aWVzCiAgKi8KIGVudW0gewotCS8qIGNhcGFbMF0gKi8K LQlVY29kZUNhcExhcgk9IDE8PDEsCisJVWNvZGVBcGlTdGEJPSAzMCwKIAotCS8qIGNhcGFbMV0g Ki8KLQlVY29kZUNhcFF1b3RhCT0gMTw8MTIsCi0JCi0JLyogY2FwYVsyXSAqLwotCVVjb2RlQ2Fw TGFyMgk9IDE8PDksCisJVWNvZGVDYXBhTGFyCT0gMSwKKwlVY29kZUNhcGFRdW90YQk9IDQ0LAor CVVjb2RlQ2FwYUxhcjIJPSA3MywKIH07CiAKIGVudW0gewpAQCAtNjU4LDggKzY0Nyw2IEBACiAJ VHlwZTYwMDUJPSAxMSwJLyogYWxzbyBDZW50cmlubyBBZHZhbmNlZC1OIDYwMzAsIDYyMzUgKi8K IAlUeXBlMjAzMAk9IDEyLAogCVR5cGUyMDAwCT0gMTYsCi0KLQlUeXBlNzI2MAk9IDIwLAogfTsK IAogc3RhdGljIHN0cnVjdCByYXRldGFiIHsKQEAgLTcyMSw2ICs3MDgsOCBAQAogCiAjZGVmaW5l IGNzcjMycihjLCByKQkoKigoYyktPm5pYysoKHIpLzQpKSkKICNkZWZpbmUgY3NyMzJ3KGMsIHIs IHYpCSgqKChjKS0+bmljKygocikvNCkpID0gKHYpKQorLyogbWFjcm8gdG8gaGVscCB3aXRoIGN0 bHItPmZ3LT4oYXBpfGNhcGEpICovCisjZGVmaW5lIGlzc2V0KGEsIGkpCSgoYSlbKGkpLzMyXSAm IDFVPDwoaSklMzIpCiAKIHN0YXRpYyB1aW50CiBnZXQxNih1Y2hhciAqcCl7CkBAIC0xMTE0LDcg KzExMDMsOCBAQAogCX0KIAogCS8qIEVuYWJsZSB0aGUgb3NjaWxsYXRvciB0byBjb3VudCB3YWtl IHVwIHRpbWUgZm9yIEwxIGV4aXQuICh3ZWlyZCBXL0EpICovCi0JaWYoY3Rsci0+dHlwZSA9PSBU eXBlNzI2MCl7CisJc3dpdGNoKGN0bHItPnBkZXYtPmRpZCl7CisJY2FzZSAweDA4YjE6IGNhc2Ug MHgwOGIyOiBjYXNlIDB4MDhiMzogY2FzZSAweDA4YjQ6IC8qIFdpcmVsZXNzIDcyNjAvMzE2MCAq LwogCQlpZigoZXJyID0gbmljbG9jayhjdGxyKSkgIT0gbmlsKQogCQkJcmV0dXJuIGVycjsKIApA QCAtMjAxNCw3ICsyMDA0LDcgQEAKIAkqcCsrID0gbWNjWzBdOwogCSpwKysgPSAwOwogCSpwKysg PSAwOwkvLyByZXNlcnZlZAotCWlmKGN0bHItPmZ3LT5jYXBhWzJdICYgVWNvZGVDYXBMYXIyKXsK KwlpZihpc3NldChjdGxyLT5mdy0+Y2FwYSwgVWNvZGVDYXBhTGFyMikpewogCQlwICs9IDQ7CiAJ CXAgKz0gNSo0OwogCX0KQEAgLTI0MDcsNyArMjM5Nyw3IEBACiAJCXAgKz0gMjsJCQkvKiBzbGVl cF90eF9jb3VudCAqLwogCQlwKys7CQkJLyogc2xlZXAgc3RhdGUgZmxhZ3MgKi8KIAotCQkqcCsr ID0gY3Rsci0+ZnctPmFwaVswXSAmIFVjb2RlQXBpU3RhID8gdHlwZSA6IDA7CQkvKiBzdGF0aW9u X3R5cGUgKi8KKwkJKnArKyA9IGlzc2V0KGN0bHItPmZ3LT5hcGksIFVjb2RlQXBpU3RhKSA/IHR5 cGUgOiAwOwkJLyogc3RhdGlvbl90eXBlICovCiAKIAkJcCArPSAyOwkJCS8qIGFzc29jIGlkICov CiAKQEAgLTI0MTYsNyArMjQwNiw3IEBACiAJCXB1dDMyKHAsIDE8PDApOwogCQlwICs9IDQ7CQkJ LyogdGZkX3F1ZXVlX21hc2sgKi8KIAotCQlpZihjdGxyLT5mdy0+YXBpWzBdICYgVWNvZGVBcGlT dGEpeworCQlpZihpc3NldChjdGxyLT5mdy0+YXBpLCBVY29kZUFwaVN0YSkpewogCQkJcCArPSAy OwkJLyogcnhfYmFfd2luZG93ICovCiAJCQlwKys7CQkvKiBzcF9sZW5ndGggKi8KIAkJCXArKzsJ CS8qIHVhcHNkX2FjcyAqLwpAQCAtMjc1MCw3ICsyNzQwLDcgQEAKIAl1Y2hhciBjWzQqKDMqNCld LCAqcDsKIAlpbnQgaTsKIAotCWlmKChjdGxyLT5mdy0+Y2FwYVsxXSAmIFVjb2RlQ2FwUXVvdGEp ID09IDApCisJaWYoIWlzc2V0KGN0bHItPmZ3LT5jYXBhLCBVY29kZUNhcGFRdW90YSkpCiAJCXJl dHVybiBuaWw7CiAKIAlpID0gMDsKQEAgLTI4ODMsNiArMjg3MywzOCBAQAogfQogCiBzdGF0aWMg Y2hhcioKK3NlbmRjYWxpYmRhdGEoQ3RsciAqY3RscikKK3sKKwlCbG9jayAqYjsKKwl1Y2hhciBj WzRdOworCWNoYXIgKmVycjsKKwlpbnQgaTsKKworCWZvcihpID0gMDsgaSA8IHNpemVvZihjdGxy LT5jYWxpYi5jbWQpOyBpKyspeworCQlpZigoYiA9IGN0bHItPmNhbGliLmNtZFtpXSkgPT0gbmls KQorCQkJY29udGludWU7CisJCWlmKGIgPT0gY3Rsci0+Y2FsaWIuY2ZnKQorCQkJcHV0MTYoYywg MSk7CisJCWVsc2UgaWYoYiA9PSBjdGxyLT5jYWxpYi5uY2gpCisJCQlwdXQxNihjLCAyKTsKKwkJ ZWxzZSBpZihjdGxyLT5jYWxpYi5jbWQraSA8IGN0bHItPmNhbGliLnBhcGQrbmVsZW0oY3Rsci0+ Y2FsaWIucGFwZCkpCisJCQlwdXQxNihjLCA0KTsKKwkJZWxzZSBpZihjdGxyLT5jYWxpYi5jbWQr aSA8IGN0bHItPmNhbGliLnR4cCtuZWxlbShjdGxyLT5jYWxpYi50eHApKQorCQkJcHV0MTYoYywg NSk7CisJCXB1dDE2KGMrMiwgQkxFTihiKSk7CisJCQorCQliID0gY29weWJsb2NrKGIsIEJMRU4o YikpOworCQlpZigoZXJyID0gcWNtZChjdGxyLCA0LCAxMDgsIGMsIHNpemVvZihjKSwgYikpICE9 IG5pbCl7CisJCQlmcmVlYihiKTsKKwkJCXJldHVybiBlcnI7CisJCX0KKwkJaWYoKGVyciA9IGZs dXNocShjdGxyLCA0KSkgIT0gbmlsKQorCQkJcmV0dXJuIGVycjsKKwl9CisJcmV0dXJuIG5pbDsK K30KKworc3RhdGljIGNoYXIqCiBwb3N0Ym9vdDcwMDAoQ3RsciAqY3RscikKIHsKIAljaGFyICpl cnI7CkBAIC0yOTE0LDIxICsyOTM2LDkgQEAKIAkJCWN0bHItPmNhbGliLmRvbmUgPSAxOwogCQl9 CiAJfSBlbHNlIHsKLQkJQmxvY2sgKmI7Ci0JCWludCBpOworCQlpZigoZXJyID0gc2VuZGNhbGli ZGF0YShjdGxyKSkgIT0gbmlsKQorCQkJcmV0dXJuIGVycjsKIAotCQlmb3IoaSA9IDA7IGkgPCBu ZWxlbShjdGxyLT5jYWxpYi5jbWQpOyBpKyspewotCQkJaWYoKGIgPSBjdGxyLT5jYWxpYi5jbWRb aV0pID09IG5pbCkKLQkJCQljb250aW51ZTsKLQkJCWIgPSBjb3B5YmxvY2soYiwgQkxFTihiKSk7 Ci0JCQlpZigocWNtZChjdGxyLCA0LCAxMDgsIG5pbCwgMCwgYikpICE9IG5pbCl7Ci0JCQkJZnJl ZWIoYik7Ci0JCQkJcmV0dXJuIGVycjsKLQkJCX0KLQkJCWlmKChlcnIgPSBmbHVzaHEoY3Rsciwg NCkpICE9IG5pbCkKLQkJCQlyZXR1cm4gZXJyOwotCQl9Ci0KIAkJaWYoKGVyciA9IHNlbmRwaHlj b25maWcoY3RsciwKIAkJCWN0bHItPmZ3LT5waHlza3UsCiAJCQljdGxyLT5mdy0+bWFpbi5kZWZj YWxpYi5mbG93bWFzaywKQEAgLTI5NDcsNyArMjk1Nyw3IEBACiAJCQlwcmludCgiY2FuJ3QgdXBk YXRlIGRldmljZSBwb3dlcjogJXNcbiIsIGVycik7CiAJCQlyZXR1cm4gZXJyOwogCQl9Ci0JCWlm KGN0bHItPmZ3LT5jYXBhWzBdICYgVWNvZGVDYXBMYXIpCisJCWlmKCFpc3NldChjdGxyLT5mdy0+ Y2FwYSwgVWNvZGVDYXBhTGFyKSkKIAkJCWlmKChlcnIgPSBzZW5kbWNjdXBkYXRlKGN0bHIsICJa WiIpKSAhPSBuaWwpCiAJCQkJcmV0dXJuIGVycjsKIAkJaWYoKGVyciA9IGRpc2FibGViZWFjb25m aWx0ZXIoY3RscikpICE9IG5pbCl7CkBAIC00NDIxLDcgKzQ0MzEsNyBAQAogCWludCBmYW1pbHk7 CiAJCiAJcGRldiA9IG5pbDsKLQl3aGlsZShwZGV2ID0gcGNpbWF0Y2gocGRldiwgVmludGVsLCAw KSkgeworCXdoaWxlKHBkZXYgPSBwY2ltYXRjaChwZGV2LCAweDgwODYsIDApKSB7CiAJCUN0bHIg KmN0bHI7CiAJCXZvaWQgKm1lbTsKIAkJCkBAIC00NDY3LDYgKzQ0NzcsNyBAQAogCQkJZnduYW1l ID0gIml3bS03MjYwLTE3IjsKIAkJCWJyZWFrOwogCQljYXNlIDB4MDhiMzoJLyogV2lyZWxlc3Mg QUMgMzE2MCAqLworCQljYXNlIDB4MDhiNDoJLyogV2lyZWxlc3MgQUMgMzE2MCAqLwogCQkJZmFt aWx5ID0gNzAwMDsKIAkJCWZ3bmFtZSA9ICJpd20tMzE2MC0xNyI7CiAJCQlicmVhazsKQEAgLTQ0 NzQsNiArNDQ4NSwxNSBAQAogCQljYXNlIDB4MDk1YjoJLyogV2lyZWxlc3MgQUMgNzI2NSAqLwog CQkJZmFtaWx5ID0gNzAwMDsKIAkJCWZ3bmFtZSA9ICJpd20tNzI2NS0xNyI7CisJCQlicmVhazsK KwkJY2FzZSAweDMxNjU6CS8qIFdpcmVsZXNzIEFDIDMxNjUgKi8KKwkJY2FzZSAweDMxNjY6CS8q IFdpcmVsZXNzIEFDIDMxNjUgKi8KKwkJCWZhbWlseSA9IDcwMDA7CisJCQlmd25hbWUgPSAiaXdt LTcyNjVELTI5IjsKKwkJCWJyZWFrOworCQljYXNlIDB4MjRmYjoJLyogV2lyZWxlc3MgQUMgMzE2 OCAqLworCQkJZmFtaWx5ID0gNzAwMDsKKwkJCWZ3bmFtZSA9ICJpd20tMzE2OC0yOSI7CiAJCQli cmVhazsKIAkJY2FzZSAweDI0ZjM6CS8qIFdpcmVsZXNzIEFDIDgyNjAgKi8KIAkJCWZhbWlseSA9 IDgwMDA7Cg== --0000000000009e8cad060118bbf9--