9front - general discussion about 9front
 help / color / mirror / Atom feed
From: kemal <kemalinanc8@gmail.com>
To: 9front@9front.org
Subject: [9front] devtls, libsec: removal of sslv3 support
Date: Sun, 24 Oct 2021 19:37:11 +0300	[thread overview]
Message-ID: <CABO6shd5L5kdeLhqA9VOA2PHyjzuL4T3G-z7PX_cDzWQx5PSBQ@mail.gmail.com> (raw)

> looks good to me, but we need a regression test for this
> as manual review turns out not to be good enougth as
> last time, your refactoring added an assert which broke
> all of tls 1.0 prf and nobody noticed for months.

and i forgot to check for `ext != nil` in checkClientExtensions,
which broke clients without extensions. i agree that we need
a regression test, my code has probably a bug somewhere.

> do you have some openssl scripts handy to run ssl3 and tls1.0
> and tls1.1 servers and clients against these changes?

i don't, i will try to prepare some when i'm available, then post
the test results here.

> can anyone help you with this?

i'd appreciate help.

> on another note. your devtls and tlshand changes are unrelated
> to the topic at hand. maybe have a separate topic for this?

sure, changed the topic.

                 reply	other threads:[~2021-10-24 16:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABO6shd5L5kdeLhqA9VOA2PHyjzuL4T3G-z7PX_cDzWQx5PSBQ@mail.gmail.com \
    --to=kemalinanc8@gmail.com \
    --cc=9front@9front.org \
    --subject='Re: [9front] devtls, libsec: removal of sslv3 support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).