From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 14776 invoked from network); 14 Aug 2021 21:13:15 -0000 Received: from 1ess.inri.net (216.126.196.35) by inbox.vuxu.org with ESMTPUTF8; 14 Aug 2021 21:13:15 -0000 Received: from mail-oi1-f173.google.com ([209.85.167.173]) by 1ess; Sat Aug 14 13:57:47 -0400 2021 Received: by mail-oi1-f173.google.com with SMTP id bj40so20835102oib.6 for <9front@9front.org>; Sat, 14 Aug 2021 10:57:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=3p/3D0HC8F7+N3KUsghwmUpFsYXduc4RDEDqtRSFQhY=; b=Xzjoz45OYrbhAsmfzixF32XgArPRZ24gZMRlluYWuL8tsRZg7PfwjX8fFcf6LndYRu lQcJQszLiL+cTh2aJVn37sk3EXG4/wwkl2fowQVYy1nEhOA8w2N8Gq0q6d0QA8P0lwJZ 2SPPbgj55yGpizoJJzOHfyXgBFuA9S6aFse1mBC3WMRFedxmc09UYviM9PrwYX6NkWIS OGdNL8zhEfCXAR8KUyKdCc4AqJOhFU7nj+yehFLOJVK5BCUrHYUL2fisH01QPHpmHVcK 9OZ05907JJLwKjKCb9xv8D3XI06Gu9S+l/xvnIkrmq0yIi8sA5kv70KaoRFFgxMG4/Lp pjmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=3p/3D0HC8F7+N3KUsghwmUpFsYXduc4RDEDqtRSFQhY=; b=dAeMSIZiZvLDSOivdJNahNehtMoOd75RNQ8psFXBeknR1kVUVQFr+hh45OASup5nwZ Vw6QLUJZQWFNVBjeLBA2S3uXIhyvDiaRDgJuqc/QvPvm9NxEQP6CE0GGcRsWROmjC7in FXUYRIE2KxHJEmA2Dai8yYx3Tff2iDC4xjsHUQXtJgn60dOdA5tUw4x1GsdTSHOaJd35 mRt0QpKc1CIgEMXlvM5QhqdunVgR4eIOgHNWBIbmRQXxJsfDpDmxs8b2H4wNX5SJ9Z1B KVzVahjbq439RT8Zqio05RCKaqpQefg4QA+IyaY9bGgp+BF207ST+y67XTm4ljmygvFA sX/A== X-Gm-Message-State: AOAM531c3Mk9e2wHXjCUC4v08NqzSSTMHOZFndM8zvfAnkX5ovUTr3C0 zDqNbgLr/Eu5n1laJOqVxWYVp9z530fXmteCAVeR2qO57j4= X-Google-Smtp-Source: ABdhPJz6nKr6fYp7W2hXKDenEoSDCovti0ZpymQo8GYscfu0HC4hAieEgH5UlaReyN3jqAQJmVsW52A8LJeMDDJijZc= X-Received: by 2002:aca:afcd:: with SMTP id y196mr6342165oie.71.1628963444092; Sat, 14 Aug 2021 10:50:44 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ac9:5981:0:0:0:0:0 with HTTP; Sat, 14 Aug 2021 10:50:43 -0700 (PDT) In-Reply-To: References: <4FC920AD055DC731A863EDE8BD601178@felloff.net> From: kemal Date: Sat, 14 Aug 2021 17:50:43 +0000 Message-ID: To: 9front@9front.org Content-Type: multipart/mixed; boundary="0000000000007022ac05c9889b76" List-ID: <9front.9front.org> List-Help: X-Glyph: ➈ X-Bullshit: interface engine-oriented frontend Subject: Re: [9front] driver for intel wireless 7260? Reply-To: 9front@9front.org Precedence: bulk --0000000000007022ac05c9889b76 Content-Type: text/plain; charset="UTF-8" 2021-08-13 23:41 GMT, kemal : > the current diff is attached. also ignore this diff. driver was reading the mac address from the nvm wrong. 1- as driver reads 8 bytes from nvm instead of 6 so fw doesn't spit us an ADVANCED_SYSASSERT, it was reading 2 more extra bytes. apparently those 2 extra bytes were put to the first 2 bytes of our buffer, so we got to skip that. 2- the mac address is encoded in a weird le16 order. we have to byte swap so we get the correct mac address. the current diff is attached. --0000000000007022ac05c9889b76 Content-Type: text/plain; charset="US-ASCII"; name="diff.txt" Content-Disposition: attachment; filename="diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: file0 LS0tIC9zeXMvc3JjLzkvcGMvZXRoZXJpd2wuYworKysgL3N5cy9zcmMvOS9wYy9ldGhlcml3bC5j CkBAIC0zMjksNyArMzI5LDI5IEBACiAJU2NoZWRUcmFuc1RibE9mZgk9IDB4N0UwLAkJLy8gK3Eq MgogfTsKIAorLyoKKyAqIHVDb2RlIFRMViBhcGkKKyAqLwogZW51bSB7CisJLyogYXBpWzBdICov CisJVWNvZGVBcGlTdGEJPSAxPDwzMCwKK307CisKKy8qCisgKiB1Q29kZSBjYXBhYmlsaXRpZXMK KyAqLworZW51bSB7CisJLyogY2FwYVswXSAqLworCVVjb2RlQ2FwTGFyCT0gMTw8MSwKKworCS8q IGNhcGFbMV0gKi8KKwlVY29kZUNhcFF1b3RhCT0gMTw8MTIsCisJCisJLyogY2FwYVsyXSAqLwor CVVjb2RlQ2FwTGFyMgk9IDE8PDksCit9OworCitlbnVtIHsKIAlGaWx0ZXJQcm9taXNjCQk9IDE8 PDAsCiAJRmlsdGVyQ3RsCQk9IDE8PDEsCiAJRmlsdGVyTXVsdGljYXN0CQk9IDE8PDIsCkBAIC00 MTgsNiArNDQwLDcgQEAKIAl1aW50CWJ1aWxkOwogCWNoYXIJZGVzY3JbNjQrMV07CiAKKwl1MzJp bnQJZmxhZ3M7CiAJdTMyaW50CWNhcGFbNF07CiAJdTMyaW50CWFwaVs0XTsKIApAQCAtNjM1LDcg KzY1OCw3IEBACiAJVHlwZTIwMzAJPSAxMiwKIAlUeXBlMjAwMAk9IDE2LAogCi0JVHlwZTcyNjAJ PSAzMCwKKwlUeXBlNzI2MAk9IDIwLAogCVR5cGU4MjY1CT0gMzUsCiB9OwogCkBAIC0xNDc4LDYg KzE1MDEsMTEgQEAKIAkJCQlzID0gJmktPmJvb3QudGV4dDsKIAkJCQlzLT5hZGRyID0gMHgwMDAw MDAwMDsKIAkJCQlnb3RvIFNlY3Q7CisJCQljYXNlIDE4OgorCQkJCWlmKGwgPCA0KQorCQkJCQln b3RvIFRvb3Nob3J0OworCQkJCWktPmZsYWdzID0gZ2V0MzIocCk7CisJCQkJYnJlYWs7CiAJCQlj YXNlIDE5OgogCQkJCWlmKGktPm1haW4ubnNlY3QgPj0gbmVsZW0oaS0+bWFpbi5zZWN0KSkKIAkJ CQkJcmV0dXJuICJ0b28gbWFueSBtYWluIHNlY3Rpb25zIjsKQEAgLTE5ODQsNyArMjAxMiw3IEBA CiAJKnArKyA9IG1jY1swXTsKIAkqcCsrID0gMDsKIAkqcCsrID0gMDsJLy8gcmVzZXJ2ZWQKLQlp ZigxKXsKKwlpZihjdGxyLT5mdy0+Y2FwYVsyXSAmIFVjb2RlQ2FwTGFyMil7CiAJCXAgKz0gNDsK IAkJcCArPSA1KjQ7CiAJfQpAQCAtMjI3Miw3ICsyMzAwLDE1IEBACiAJCQllYVs1XSA9IGExID4+ IDA7CiAJCX0KIAl9IGVsc2UgewotCQlyZWFkbnZtc2VjdChjdGxyLCAwLCBlYSwgRWFkZHJsZW4s IDB4MTU8PDEpOworCQkvKiBmdyBnZXRzIGFuZ3J5IGlmIHdlIHJlYWQgNiBieXRlcyAqLworCQly ZWFkbnZtc2VjdChjdGxyLCAwLCBidWYsIDgsIDB4MTU8PDEpOworCQkvKiB0aGUgZmlyc3QgMiBi eXRlcyBpcyBnYXJiYWdlIGFuZCB0aGUgYnl0ZSBvcmRlciBpcyBsZTE2ICovCisJCWVhWzBdID0g YnVmWzNdOworCQllYVsxXSA9IGJ1ZlsyXTsKKwkJZWFbMl0gPSBidWZbNV07CisJCWVhWzNdID0g YnVmWzRdOworCQllYVs0XSA9IGJ1Zls3XTsKKwkJZWFbNV0gPSBidWZbNl07CiAJfQogCW1lbW1v dmUoY3Rsci0+ZWRldi0+YWRkciwgZWEsIEVhZGRybGVuKTsKIApAQCAtMjM2Niw3ICsyNDAyLDcg QEAKIAkJcCArPSAyOwkJCS8qIHNsZWVwX3R4X2NvdW50ICovCiAJCXArKzsJCQkvKiBzbGVlcCBz dGF0ZSBmbGFncyAqLwogCi0JCSpwKysgPSAoY3Rsci0+ZnctPmFwaVswXSAmICgxPDwzMCkpICE9 IDAgPyB0eXBlIDogMDsJCS8qIHN0YXRpb25fdHlwZSAqLworCQkqcCsrID0gY3Rsci0+ZnctPmFw aVswXSAmIFVjb2RlQXBpU3RhID8gdHlwZSA6IDA7CQkvKiBzdGF0aW9uX3R5cGUgKi8KIAogCQlw ICs9IDI7CQkJLyogYXNzb2MgaWQgKi8KIApAQCAtMjM3NSw3ICsyNDExLDcgQEAKIAkJcHV0MzIo cCwgMTw8MCk7CiAJCXAgKz0gNDsJCQkvKiB0ZmRfcXVldWVfbWFzayAqLwogCi0JCWlmKDEpewor CQlpZihjdGxyLT5mdy0+YXBpWzBdICYgVWNvZGVBcGlTdGEpewogCQkJcCArPSAyOwkJLyogcnhf YmFfd2luZG93ICovCiAJCQlwKys7CQkvKiBzcF9sZW5ndGggKi8KIAkJCXArKzsJCS8qIHVhcHNk X2FjcyAqLwpAQCAtMjY0MCw3ICsyNjc2LDcgQEAKIHN0YXRpYyBjaGFyKgogc2V0dGltZWV2ZW50 KEN0bHIgKmN0bHIsIGludCBhbXIsIGludCBpdmFsKQogewotCWludCBkdXJhdGlvbiwgZGVsYXks IHRpbWVpZDsKKwlpbnQgdGltZWlkOwogCXVjaGFyIGNbOSo0XSwgKnA7CiAJY2hhciAqZXJyOwog CkBAIC0yNjYyLDE0ICsyNjk4LDYgQEAKIAkJYnJlYWs7CiAJfQogCi0JaWYoaXZhbCl7Ci0JCWR1 cmF0aW9uID0gaXZhbCoyOwotCQlkZWxheSA9IGl2YWwvMjsKLQl9IGVsc2UgewotCQlkdXJhdGlv biA9IDEwMjQ7Ci0JCWRlbGF5ID0gMDsKLQl9Ci0KIAltZW1zZXQocCA9IGMsIDAsIHNpemVvZihj KSk7CiAJcHV0MzIocCwgY3Rsci0+bWFjaWQpOwogCXAgKz0gNDsKQEAgLTI2NzgsMzIgKzI3MDYs MzYgQEAKIAlwdXQzMihwLCB0aW1laWQpOwogCXAgKz0gNDsKIAotCXB1dDMyKHAsIDApOwkvLyBh cHBseSB0aW1lCi0JcCArPSA0OwotCXB1dDMyKHAsIGRlbGF5KTsKLQlwICs9IDQ7Ci0JcHV0MzIo cCwgMCk7CS8vIGRlcGVuZHMgb24KLQlwICs9IDQ7Ci0JcHV0MzIocCwgMSk7CS8vIGludGVydmFs Ci0JcCArPSA0OwotCXB1dDMyKHAsIGR1cmF0aW9uKTsKLQlwICs9IDQ7Ci0JKnArKyA9IDE7CS8v IHJlcGVhdAotCSpwKysgPSAwOwkvLyBtYXggZnJhZ3MKLQlwdXQxNihwLCAxPDwwIHwgMTw8MSB8 IDE8PDExKTsJLy8gcG9saWN5Ci0JcCArPSAyOworCWlmKGFtciA9PSBDbWRSZW1vdmUpCisJCXAg Kz0gNio0OworCWVsc2V7CisJCXB1dDMyKHAsIDApOwkJCS8vIGFwcGx5IHRpbWUKKwkJcCArPSA0 OworCQlwdXQzMihwLCBpdmFsLzIpOwkJLy8gbWF4IGRlbGF5CisJCXAgKz0gNDsKKwkJcHV0MzIo cCwgMCk7CQkJLy8gZGVwZW5kcyBvbgorCQlwICs9IDQ7CisJCXB1dDMyKHAsIDEpOwkJCS8vIGlu dGVydmFsCisJCXAgKz0gNDsKKwkJcHV0MzIocCwgaXZhbD8gaXZhbCoyOiAxMDI0KTsJLy8gZHVy YXRpb24KKwkJcCArPSA0OworCQkqcCsrID0gMTsJCQkvLyByZXBlYXQKKwkJKnArKyA9IDA7CQkJ Ly8gbWF4IGZyYWdzCisJCXB1dDE2KHAsIDE8PDAgfCAxPDwxIHwgMTw8MTEpOwkvLyBwb2xpY3kK KwkJcCArPSAyOworCX0KIAogCWN0bHItPnRlLmFjdGl2ZSA9IDA7CiAJaWYoKGVyciA9ICBjbWQo Y3RsciwgNDEsIGMsIHAgLSBjKSkgIT0gbmlsKQogCQlyZXR1cm4gZXJyOwogCisJdHNsZWVwKCZj dGxyLT50ZSwgdGltZWV2ZW50ZG9uZSwgY3RsciwgMTAwKTsKIAlpZihhbXIgPT0gQ21kUmVtb3Zl KXsKIAkJY3Rsci0+dGUuYWN0aXZlID0gMDsKIAkJY3Rsci0+dGUuaWQgPSAtMTsKIAkJcmV0dXJu IG5pbDsKLQl9Ci0JdHNsZWVwKCZjdGxyLT50ZSwgdGltZWV2ZW50ZG9uZSwgY3RsciwgMTAwKTsK LQlyZXR1cm4gY3Rsci0+dGUuYWN0aXZlPyBuaWw6ICJ0aW1lZXZlbnQgZGlkIG5vdCBzdGFydCI7 CisJfWVsc2UKKwkJcmV0dXJuIGN0bHItPnRlLmFjdGl2ZT8gbmlsOiAidGltZWV2ZW50IGRpZCBu b3Qgc3RhcnQiOwogfQogCiAKQEAgLTI3MTMsNiArMjc0NSw5IEBACiAJdWNoYXIgY1s0KigzKjQp XSwgKnA7CiAJaW50IGk7CiAKKwlpZigoY3Rsci0+ZnctPmNhcGFbMV0gJiBVY29kZUNhcFF1b3Rh KSA9PSAwKQorCQlyZXR1cm4gbmlsOworCiAJaSA9IDA7CiAJcCA9IGM7CiAKQEAgLTI4MjIsMTMg KzI4NTcsMTMgQEAKIAlyZXR1cm4gY21kKGN0bHIsIDIxMCwgYywgMTEqNCk7CiB9CiAKLXN0YXRp YyB2b2lkCitzdGF0aWMgY2hhcioKIHR0dHhiYWNrb2ZmKEN0bHIgKmN0bHIpCiB7CiAJdWNoYXIg Y1s0XTsKIAkKIAlwdXQzMihjLCAwKTsKLQljbWQoY3RsciwgMTI2LCBjLCBzaXplb2YoYykpOwor CXJldHVybiBjbWQoY3RsciwgMTI2LCBjLCBzaXplb2YoYykpOwogfQogCiBzdGF0aWMgY2hhcioK QEAgLTI4NDgsNiArMjg4Myw5IEBACiAJY2hhciAqZXJyOwogCiAJaWYoY3Rsci0+Y2FsaWIuZG9u ZSA9PSAwKXsKKwkJaWYoY3Rsci0+ZmFtaWx5ID09IDcwMDApCisJCQlpZigoZXJyID0gc2VuZGJ0 Y29leGFkdihjdGxyKSkgIT0gbmlsKQorCQkJCXJldHVybiBlcnI7CiAJCWlmKChlcnIgPSByZWFk bnZtY29uZmlnKGN0bHIpKSAhPSBuaWwpCiAJCQlyZXR1cm4gZXJyOwogCX0KQEAgLTI4OTcsMTYg KzI5MzUsMTYgQEAKIAogCQkvKiBJbml0aWFsaXplIHR4IGJhY2tvZmZzIHRvIHRoZSBtaW5pbXVt LiAqLwogCQlpZihjdGxyLT5mYW1pbHkgPT0gNzAwMCkKLQkJCXR0dHhiYWNrb2ZmKGN0bHIpOwor CQkJaWYoKGVyciA9IHR0dHhiYWNrb2ZmKGN0bHIpKSAhPSBuaWwpCisJCQkJcmV0dXJuIGVycjsK IAogCQlpZigoZXJyID0gdXBkYXRlZGV2aWNlcG93ZXIoY3RscikpICE9IG5pbCl7CiAJCQlwcmlu dCgiY2FuJ3QgdXBkYXRlIGRldmljZSBwb3dlcjogJXNcbiIsIGVycik7CiAJCQlyZXR1cm4gZXJy OwogCQl9Ci0JCWlmKChlcnIgPSBzZW5kbWNjdXBkYXRlKGN0bHIsICJaWiIpKSAhPSBuaWwpewot CQkJcHJpbnQoImNhbid0IGRpc2FibGUgYmVhY29uIGZpbHRlcjogJXNcbiIsIGVycik7Ci0JCQly ZXR1cm4gZXJyOwotCQl9CisJCWlmKGN0bHItPmZ3LT5jYXBhWzBdICYgVWNvZGVDYXBMYXIpCisJ CQlpZigoZXJyID0gc2VuZG1jY3VwZGF0ZShjdGxyLCAiWloiKSkgIT0gbmlsKQorCQkJCXJldHVy biBlcnI7CiAJCWlmKChlcnIgPSBkaXNhYmxlYmVhY29uZmlsdGVyKGN0bHIpKSAhPSBuaWwpewog CQkJcHJpbnQoImNhbid0IGRpc2FibGUgYmVhY29uIGZpbHRlcjogJXNcbiIsIGVycik7CiAJCQly ZXR1cm4gZXJyOwpAQCAtMzQxOCw2ICszNDU2LDcgQEAKIHN0YXRpYyBjaGFyKgogcWNtZChDdGxy ICpjdGxyLCB1aW50IHFpZCwgdWludCBjb2RlLCB1Y2hhciAqZGF0YSwgaW50IHNpemUsIEJsb2Nr ICpibG9jaykKIHsKKwljaGFyICplcnI7CiAJaW50IGhkcmxlbjsKIAlCbG9jayAqYmNtZDsKIAl1 Y2hhciAqZCwgKmM7CkBAIC0zNDUyLDEwICszNDkxLDEwIEBACiAJCXJldHVybiAicWNtZDogYnJv a2VuIjsKIAl9CiAJLyogd2FrZSB1cCB0aGUgbmljIChqdXN0IG5lZWRlZCBmb3IgN2spICovCi0J aWYoY3Rsci0+ZmFtaWx5ID09IDcwMDAgJiYgcS0+biA9PSAwKQotCQlpZihuaWNsb2NrKGN0bHIp ICE9IG5pbCl7CisJaWYoY3Rsci0+ZmFtaWx5ID09IDcwMDAgJiYgcWlkID09IDQgJiYgcS0+biA9 PSAwKQorCQlpZigoZXJyID0gbmljbG9jayhjdGxyKSkgIT0gbmlsKXsKIAkJCWl1bmxvY2soY3Rs cik7Ci0JCQlyZXR1cm4gInFjbWQ6IGJ1c3kiOworCQkJcmV0dXJuIGVycjsKIAkJfQogCXEtPm4r KzsKIAlxLT5sYXN0Y21kID0gY29kZTsKQEAgLTM1ODYsOSArMzYyNSwxNiBAQAogCWludCBpOwog CiAJZm9yKGkgPSAwOyBpIDwgbmVsZW0oY3Rsci0+dHgpOyBpKyspCi0JCWZsdXNocShjdGxyLCBp KTsKLQlzZXR0aW1lZXZlbnQoY3RsciwgQ21kUmVtb3ZlLCAwKTsKKwkJaWYoKGVyciA9IGZsdXNo cShjdGxyLCBpKSkgIT0gbmlsKXsKKwkJCXByaW50KCJjYW4ndCBmbHVzaCBxdWV1ZSAlZDogJXNc biIsIGksIGVycik7CisJCQlyZXR1cm4gZXJyOworCQl9CiAKKwlpZigoZXJyID0gc2V0dGltZWV2 ZW50KGN0bHIsIENtZFJlbW92ZSwgMCkpICE9IG5pbCl7CisJCXByaW50KCJjYW4ndCByZW1vdmUg dGltZSBldmVudDogJXNcbiIsIGVycik7CisJCXJldHVybiBlcnI7CisJfQorCiAJaWYoKGVyciA9 IHNldGJpbmRpbmdxdW90YXMoY3RsciwgLTEpKSAhPSBuaWwpewogCQlwcmludCgiY2FuJ3QgZGlz YWJsZSBxdW90YXM6ICVzXG4iLCBlcnIpOwogCQlyZXR1cm4gZXJyOwpAQCAtMzYzMCw3ICszNjc2 LDcgQEAKIAkJcmV0dXJuIGVycjsKIAl9CiAJaWYoKGVyciA9IHNldGJpbmRpbmdjb250ZXh0KGN0 bHIsIENtZEFkZCkpICE9IG5pbCl7Ci0JCXByaW50KCJyZW1vdmluZyBiaW5kaW5nY29udGV4dDog JXNcbiIsIGVycik7CisJCXByaW50KCJhZGRpbmcgYmluZGluZ2NvbnRleHQ6ICVzXG4iLCBlcnIp OwogCQlyZXR1cm4gZXJyOwogCX0KIAlpZigoZXJyID0gc2V0bWNhc3RmaWx0ZXIoY3RscikpICE9 IG5pbCl7CkBAIC00MjgzLDggKzQzMjksOCBAQAogCQlpZih0eCAhPSBuaWwgJiYgdHgtPm4gPiAw KXsKIAkJCXR4LT5uLS07CiAJCQl3YWtldXAodHgpOwotCQkJLyogdW5sb2NrIDdrIGZhbWlseSBu aWNzIGFzIGFsbCBjb21tYW5kcyBhcmUgZG9uZSAqLwotCQkJaWYoY3Rsci0+ZmFtaWx5ID09IDcw MDAgJiYgdHgtPm4gPT0gMCkKKwkJCS8qIHVubG9jayA3ayBmYW1pbHkgbmljcyBhcyB0aGUgY29t bWFuZCBpcyBkb25lICovCisJCQlpZihjdGxyLT5mYW1pbHkgPT0gNzAwMCAmJiBxaWQgPT0gNCAm JiB0eC0+biA9PSAwKQogCQkJCW5pY3VubG9jayhjdGxyKTsKIAkJfQogCX0K --0000000000007022ac05c9889b76--