Re: [9front] driver for intel wireless 7260?

[kemal <kemalinanc8@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]

2021-08-06 4:43 GMT, qwx <qwx@sciops.net>:
> The patch unfortunately doesn't work for me after a quick test on
> a x240 (did=0x08b2), I have to change Type7260 to 20, not 30, and
> it just dies with a firmware error (with 6.9 firmware).
>
> I can't test more than that right now, but I'll try again later.

when you try it again, would you please mail the whole error
message here, so i can debug it? here is an example error
message:

#l1: firmware: iwm-7260-17, rev 11, build 3216344376, size [3]
14000+2c000 + [3] 14000+2c000 + 0
#l1: fatal firmware error
lastcmd: 136 (0x88)
error: id 65, trm_hw_status 000002f0 00000000,
branchlink2 0000099a, interruptlink 0000d340 0000b8ca,
errordata 00000000 00000200 02030000
#l1: cmd 136: flushq: broken
readnvmsect: flushq: broken
#l1: cmd 152: qcmd: broken
#l1: qcmd: broken

also apparently i'm not supposed to do the niclock/nicunlock
dance for tx commands, so check if qid == 4 so that we know
it was sent by cmd(). perhaps might solve things? diff attached.

[-- Attachment #2: diff.txt --]
[-- Type: text/plain, Size: 643 bytes --]

--- /sys/src/9/pc/etheriwl.c
+++ /sys/src/9/pc/etheriwl.c
@@ -3452,7 +3452,7 @@
 		return "qcmd: broken";
 	}
 	/* wake up the nic (just needed for 7k) */
-	if(ctlr->family == 7000 && q->n == 0)
+	if(ctlr->family == 7000 && qid == 4 && q->n == 0)
 		if(niclock(ctlr) != nil){
 			iunlock(ctlr);
 			return "qcmd: busy";
@@ -4283,8 +4283,8 @@
 		if(tx != nil && tx->n > 0){
 			tx->n--;
 			wakeup(tx);
-			/* unlock 7k family nics as all commands are done */
-			if(ctlr->family == 7000 && tx->n == 0)
+			/* unlock 7k family nics as the command is done */
+			if(ctlr->family == 7000 && qid == 4 && tx->n == 0)
 				nicunlock(ctlr);
 		}
 	}