From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 Received: (qmail 21250 invoked from network); 24 Jul 2023 10:33:03 -0000 Received: from 9front.inri.net (168.235.81.73) by inbox.vuxu.org with ESMTPUTF8; 24 Jul 2023 10:33:03 -0000 Received: from mail-lf1-f44.google.com ([209.85.167.44]) by 9front; Mon Jul 24 06:28:27 -0400 2023 Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-4fb960b7c9dso6276835e87.0 for <9front@9front.org>; Mon, 24 Jul 2023 03:28:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690194504; x=1690799304; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=HBDMAhWMvpiwyGf9BKeYxJsXFqd5wUC8V+ZFk+Od1qk=; b=nGt3G/W7xOAobvMugy7Bg29fHRiSScjxCH+Ha/r8mse3tgkzfV+g9V9e3C8H2XEvfN dpsPseKndIipSyS8Z4b4Ghn5L+Uj21eo+QcM2Boy58geQ97uar3zC4CsGLPboChyKC8q tbhUwvamSIEMmJbEsbkPs9yHo+IeJWbwymCQ7jz5HGaPhCductOuKl0AGj+sTnYzWN4p iXuRTIJlm8RVZBov8zEL9MMjPbNPo9sig2Q2SHWlUc6UsvKEdyjmm13xD3zpvVwlNc0/ cJARW0ZR+U8DBBwOjJSZZy/IGyspfms0hEMURd5zjGAIsFF1BWzwIsRTO+h/XS+6tVDs rNZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690194504; x=1690799304; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HBDMAhWMvpiwyGf9BKeYxJsXFqd5wUC8V+ZFk+Od1qk=; b=jZJhQZ5QfBhG2zcNM2UMV7ZzC9bp9C/mJU2tK55Xiv/aK84x0yRut7n3dJ22nEScy9 TJl8w9FFk9uW19VNgUEZS1XWdFAYF7UTVkQNKxQ8pJBny26JLjD9+4JCb1NDaPzYvIjy 4FE3R4sudIqb5HkpFLpvHEL1SgjpSizDt4OOjJxvmEWlkbRN76DLYYAbK1kmMB5nWTyG tgl9pcWqAWzopyUduGeTCVlz9Hc122YAGhGbnPwZLpj4QIhbjxRSfCjSh2mSloiMirdI ffeXFo2x4a7nstpu0c8IPAbQgklITYqhBWvnI4n5zbRd1uFCWtNRP81Ju4ByLj31isYG u63A== X-Gm-Message-State: ABy/qLZQDRhZZGGD+HnCoDjaf+sjZYBanXtMmBbvhuchA8sjvXz+K7qj burF8BmfWbks8XDHhod89c/czQo/juQxdmhCQIMzVgKN X-Google-Smtp-Source: APBJJlHzGVkvymQwA/Pd9Z6PwmlaW4kBZnpCmZOy5agBiy7e7mScFNH66b6aWzq9dTYyXrmFoPilCmkrxsbSr9wUClY= X-Received: by 2002:a17:906:10cf:b0:99b:4210:cc79 with SMTP id v15-20020a17090610cf00b0099b4210cc79mr9907764ejv.22.1690192684217; Mon, 24 Jul 2023 02:58:04 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a05:7208:6008:b0:6d:9fbe:181 with HTTP; Mon, 24 Jul 2023 02:58:03 -0700 (PDT) In-Reply-To: References: From: kemal Date: Mon, 24 Jul 2023 12:58:03 +0300 Message-ID: To: 9front@9front.org Content-Type: multipart/mixed; boundary="0000000000008baf5e060138a6e3" List-ID: <9front.9front.org> List-Help: X-Glyph: ➈ X-Bullshit: agile template storage rails Subject: Re: [9front] Free Carrots #6: Tools For Fighting WiFi Inequality Reply-To: 9front@9front.org Precedence: bulk --0000000000008baf5e060138a6e3 Content-Type: text/plain; charset="UTF-8" 2023-07-24 5:35 GMT+03:00, ori@eigenstate.org : > Quoth kemal : >> >> my mail didn't end up in /n/lists/9front, so the mail server may have >> ate my mail. i'm going to reply to my original message and upload >> my patch to okturing instead of attaching it, hoping that it will get >> sent >> http://okturing.com/src/16441/body > > this breaks wireless on my t460s (Intel Wireless 8260, 8086:24f3). > > Before, it would often give me firmware crashes, but with this it > does it on every bind: > > #l1: fatal firmware error > lastcmd: 108 (0x6c) > error: id 2b12, trm_hw_status 000002f0 00000000, > branchlink2 0002395c, interruptlink 0003867a 00000000, > errordata 80087cca 7acdf1f6 00000000 > #l1: flushq: broken > > happy to help debug, but not sure where to start. > > first of all, thank you for testing! as for what happens here, it errors on the command i changed. firmware makes the situation worse by sending us an unknown error id (0x2b12), but i at least know that it's not because we're sending a bad command but because firmware breaks for a cryptic reason. just for reference, i'll leave the error id table from openbsd here: static struct { const char *name; uint8_t num; } advanced_lookup[] = { { "NMI_INTERRUPT_WDG", 0x34 }, { "SYSASSERT", 0x35 }, { "UCODE_VERSION_MISMATCH", 0x37 }, { "BAD_COMMAND", 0x38 }, { "BAD_COMMAND", 0x39 }, { "NMI_INTERRUPT_DATA_ACTION_PT", 0x3C }, { "FATAL_ERROR", 0x3D }, { "NMI_TRM_HW_ERR", 0x46 }, { "NMI_INTERRUPT_TRM", 0x4C }, { "NMI_INTERRUPT_BREAK_POINT", 0x54 }, { "NMI_INTERRUPT_WDG_RXF_FULL", 0x5C }, { "NMI_INTERRUPT_WDG_NO_RBD_RXF_FULL", 0x64 }, { "NMI_INTERRUPT_HOST", 0x66 }, { "NMI_INTERRUPT_LMAC_FATAL", 0x70 }, { "NMI_INTERRUPT_UMAC_FATAL", 0x71 }, { "NMI_INTERRUPT_OTHER_LMAC_FATAL", 0x73 }, { "NMI_INTERRUPT_ACTION_PT", 0x7C }, { "NMI_INTERRUPT_UNKNOWN", 0x84 }, { "NMI_INTERRUPT_INST_ACTION_PT", 0x86 }, { "ADVANCED_SYSASSERT", 0 }, }; (unknown errors are ADVANCED_SYSASSERT) sadly, the rest of the error is useless as no one except intel knows the firmwares internals. i want to know why it fails, so i added some debug prints to deduce something. diff with debug prints attached. for reference, this is what openbsd does: int iwm_send_phy_db_cmd(struct iwm_softc *sc, uint16_t type, uint16_t length, void *data) { struct iwm_phy_db_cmd phy_db_cmd; struct iwm_host_cmd cmd = { .id = IWM_PHY_DB_CMD, .flags = IWM_CMD_ASYNC, }; phy_db_cmd.type = le16toh(type); phy_db_cmd.length = le16toh(length); cmd.data[0] = &phy_db_cmd; cmd.len[0] = sizeof(struct iwm_phy_db_cmd); cmd.data[1] = data; cmd.len[1] = length; return iwm_send_cmd(sc, &cmd); } and this is the structure: struct iwm_phy_db_cmd { uint16_t type; uint16_t length; uint8_t data[]; } __packed; (data is unused) --0000000000008baf5e060138a6e3 Content-Type: text/plain; charset="US-ASCII"; name="etheriwl.diff" Content-Disposition: attachment; filename="etheriwl.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: file0 ZGlmZiBmNmFjMTgyZjg2YmYwYmNjNzc3YTc2ZGI1MGY5NDIyN2VmNmY3OTYyIHVuY29tbWl0dGVk Ci0tLSBhL3N5cy9zcmMvOS9wb3J0L2V0aGVyaXdsLmMKKysrIGIvc3lzL3NyYy85L3BvcnQvZXRo ZXJpd2wuYwpAQCAtMzMwLDI1ICszMzAsMTQgQEAKIH07CiAKIC8qCi0gKiB1Q29kZSBUTFYgYXBp Ci0gKi8KLWVudW0gewotCS8qIGFwaVswXSAqLwotCVVjb2RlQXBpU3RhCT0gMTw8MzAsCi19Owot Ci0vKgogICogdUNvZGUgY2FwYWJpbGl0aWVzCiAgKi8KIGVudW0gewotCS8qIGNhcGFbMF0gKi8K LQlVY29kZUNhcExhcgk9IDE8PDEsCisJVWNvZGVBcGlTdGEJPSAzMCwKIAotCS8qIGNhcGFbMV0g Ki8KLQlVY29kZUNhcFF1b3RhCT0gMTw8MTIsCi0JCi0JLyogY2FwYVsyXSAqLwotCVVjb2RlQ2Fw TGFyMgk9IDE8PDksCisJVWNvZGVDYXBhTGFyCT0gMSwKKwlVY29kZUNhcGFRdW90YQk9IDQ0LAor CVVjb2RlQ2FwYUxhcjIJPSA3MywKIH07CiAKIGVudW0gewpAQCAtNjU4LDggKzY0Nyw2IEBACiAJ VHlwZTYwMDUJPSAxMSwJLyogYWxzbyBDZW50cmlubyBBZHZhbmNlZC1OIDYwMzAsIDYyMzUgKi8K IAlUeXBlMjAzMAk9IDEyLAogCVR5cGUyMDAwCT0gMTYsCi0KLQlUeXBlNzI2MAk9IDIwLAogfTsK IAogc3RhdGljIHN0cnVjdCByYXRldGFiIHsKQEAgLTcyMSw2ICs3MDgsOCBAQAogCiAjZGVmaW5l IGNzcjMycihjLCByKQkoKigoYyktPm5pYysoKHIpLzQpKSkKICNkZWZpbmUgY3NyMzJ3KGMsIHIs IHYpCSgqKChjKS0+bmljKygocikvNCkpID0gKHYpKQorLyogbWFjcm8gdG8gaGVscCB3aXRoIGN0 bHItPmZ3LT4oYXBpfGNhcGEpICovCisjZGVmaW5lIGlzc2V0KGEsIGkpCSgoYSlbKGkpLzMyXSAm IDFVPDwoaSklMzIpCiAKIHN0YXRpYyB1aW50CiBnZXQxNih1Y2hhciAqcCl7CkBAIC0xMTE0LDcg KzExMDMsOCBAQAogCX0KIAogCS8qIEVuYWJsZSB0aGUgb3NjaWxsYXRvciB0byBjb3VudCB3YWtl IHVwIHRpbWUgZm9yIEwxIGV4aXQuICh3ZWlyZCBXL0EpICovCi0JaWYoY3Rsci0+dHlwZSA9PSBU eXBlNzI2MCl7CisJc3dpdGNoKGN0bHItPnBkZXYtPmRpZCl7CisJY2FzZSAweDA4YjE6IGNhc2Ug MHgwOGIyOiBjYXNlIDB4MDhiMzogY2FzZSAweDA4YjQ6IC8qIFdpcmVsZXNzIDcyNjAvMzE2MCAq LwogCQlpZigoZXJyID0gbmljbG9jayhjdGxyKSkgIT0gbmlsKQogCQkJcmV0dXJuIGVycjsKIApA QCAtMjAxNCw3ICsyMDA0LDcgQEAKIAkqcCsrID0gbWNjWzBdOwogCSpwKysgPSAwOwogCSpwKysg PSAwOwkvLyByZXNlcnZlZAotCWlmKGN0bHItPmZ3LT5jYXBhWzJdICYgVWNvZGVDYXBMYXIyKXsK KwlpZihpc3NldChjdGxyLT5mdy0+Y2FwYSwgVWNvZGVDYXBhTGFyMikpewogCQlwICs9IDQ7CiAJ CXAgKz0gNSo0OwogCX0KQEAgLTI0MDcsNyArMjM5Nyw3IEBACiAJCXAgKz0gMjsJCQkvKiBzbGVl cF90eF9jb3VudCAqLwogCQlwKys7CQkJLyogc2xlZXAgc3RhdGUgZmxhZ3MgKi8KIAotCQkqcCsr ID0gY3Rsci0+ZnctPmFwaVswXSAmIFVjb2RlQXBpU3RhID8gdHlwZSA6IDA7CQkvKiBzdGF0aW9u X3R5cGUgKi8KKwkJKnArKyA9IGlzc2V0KGN0bHItPmZ3LT5hcGksIFVjb2RlQXBpU3RhKSA/IHR5 cGUgOiAwOwkJLyogc3RhdGlvbl90eXBlICovCiAKIAkJcCArPSAyOwkJCS8qIGFzc29jIGlkICov CiAKQEAgLTI0MTYsNyArMjQwNiw3IEBACiAJCXB1dDMyKHAsIDE8PDApOwogCQlwICs9IDQ7CQkJ LyogdGZkX3F1ZXVlX21hc2sgKi8KIAotCQlpZihjdGxyLT5mdy0+YXBpWzBdICYgVWNvZGVBcGlT dGEpeworCQlpZihpc3NldChjdGxyLT5mdy0+YXBpLCBVY29kZUFwaVN0YSkpewogCQkJcCArPSAy OwkJLyogcnhfYmFfd2luZG93ICovCiAJCQlwKys7CQkvKiBzcF9sZW5ndGggKi8KIAkJCXArKzsJ CS8qIHVhcHNkX2FjcyAqLwpAQCAtMjc1MCw3ICsyNzQwLDcgQEAKIAl1Y2hhciBjWzQqKDMqNCld LCAqcDsKIAlpbnQgaTsKIAotCWlmKChjdGxyLT5mdy0+Y2FwYVsxXSAmIFVjb2RlQ2FwUXVvdGEp ID09IDApCisJaWYoIWlzc2V0KGN0bHItPmZ3LT5jYXBhLCBVY29kZUNhcGFRdW90YSkpCiAJCXJl dHVybiBuaWw7CiAKIAlpID0gMDsKQEAgLTI4ODMsNiArMjg3Myw0MSBAQAogfQogCiBzdGF0aWMg Y2hhcioKK3NlbmRjYWxpYmRhdGEoQ3RsciAqY3RscikKK3sKKwlCbG9jayAqYjsKKwl1Y2hhciBj WzRdOworCWNoYXIgKmVycjsKKwlpbnQgaTsKKworCWZvcihpID0gMDsgaSA8IHNpemVvZihjdGxy LT5jYWxpYi5jbWQpOyBpKyspeworCQlpZigoYiA9IGN0bHItPmNhbGliLmNtZFtpXSkgPT0gbmls KXsKKwkJCXByaW50KCJpd2w6IGNhbGliICVkIGVtcHR5IiwgaSk7CisJCQljb250aW51ZTsKKwkJ fQorCQlpZihiID09IGN0bHItPmNhbGliLmNmZykKKwkJCXB1dDE2KGMsIDEpOworCQllbHNlIGlm KGIgPT0gY3Rsci0+Y2FsaWIubmNoKQorCQkJcHV0MTYoYywgMik7CisJCWVsc2UgaWYoY3Rsci0+ Y2FsaWIuY21kK2kgPCBjdGxyLT5jYWxpYi5wYXBkK25lbGVtKGN0bHItPmNhbGliLnBhcGQpKQor CQkJcHV0MTYoYywgNCk7CisJCWVsc2UgaWYoY3Rsci0+Y2FsaWIuY21kK2kgPCBjdGxyLT5jYWxp Yi50eHArbmVsZW0oY3Rsci0+Y2FsaWIudHhwKSkKKwkJCXB1dDE2KGMsIDUpOworCQlwdXQxNihj KzIsIEJMRU4oYikpOworCQlwcmludCgiaXdsOiBjYWxpYiAlZCB0byBiZSBzZW50OiB0eXBlICV1 aGQgbGVuICV1aGQiLCBpLCBnZXQxNihjKSwgZ2V0MTYoYysyKSk7CisJCQorCQliID0gY29weWJs b2NrKGIsIEJMRU4oYikpOworCQlpZigoZXJyID0gcWNtZChjdGxyLCA0LCAxMDgsIGMsIHNpemVv ZihjKSwgYikpICE9IG5pbCl7CisJCQlmcmVlYihiKTsKKwkJCXJldHVybiBlcnI7CisJCX0KKwkJ aWYoKGVyciA9IGZsdXNocShjdGxyLCA0KSkgIT0gbmlsKQorCQkJcmV0dXJuIGVycjsKKwl9CisJ cmV0dXJuIG5pbDsKK30KKworc3RhdGljIGNoYXIqCiBwb3N0Ym9vdDcwMDAoQ3RsciAqY3RscikK IHsKIAljaGFyICplcnI7CkBAIC0yOTE0LDIxICsyOTM5LDkgQEAKIAkJCWN0bHItPmNhbGliLmRv bmUgPSAxOwogCQl9CiAJfSBlbHNlIHsKLQkJQmxvY2sgKmI7Ci0JCWludCBpOworCQlpZigoZXJy ID0gc2VuZGNhbGliZGF0YShjdGxyKSkgIT0gbmlsKQorCQkJcmV0dXJuIGVycjsKIAotCQlmb3Io aSA9IDA7IGkgPCBuZWxlbShjdGxyLT5jYWxpYi5jbWQpOyBpKyspewotCQkJaWYoKGIgPSBjdGxy LT5jYWxpYi5jbWRbaV0pID09IG5pbCkKLQkJCQljb250aW51ZTsKLQkJCWIgPSBjb3B5YmxvY2so YiwgQkxFTihiKSk7Ci0JCQlpZigocWNtZChjdGxyLCA0LCAxMDgsIG5pbCwgMCwgYikpICE9IG5p bCl7Ci0JCQkJZnJlZWIoYik7Ci0JCQkJcmV0dXJuIGVycjsKLQkJCX0KLQkJCWlmKChlcnIgPSBm bHVzaHEoY3RsciwgNCkpICE9IG5pbCkKLQkJCQlyZXR1cm4gZXJyOwotCQl9Ci0KIAkJaWYoKGVy ciA9IHNlbmRwaHljb25maWcoY3RsciwKIAkJCWN0bHItPmZ3LT5waHlza3UsCiAJCQljdGxyLT5m dy0+bWFpbi5kZWZjYWxpYi5mbG93bWFzaywKQEAgLTI5NDcsNyArMjk2MCw3IEBACiAJCQlwcmlu dCgiY2FuJ3QgdXBkYXRlIGRldmljZSBwb3dlcjogJXNcbiIsIGVycik7CiAJCQlyZXR1cm4gZXJy OwogCQl9Ci0JCWlmKGN0bHItPmZ3LT5jYXBhWzBdICYgVWNvZGVDYXBMYXIpCisJCWlmKCFpc3Nl dChjdGxyLT5mdy0+Y2FwYSwgVWNvZGVDYXBhTGFyKSkKIAkJCWlmKChlcnIgPSBzZW5kbWNjdXBk YXRlKGN0bHIsICJaWiIpKSAhPSBuaWwpCiAJCQkJcmV0dXJuIGVycjsKIAkJaWYoKGVyciA9IGRp c2FibGViZWFjb25maWx0ZXIoY3RscikpICE9IG5pbCl7CkBAIC00NDIxLDcgKzQ0MzQsNyBAQAog CWludCBmYW1pbHk7CiAJCiAJcGRldiA9IG5pbDsKLQl3aGlsZShwZGV2ID0gcGNpbWF0Y2gocGRl diwgVmludGVsLCAwKSkgeworCXdoaWxlKHBkZXYgPSBwY2ltYXRjaChwZGV2LCAweDgwODYsIDAp KSB7CiAJCUN0bHIgKmN0bHI7CiAJCXZvaWQgKm1lbTsKIAkJCkBAIC00NDY3LDYgKzQ0ODAsNyBA QAogCQkJZnduYW1lID0gIml3bS03MjYwLTE3IjsKIAkJCWJyZWFrOwogCQljYXNlIDB4MDhiMzoJ LyogV2lyZWxlc3MgQUMgMzE2MCAqLworCQljYXNlIDB4MDhiNDoJLyogV2lyZWxlc3MgQUMgMzE2 MCAqLwogCQkJZmFtaWx5ID0gNzAwMDsKIAkJCWZ3bmFtZSA9ICJpd20tMzE2MC0xNyI7CiAJCQli cmVhazsKQEAgLTQ0NzQsNiArNDQ4OCwxNSBAQAogCQljYXNlIDB4MDk1YjoJLyogV2lyZWxlc3Mg QUMgNzI2NSAqLwogCQkJZmFtaWx5ID0gNzAwMDsKIAkJCWZ3bmFtZSA9ICJpd20tNzI2NS0xNyI7 CisJCQlicmVhazsKKwkJY2FzZSAweDMxNjU6CS8qIFdpcmVsZXNzIEFDIDMxNjUgKi8KKwkJY2Fz ZSAweDMxNjY6CS8qIFdpcmVsZXNzIEFDIDMxNjUgKi8KKwkJCWZhbWlseSA9IDcwMDA7CisJCQlm d25hbWUgPSAiaXdtLTcyNjVELTI5IjsKKwkJCWJyZWFrOworCQljYXNlIDB4MjRmYjoJLyogV2ly ZWxlc3MgQUMgMzE2OCAqLworCQkJZmFtaWx5ID0gNzAwMDsKKwkJCWZ3bmFtZSA9ICJpd20tMzE2 OC0yOSI7CiAJCQlicmVhazsKIAkJY2FzZSAweDI0ZjM6CS8qIFdpcmVsZXNzIEFDIDgyNjAgKi8K IAkJCWZhbWlseSA9IDgwMDA7Cg== --0000000000008baf5e060138a6e3--