Re: [9front] [Patch] Mail fails to send attachments

[hiro <23hiro@gmail.com>]

gmail still displays your mails weirdly, might be unrelated but not sure:

In-Reply-To: <E07C376E4275255C9E2473CC13E5C94B@eigenstate.org>
MIME-Version: 1.0
Content-Type: multipart/mixed;
boundary="upas-kbnxydoadswlscajpsgakobprj" <<< this seems to be
ignored by my gmail that displays the message. is it too early?
shouldn't it be the last line in the headers?
List-ID: <9front.9front.org> <<< obviously this got added by 9front
mailing list... might be a harmful interaction with your header... ?
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: encrypted interface-aware base high-performance frontend
Subject: Re: [9front] [Patch] Mail fails to send attachments
Reply-To: 9front@9front.org
Precedence: bulk
<< this empty line marks the beginning of the message...
This is a multi-part message in MIME format. << ...which is why gmail
displays this
--upas-kbnxydoadswlscajpsgakobprj <<<and ignores this, displaying this
and the rest of the body as plain text including those headers.
Content-Disposition: inline
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit


On 2/20/21, sirjofri <sirjofri+ml-9front@sirjofri.de> wrote:
> This is a multi-part message in MIME format.
> --upas-kbnxydoadswlscajpsgakobprj
> Content-Disposition: inline
> Content-Type: text/plain; charset="US-ASCII"
> Content-Transfer-Encoding: 7bit
>
> Save outgoing files in user mailbox, fixes closed pipe bug
>
> I noticed it is no closed pipe, but the constructed foldername for the
> save location was built using the upasname variable, which can be set
> to an alias.
>
> This patch fixes that and uses the logged in username instead.
> Therefore it opens the file correctly and the write works.
>
> For example, before:
>
> 	upasname: joel@sirjofri.de
> 	foldername: /mail/box/joel@sirjofri.de/outgoing
>
> after:
>
> 	upasname: joel@sirjofri.de
> 	foldername: /mail/box/sirjofri/outgoing
>
> If an attachment is here, then the patch works (on my machine, at
> least).
>
> We should still check the returned file descriptor, just in case the
> user has no mailbox directory.
>
> sirjofri
>
> .
> --upas-kbnxydoadswlscajpsgakobprj
> Content-Disposition: inline
> Content-Type: text/plain; charset="US-ASCII"
> Content-Transfer-Encoding: 7bit
>
> diff -r 297026d9dc30 sys/src/cmd/upas/marshal/marshal.c
> --- a/sys/src/cmd/upas/marshal/marshal.c	Thu Feb 18 21:40:30 2021 +0100
> +++ b/sys/src/cmd/upas/marshal/marshal.c	Sat Feb 20 14:09:26 2021 +0100
> @@ -1086,7 +1086,7 @@
>  			case 0:
>  				close(pfd[0]);
>  				/* BOTCH; "From " time gets changed */
> -				b = openfolder(foldername(nil, user, rcvr), time(0));
> +				b = openfolder(foldername(nil, login, rcvr), time(0));
>  				fd = b? Bfildes(b): -1;
>  				printunixfrom(fd);
>  				tee(0, pfd[1], fd);
> --upas-kbnxydoadswlscajpsgakobprj--
>