From: hiro <23hiro@gmail.com>
To: 9front@9front.org
Subject: Re: [9front] libdraw: remove drawsetdebug() ?
Date: Fri, 1 Jan 2021 19:29:38 +0100 [thread overview]
Message-ID: <CAFSF3XONSN11=3ZDzixiD0B=SF557HRWXaq9+Bi0j=kqCiyaKg@mail.gmail.com> (raw)
In-Reply-To: <BEDCD4D29A86F0F4909B021630DE7514@gmail.com>
well, in devdraw it does exactly one thing: it doesn't error, and
successfully allows devdraw to continue with the next RPC.
we can not remove it from devdraw.
i don't know what is in libdraw, but i guess one could notice in it's
man page that for this to be of any use to anybody they would have to
run their own modified devdraw that actually handles this case in a
dedicated logging procedure...
On 1/1/21, telephil9@gmail.com <telephil9@gmail.com> wrote:
> Hi,
>
> drawsetdebug() is now a no-op on devdraw side. It seems (I let hiro confirm)
> that it still works with vncs though.
> Two options:
> 1) It is a no-op everywhere and we should remove it from libdraw
> 2) It is still of use somewhere but then draw(2) should reflect the fact
> that it does nothing
>
> I can provide a patch for either scenario.
>
> --phil
>
prev parent reply other threads:[~2021-01-01 18:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-01 18:07 telephil9
2021-01-01 18:29 ` hiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFSF3XONSN11=3ZDzixiD0B=SF557HRWXaq9+Bi0j=kqCiyaKg@mail.gmail.com' \
--to=23hiro@gmail.com \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).