From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE autolearn=ham
	autolearn_force=no version=3.4.4
Received: (qmail 3099 invoked from network); 1 Jan 2021 18:32:20 -0000
Received: from ewsd.inri.net (107.191.116.128)
  by inbox.vuxu.org with ESMTPUTF8; 1 Jan 2021 18:32:20 -0000
Received: from mail-ej1-f48.google.com ([209.85.218.48]) by ewsd; Fri Jan  1 13:29:47 -0500 2021
Received: by mail-ej1-f48.google.com with SMTP id g20so28673852ejb.1
        for <9front@9front.org>; Fri, 01 Jan 2021 10:29:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to;
        bh=tcYg3V9InOdDdz1hHmS0Q//BuFumnyicgoOymzpVpzE=;
        b=VYtOBBlRxHSK/jMQQPSlYLEf2xcZ+HjtLFYWedQsj8Lx5dhyN9LoU1eTb73h/9ffYo
         FS5ti+GRZApRWpLUU3wm/bUdvTPhffarM2AaD38qEqW52kkstyeieIwa878CRCUraF12
         Kjm4zA4i6aa8U3Mo/7yV0a+9FudBSjaGNo3poK/hsCxDAMctEcDZMbrGYdtoYIh+mnRw
         snli07XFLGmEa4MWEAq8+Ot/iuwtNATcGRt1JStrL5+j++prhoCODKSWqc/rVOeUapJJ
         IRpodWbQxDDyXTpwIt6+bmLK2slBGtbAFSt4lsceXtEyjJyY/0m9WrzKZQUlOkr30j+8
         0WbA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:in-reply-to:references:from:date
         :message-id:subject:to;
        bh=tcYg3V9InOdDdz1hHmS0Q//BuFumnyicgoOymzpVpzE=;
        b=l1WBvKO9wNY+sCvkLMcrfrMYpGzCk+hsTW+EDPTvoiCbpJ0ridSNPu2hqmB78KXPNB
         8G3QaPWNrYZu92OmbueWgp5d43A61aam6rRExuJhdpGpmGX5VWLiZOLEDDvhetqeXeRP
         SlW2viQU1WDMvYnn0aKUe97XcuECGSPhdrN3wCEwjkIobffRb6U6cc37lR80N7z1d9Ff
         O3D96yfRzS/pt3IZ5GOYSljxS2O8qp0jfMeJZYwNVC6oDos8JZPvL2S4cNmk3YRdL+SX
         zl5dVDsnNRYxXmUzy+SDAYHTKc71n+KV3A5KwHMlvdCTTH6t/I/1ClzJDGN1koZNnFLm
         cb2Q==
X-Gm-Message-State: AOAM533UdRXwMMqizdcD+gXBcUiGdHlp9ffAocqUqDsNlhG/Y090rCVn
	hcboJZLWMQX6TY78DmV8B3UQheU6TBPjNfDemwjFU9PAp7o=
X-Google-Smtp-Source: ABdhPJyUAvlXK0DYq7IOuKPOdlj6EujAzY0kn4Mm8s38G13hoaUzaB+jmFCvbGJSXYakJTK14CK0pDy4J7bNoZ2Nzcw=
X-Received: by 2002:a17:906:259a:: with SMTP id m26mr58949789ejb.399.1609525778452;
 Fri, 01 Jan 2021 10:29:38 -0800 (PST)
MIME-Version: 1.0
Received: by 2002:a17:906:6848:0:0:0:0 with HTTP; Fri, 1 Jan 2021 10:29:38
 -0800 (PST)
In-Reply-To: <BEDCD4D29A86F0F4909B021630DE7514@gmail.com>
References: <BEDCD4D29A86F0F4909B021630DE7514@gmail.com>
From: hiro <23hiro@gmail.com>
Date: Fri, 1 Jan 2021 19:29:38 +0100
Message-ID: <CAFSF3XONSN11=3ZDzixiD0B=SF557HRWXaq9+Bi0j=kqCiyaKg@mail.gmail.com>
To: 9front@9front.org
Content-Type: text/plain; charset="UTF-8"
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: extensible progressive persistence property optimizer 
Subject: Re: [9front] libdraw: remove drawsetdebug() ?
Reply-To: 9front@9front.org
Precedence: bulk

well, in devdraw it does exactly one thing: it doesn't error, and
successfully allows devdraw to continue with the next RPC.
we can not remove it from devdraw.

i don't know what is in libdraw, but i guess one could notice in it's
man page that for this to be of any use to anybody they would have to
run their own modified devdraw that actually handles this case in a
dedicated logging procedure...

On 1/1/21, telephil9@gmail.com <telephil9@gmail.com> wrote:
> Hi,
>
> drawsetdebug() is now a no-op on devdraw side. It seems (I let hiro confirm)
> that it still works with vncs though.
> Two options:
> 1) It is a no-op everywhere and we should remove it from libdraw
> 2) It is still of use somewhere but then draw(2) should reflect the fact
> that it does nothing
>
> I can provide a patch for either scenario.
>
> --phil
>