Re: [9front] [PATCH] g: use xargs instead of finding complete file list before greping

[Michael Forney <mforney@mforney.org>]

On 2022-01-04, igor@9lab.org <igor@9lab.org> wrote:
> xargs also has a parallel mode that comes in handy to speed up search
> in this case.

Is there a possibility that this might result in intermixed grep
results (i.e. one process printing a line in the middle of a another
line)? That'd be my main concern with adding parallelism to xargs.

>  case *
> -	pattern=$1
> -	shift
>  	for(f in $*){
>  		if(test -d $f)
> -			files=($files `$nl{walk -f $recurse -- $* \
> -				| grep -e $fullnames -e $suffixes >[2]/dev/null})
> +			walk -f $recurse -- $f \
> +				| grep -e $fullnames -e $suffixes >[2]/dev/null
>  		if not
> -			files=($files $f)
> +			echo -n $f$nl

If we don't care about ordering of results, we could also skip the
for-loop completely and replace this entire case with

	walk -f -n0 -- $*
	walk -f $recurse -- $* | grep -e $fullnames -e $suffixes >[2]/dev/null

and change the default to recurse='-n1,'. This would walk all named
file arguments first, followed by the files in the directories.