9front - general discussion about 9front
 help / color / mirror / Atom feed
From: Michael Forney <mforney@mforney.org>
To: 9front@9front.org
Subject: Re: [9front] [PATCH] git/fs: remove trailing null bytes from parent file
Date: Thu, 6 Jan 2022 08:49:30 -0800	[thread overview]
Message-ID: <CAGw6cBsvXGjy19PvV3LkvccQDzpEFivtzrBKHWe4SzG1Xp1YTQ@mail.gmail.com> (raw)
In-Reply-To: <6AD9068E4867656B61A79ABDAC44A3CC@eigenstate.org>

On 2022-01-06, ori@eigenstate.org <ori@eigenstate.org> wrote:
> I think this needs to be:
> 	n = o->commit->nparent * (40 + 1) + 1;
> because we need 41 bytes per line *and* room
> for the trailing nul.
> While we're here, let's nuke the sprint, and
> compute the number of bytes we wrote in.

In my patch I had allocated n + 1 bytes for the trailing nul.

But regardless, your patch looks fine as well.

  reply	other threads:[~2022-01-06 16:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-06  8:58 Michael Forney
2022-01-06 16:07 ` ori
2022-01-06 16:49   ` Michael Forney [this message]
2022-01-06 16:55     ` ori
2022-01-06 17:02     ` ori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGw6cBsvXGjy19PvV3LkvccQDzpEFivtzrBKHWe4SzG1Xp1YTQ@mail.gmail.com \
    --to=mforney@mforney.org \
    --cc=9front@9front.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).