From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID
	autolearn=ham autolearn_force=no version=3.4.4
Received: (qmail 1525 invoked from network); 6 Jan 2022 16:57:26 -0000
Received: from 4ess.inri.net (216.126.196.42)
  by inbox.vuxu.org with ESMTPUTF8; 6 Jan 2022 16:57:26 -0000
Received: from mail-yb1-f180.google.com ([209.85.219.180]) by 4ess; Thu Jan  6 11:49:41 -0500 2022
Received: by mail-yb1-f180.google.com with SMTP id w184so9126854ybg.5
        for <9front@9front.org>; Thu, 06 Jan 2022 08:49:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=mforney-org.20210112.gappssmtp.com; s=20210112;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to;
        bh=nar06Cp7hM/7ys3e1paqnEXd7f8L7LB/bTa6SgTCzDI=;
        b=BHW6LvPLKm3ZdfCxFqEh9RWqkpQih/CLQSE34Q+zzAQkuBnAlAQUzkzsQYfTSrs7+E
         96Z1exQqSIRYx6jeQebrGrwIBO1gAyLTooklTnzpmkyxhA6q0Pc4XdNOstILgYOd9esF
         RjQH37f1ZwUAvwjvvsgsR3H3og9Q+XOftMYtPWBSW669PH51Ml0W0jawmzK/TQsH3h3i
         vc02owy1WdgGLu8+YQ/4V2vTFoaTzfS726q/mpXEKMuW+u05ciAxaQtltbbeHT6+y3AP
         EDUkUGK050pd0ULcFMyWJ22UmPpFpLKEcxSg6dFnRxw/xG1oQqT4lGAng9BNqqv4Bci0
         bjLg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:in-reply-to:references:from:date
         :message-id:subject:to;
        bh=nar06Cp7hM/7ys3e1paqnEXd7f8L7LB/bTa6SgTCzDI=;
        b=QRz6EshKG44qp4uujl+wdgdWp7v0iEwQQb5WltOOBWZ3eibyUtgQa+UfY1v69f/kRl
         Sy0DJku8lRdZO/icA7hWGED6B3+qkppu+k5ZFcLYdx8DGLJeXnaltK3sl1hB7nAV1uCL
         naB+MqhU6Yrc14TjkpnevBrtrEWkWFOy3HNLYmBrGSgkalo4h9wjFvGtQyw7GBHP23NJ
         YJDB2Xxt0CkakNL9CTDK5Iv3BgwTo76ReCNxLfpjoXlTNKdJA5YFj7G5zAHQ+kiFnQNF
         LphtfpECOU3c4LSkLJDOv7Pe51wZDHtrZwbxhJ4x98rlwUxku1bh2DUfv4VJl2yYeq9v
         RY1g==
X-Gm-Message-State: AOAM531W19k/0Bip3bFIWJtMgyoYeYsWtMnrDQz/iAuTgzjIBF/WEew/
	mc4HZMU/u2Yn1bshIxuk0Vd5p1wee66cRTGWRJeTa8NrgyjK3g==
X-Google-Smtp-Source: ABdhPJzFvxtakpUZEbL8xX5sWCSx2XZm/OifKNVYNLO5P3ZL0WJ4qTcLV4EorU+KJYzOcd8uKJ5utehtcwANOBcTYUE=
X-Received: by 2002:a25:2342:: with SMTP id j63mr58309523ybj.293.1641487771133;
 Thu, 06 Jan 2022 08:49:31 -0800 (PST)
MIME-Version: 1.0
Received: by 2002:a05:7010:8ea1:b0:1f3:468e:f4dc with HTTP; Thu, 6 Jan 2022
 08:49:30 -0800 (PST)
X-Originating-IP: [98.45.152.168]
In-Reply-To: <6AD9068E4867656B61A79ABDAC44A3CC@eigenstate.org>
References: <20220106085844.1385-1-mforney@mforney.org> <6AD9068E4867656B61A79ABDAC44A3CC@eigenstate.org>
From: Michael Forney <mforney@mforney.org>
Date: Thu, 6 Jan 2022 08:49:30 -0800
Message-ID: <CAGw6cBsvXGjy19PvV3LkvccQDzpEFivtzrBKHWe4SzG1Xp1YTQ@mail.gmail.com>
To: 9front@9front.org
Content-Type: text/plain; charset="UTF-8"
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: RESTful converged standard package 
Subject: Re: [9front] [PATCH] git/fs: remove trailing null bytes from parent file
Reply-To: 9front@9front.org
Precedence: bulk

On 2022-01-06, ori@eigenstate.org <ori@eigenstate.org> wrote:
> I think this needs to be:
>
> 	n = o->commit->nparent * (40 + 1) + 1;
>
> because we need 41 bytes per line *and* room
> for the trailing nul.
>
> While we're here, let's nuke the sprint, and
> compute the number of bytes we wrote in.

In my patch I had allocated n + 1 bytes for the trailing nul.

But regardless, your patch looks fine as well.