From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 13191 invoked from network); 2 Mar 2022 21:39:46 -0000 Received: from 4ess.inri.net (216.126.196.42) by inbox.vuxu.org with ESMTPUTF8; 2 Mar 2022 21:39:46 -0000 Received: from mail-ej1-f50.google.com ([209.85.218.50]) by 4ess; Wed Mar 2 16:33:04 -0500 2022 Received: by mail-ej1-f50.google.com with SMTP id bg10so6544840ejb.4 for <9front@9front.org>; Wed, 02 Mar 2022 13:33:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mforney.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=VBjTzlADZRZ2SgKXzvsvMC0UHFMPZLvn9G+dt+5C4gk=; b=xYWae+jHop1kg7ORL7G1Z8h9Ph0WJRLnBW+a/StAPoOS2+znKdcXmloJW7oRtYqdUk 44sDfa6hgTGeIDpYuWXZiF5x9b2zr792OaDbJRd7PfEG+LgYfmCqnoFK6ylHjo1neKxu XeTDNek+tkSZjEx6Q1VwzC+3IgXQr9WUAZFC97Z+G2Q8RXbiYeEkakRlfO7tNh55DTm6 wm0AWfky2AEfEo5JUy+0EPwisgagbC9ONzM17jnC2e+pFBAYLFEZ4sPyoTXMLtOIk3c+ EryQ1pDix3wpgxjGBEvt0Yj0c6gs12BvziOS3D+mDcmE9N0LrllL9nl+eNv6id2UVBEx e2kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=VBjTzlADZRZ2SgKXzvsvMC0UHFMPZLvn9G+dt+5C4gk=; b=ImbIkRhz1njK9mIiOLdzg+ye/K+2kN/A/0dzU7inG5Kh+uZrS9ZKBkaZBfVV/jDGxl mdxe44Aswbo3lPgIxZ/x5N2q0pxa3UCQKAWOUeCUrbwCnnWrukwAq5PWuw3aHX88zvLg t4YTR6NS7HQJ4t9KD931ZQpVq32Maz1a659wqwxx4SYQdLBkT6YB6Y2gYn95ChDMcFFc 4NeOeKgll8ECNNlZ5KahKz+z9B6lK2DZJwT8QkBVBnRLEAONiaXD0Gi6WSE/LG685lId bRMBK+ZYYba7+uVXtz8hadk1PGHvGv2c/pHP4nXRfs4rDN6cqHvku/GBoOIGw4fTtB5M mUCQ== X-Gm-Message-State: AOAM531EyDHTFGv2wr8HBl58OXzG7mxN9VjSbiWhUmXVnZHiQve0RwVF GLElZePgLR+0hWBL8cB6YX69Vq8/s+nzNfTAACOY64UmJumvVA== X-Google-Smtp-Source: ABdhPJwkYVtVB55HHdlu7WV21i52EfbH1zHDS+2ZUf3YEVXRe9Pm+4akVjiNBS0tasvoGmyfB9VghdBSR5JlQwfHYF4= X-Received: by 2002:a17:907:7f8b:b0:6da:6eeb:72e4 with SMTP id qk11-20020a1709077f8b00b006da6eeb72e4mr2876480ejc.311.1646255202665; Wed, 02 Mar 2022 13:06:42 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a17:906:6782:b0:6d0:9087:adfd with HTTP; Wed, 2 Mar 2022 13:06:40 -0800 (PST) X-Originating-IP: [98.45.152.168] In-Reply-To: <7AEFE9FB827E6798723FEAD905091F7F@felloff.net> References: <64CCB492DFAE4EAEDF46CAF83BB8A752@eigenstate.org> <7AEFE9FB827E6798723FEAD905091F7F@felloff.net> From: Michael Forney Date: Wed, 2 Mar 2022 13:06:40 -0800 Message-ID: To: 9front@9front.org Content-Type: text/plain; charset="UTF-8" List-ID: <9front.9front.org> List-Help: X-Glyph: ➈ X-Bullshit: content-addressed interface framework strategy Subject: Re: [9front] Re: [PATCH] nusb/serial: fix pl2303 usbcmd error checks Reply-To: 9front@9front.org Precedence: bulk On 2022-03-02, cinap_lenrek@felloff.net wrote: > still seems to work fine with the latest patch. > > attach 8 1a86 7523 0000ff 55b22 Those device IDs match ch340.c, not prolific.c. The prolific one was bugged since the referenced commit: http://git.9front.org/plan9front/plan9front/e0087b2a78d7229d8d2b148b8def688be6639797/commit.html In prolific.c, vendorwrite and plsetparam call usbcmd with Rh2d and some ndata (0 or ParamReqSz), and then errors out when the result is not 8+ndata. That previous commit made usbcmd with Rh2d return ndata, not 8+ndata, so it is now failing. Here are the error messages I was getting: term% nusb/serial 7 serial: vendorwrite failed with res=0 serial: vendorwrite failed with res=0 serial: vendorwrite failed with res=0 serial: vendorwrite failed with res=0 serial: vendorwrite failed with res=0 term% echo 'b 19200' >/dev/eiaU7ctl serial: vendorwrite failed with res=0 serial: vendorwrite failed with res=0 serial: plsetparam failed with res=7 echo: write error: bad control request