9front - general discussion about 9front
 help / color / mirror / Atom feed
From: Giacomo Tesio <giacomo@tesio.it>
To: 9front@9front.org
Subject: Re: [9front] out of bound access in libsec
Date: Tue, 17 Jan 2017 23:50:01 +0100	[thread overview]
Message-ID: <CAHL7psE4gg6F-T+vQ+JK6Vt+mE+_oUUFR83HUsNbmM0jJ-90Gw@mail.gmail.com> (raw)
In-Reply-To: <0f72c8d86c729b6da085be697a7c56e3@felloff.net>

[-- Attachment #1: Type: text/plain, Size: 438 bytes --]

For 1) aesXCBCmac is an exported function thus it could get a broken
AESstate from the caller.
For 2) you are right... thanks!


Giacomo

2017-01-17 22:36 GMT+01:00 <cinap_lenrek@felloff.net>:

> on 1), the comment says right here that it does not deal with keys
> bigger than 128 bits. which is implied by s->keybytes == 16. so rounds
> is 10 here as of aes_setupEnc(). given 4*(10+1) == 48, so the buffer
> size holds.
>
> --
> cinap
>

[-- Attachment #2: Type: text/html, Size: 799 bytes --]

  parent reply	other threads:[~2017-01-17 22:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-17 20:59 Giacomo Tesio
2017-01-17 21:27 ` [9front] " cinap_lenrek
2017-01-17 21:36   ` cinap_lenrek
2017-01-17 21:51     ` cinap_lenrek
2017-01-17 22:50     ` Giacomo Tesio [this message]
2017-01-17 22:55       ` cinap_lenrek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHL7psE4gg6F-T+vQ+JK6Vt+mE+_oUUFR83HUsNbmM0jJ-90Gw@mail.gmail.com \
    --to=giacomo@tesio.it \
    --cc=9front@9front.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).