From: Giacomo Tesio <giacomo@tesio.it>
To: Fans of the OS Plan 9 from Bell Labs <9fans@9fans.net>,
9front@9front.org
Subject: out of bound access in libsec
Date: Tue, 17 Jan 2017 21:59:17 +0100 [thread overview]
Message-ID: <CAHL7psHxJp6wBDpRFr7a48EVsNtT7rFQ=4eLuZ7AdpuMNpRBnQ@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 539 bytes --]
Hi, running coverity scan on libsec it reported two defects that do not
seem false positives:
1. an out of bound access to aesXCBCmac (see
https://github.com/JehanneOS/jehanne/issues/3 )
2. an out of bound access in msgRecv, tlshand.c:1809 (see
https://github.com/JehanneOS/jehanne/issues/4 )
I verified that the code is more or less the same on 9front.
I "fixed" the first with an assert, but I'm not sure wherther passing
sizeof(m->u.finished.verify) to memset in the second is the correct
solution.
Am I missing something?
Giacomo
[-- Attachment #2: Type: text/html, Size: 940 bytes --]
next reply other threads:[~2017-01-17 20:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 20:59 Giacomo Tesio [this message]
2017-01-17 21:27 ` [9front] " cinap_lenrek
2017-01-17 21:36 ` cinap_lenrek
2017-01-17 21:51 ` cinap_lenrek
2017-01-17 22:50 ` Giacomo Tesio
2017-01-17 22:55 ` cinap_lenrek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHL7psHxJp6wBDpRFr7a48EVsNtT7rFQ=4eLuZ7AdpuMNpRBnQ@mail.gmail.com' \
--to=giacomo@tesio.it \
--cc=9fans@9fans.net \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).