From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wm1-f52.google.com ([209.85.128.52]) by ewsd; Fri Oct 12 06:12:06 EDT 2018
Received: by mail-wm1-f52.google.com with SMTP id e187-v6so12420801wmf.0
        for <9front@9front.org>; Fri, 12 Oct 2018 03:12:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=offblast-org.20150623.gappssmtp.com; s=20150623;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to;
        bh=g5lWm8l4vkDx8/v5hLxpe4Gt+aEUWo5zORucUW7XJEE=;
        b=YajSJjmqOIvREnn5id5zo49rukoMraOt6dqM+z/Uo6DEkPzCCRM8VUfSRJk8C5ETpU
         z6vRpEh1Bv1MOHKmqbAT2JbpZNYKBj/sEUxQ6yUPM+anPoBs4I0pJFczL7A+8W6rtUBk
         AcnVuRtsEEDZQON/amsCBM+PipJ6z+nS2842I6PXgH6TdEEG5FaENrVEntWYGYVm19xE
         sZ7QIwzSyFJJ5Zp49+YI82iRwTKdZ9nKi4kGrZSHQ38fVD+2Pewcfc3KUrsnGEW0izPL
         aNxPK19W4e2DfJQC05MKRnH9B+E1QzOaABfIUCuHq9iuL2W3/0NmEZBckKzyhPgaRt5t
         F/yQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to;
        bh=g5lWm8l4vkDx8/v5hLxpe4Gt+aEUWo5zORucUW7XJEE=;
        b=TpmW+ubqmaDUefb5oOkwPsNcarQ5jW1d15c1Fa06ul7IzMKn6UMtVAwpjMQ4qiFt+f
         WdE8XZ0W/ARQSjyj7jgqo5MSoA1ACVz62HeJYEN5OMRRKZarLFQPLWWYGDgX1sdepzOn
         qTqvEdMT5U6o4pXyVCc2CUnc1pJANmNqCs7lOjXzFrHzJOu9FDUmCkLUmhyGGMDdX7BB
         2TIOUBKFDcypj75ijPBwcpBX6h4MRtCTUYMmJHqSSp0D5sIRB9aSZ23NbH89PWEj9tUs
         royxwHBTRTsQhRAnsWyLk7oW78t7wE5375x1IvCYxdCJO6eFYudD6MzG6H3WvrJTarHg
         qsvw==
X-Gm-Message-State: ABuFfohsq9jlaJYrMY39zt6cP/fVW1414r0ZwaaVEUbECc7h4n+TJPAj
	IUuOAsudBtUrcC1pfCPlF8GUwMvzcSVFVltl/CA1WIW1AUKc0Q==
X-Google-Smtp-Source: ACcGV61VD7133Hz/tziknAKWmolW9jncUrbN7WRi2DLQN7BFr3POF73/zMj8UehhJHwyA77iT4t7rxnvZXEUr1MxdRk=
X-Received: by 2002:a1c:a851:: with SMTP id r78-v6mr4588600wme.97.1539339122784;
 Fri, 12 Oct 2018 03:12:02 -0700 (PDT)
MIME-Version: 1.0
References: <CAH_zEu4vPwyeeEer+XDHsOtpCTA6LiEbnjymnUiQqL0wjzbuog@mail.gmail.com>
In-Reply-To: <CAH_zEu4vPwyeeEer+XDHsOtpCTA6LiEbnjymnUiQqL0wjzbuog@mail.gmail.com>
From: Nick Owens <mischief@offblast.org>
Date: Fri, 12 Oct 2018 03:11:51 -0700
Message-ID: <CAH_zEu4HX1_Hm2GFnBDwbuNXntjc80eJeDhOdQB3SvTeSNwwUg@mail.gmail.com>
Subject: Re: bug: disk/mkfs crashes in libdisk when given a directory as a protofile
To: 9front@9front.org
Content-Type: multipart/mixed; boundary="0000000000009a76280578055165"
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: managed RESTful HTML extension DOM database 

--0000000000009a76280578055165
Content-Type: text/plain; charset="UTF-8"

this bug was introduced in revision c7027d120f0c. attached is a diff
which prevents this crash in libdisk. any thoughts?
On Tue, Sep 18, 2018 at 8:42 PM Nick Owens <mischief@offblast.org> wrote:
>
> the following command will crash:
>
> disk/mkfs -a -o .
>
> with a null pointer dereference in libdisk, in the proto file parser.
>
> obviously it is wrong to pass a directory as a protofile to mkfs, but
> it was an accident on my part.

--0000000000009a76280578055165
Content-Type: text/x-patch; charset="US-ASCII"; name="libdisk.patch"
Content-Disposition: attachment; filename="libdisk.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_jn5uoayc0>
X-Attachment-Id: f_jn5uoayc0

ZGlmZiAtLWdpdCBhL3N5cy9zcmMvbGliZGlzay9wcm90by5jIGIvc3lzL3NyYy9saWJkaXNrL3By
b3RvLmMKLS0tIGEvc3lzL3NyYy9saWJkaXNrL3Byb3RvLmMKKysrIGIvc3lzL3NyYy9saWJkaXNr
L3Byb3RvLmMKQEAgLTUzNyw3ICs1MzcsMTAgQEAgbG9vcDoKIAkJZ290byBsb29wOwogCXAtLTsK
IAlwb3BvcHQobWthdXgpOwotCSpzdHJjaHIocCwgJ1xuJykgPSAwOworCXMgPSBzdHJjaHIocCwg
J1xuJyk7CisJaWYocyA9PSBuaWwpCisJCXJldHVybiBuaWw7CisJKnMgPSAwOwogCWlmKHMgPSBz
dHJjaHIocCwgJz0nKSl7CiAJCSpzKysgPSAwOwogCQlzZXRvcHQobWthdXgsIHAsIHMpOwo=
--0000000000009a76280578055165--