From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM autolearn=no autolearn_force=no version=3.4.4 Received: (qmail 32725 invoked from network); 10 Aug 2021 07:21:58 -0000 Received: from 1ess.inri.net (216.126.196.35) by inbox.vuxu.org with ESMTPUTF8; 10 Aug 2021 07:21:58 -0000 Received: from mail-yb1-f169.google.com ([209.85.219.169]) by 1ess; Mon Aug 9 18:59:46 -0400 2021 Received: by mail-yb1-f169.google.com with SMTP id z5so30836374ybj.2 for <9front@9front.org>; Mon, 09 Aug 2021 15:59:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=dVWfnIG5w0NsPDk8c4jj62U2H+VEA+aCUS9bJOdFPsw=; b=Z9mQXo4F9ddRhN8fB/T782fgvxtKpq1c2JzVa4nch5FSp0xMMBC/g/+RI1JODMpobM T4r/888F1Oh/WgT+Tcy41lzDEc7GicksbXw+j8rsw1x8ec8TN3ge50VL78sjSEdcZ50I +4u5TZgNevR0XskUlaprBjccsSFTqWSj3Nz7b1Go6FU2eWyY8OqMsHAGGWy5C5MLLi/o VWG2Y8w6zyuDMHRnCBDzJIKOdt0gUswmeCVgd0gLNw9pHbvsgom+e+beWEOUsqTojxtw zYVmRCS/LyUatJ3yqvnn3ULAVUWMAoodL55/j+b94BqnMuLYgZnedIrbaAWMGK2Su7YZ sQbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=dVWfnIG5w0NsPDk8c4jj62U2H+VEA+aCUS9bJOdFPsw=; b=pGQ7JyLNeyjyV0QUb842lP+RKcW4i25ERtqeVAJ2HCxPLYEqZ+B/aSL3mYLDNq9qMS tH+/QhSbRc+EZ1cTBj382jkqln/gdf2uV1vQ8CY3XlYZpfjDdZpZOAXRzua5vmMFI2Uz 0sbCf9MeiuKTZCSjboi6Txg6E3XtVTGuioumG8+sc3WN1fnoIrAE4U4/Io7KpECDB8MS nHuNN46kgen3OCkrzU47N8djB3I3PMn71Trm3Tx3WMkW5s2K1B1qT86SgBX+wsAeDLGD uGi7m8monfWXUNtC1uCp9fnMbWpMxCUPMrXtFmbS9jNs7SfOmqNtsvfrJylot8ByN3lX aqCg== X-Gm-Message-State: AOAM531wUx255nEQ/166zDf2gWHtP8y6Ndgyaz1zhHQBNiR7abw0ljuF 1kHK4n8rqaG/ARG1PJPNt+9nfqIpcS0e5ok+YKEEle+v8g0= X-Google-Smtp-Source: ABdhPJy35C64WR7YRwIgJ7liJY8fHqNVkMtevUgQ+Yc+MpIMxYE1oKJPx3I0m4DmGIuWU+YdATyOGDpafftXS0W9JtI= X-Received: by 2002:a25:b682:: with SMTP id s2mr35392317ybj.399.1628549978863; Mon, 09 Aug 2021 15:59:38 -0700 (PDT) MIME-Version: 1.0 From: Silas McCroskey Date: Mon, 9 Aug 2021 15:59:27 -0700 Message-ID: To: 9front@9front.org Content-Type: multipart/mixed; boundary="000000000000fd660105c92856fb" List-ID: <9front.9front.org> List-Help: X-Glyph: ➈ X-Bullshit: social anonymous realtime-based database singleton-aware frontend Subject: [9front] PATCH: click-to-focus in fgui Reply-To: 9front@9front.org Precedence: bulk --000000000000fd660105c92856fb Content-Type: text/plain; charset="UTF-8" fgui uses libcontrol, which defaults to hover-focus. This is both inconsistent with the rest of the system (bar acme) and potentially dangerous in fgui's specific case, due to the secrets involved. The following patch turns the libcontrol knob to switch to click-to-focus. Not sure this merits being merged per se, but it's at least here for anyone else to pick up. Attached as well since gmail will inevitably mangle it. - sam-d --- /mnt/git/object/40fc48cc7bd2bf10bb304e6d1212abcde6c15066/tree/sys/src/cmd/auth/factotum/fgui.c +++ sys/src/cmd/auth/factotum/fgui.c @@ -294,6 +294,7 @@ /* create a new control set for the confirmation */ openkmr(); cs = newcontrolset(screen, kbdc, mousec, resizec); + cs->clicktotype = 1; createtext(cs, "msg"); chanprint(cs->ctl, "msg image paleyellow"); @@ -534,6 +535,7 @@ /* create a new control set for the confirmation */ openkmr(); cs = newcontrolset(screen, kbdc, mousec, resizec); + cs->clicktotype = 1; /* count attributes and allocate entry controls */ entries = 0; --000000000000fd660105c92856fb Content-Type: application/octet-stream; name="fgui-clickfocus.patch" Content-Disposition: attachment; filename="fgui-clickfocus.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ks58kbuh0 LS0tIC9tbnQvZ2l0L29iamVjdC80MGZjNDhjYzdiZDJiZjEwYmIzMDRlNmQxMjEyYWJjZGU2YzE1 MDY2L3RyZWUvc3lzL3NyYy9jbWQvYXV0aC9mYWN0b3R1bS9mZ3VpLmMKKysrIHN5cy9zcmMvY21k L2F1dGgvZmFjdG90dW0vZmd1aS5jCkBAIC0yOTQsNiArMjk0LDcgQEAKIAkvKiBjcmVhdGUgYSBu ZXcgY29udHJvbCBzZXQgZm9yIHRoZSBjb25maXJtYXRpb24gKi8KIAlvcGVua21yKCk7CiAJY3Mg PSBuZXdjb250cm9sc2V0KHNjcmVlbiwga2JkYywgbW91c2VjLCByZXNpemVjKTsKKwljcy0+Y2xp Y2t0b3R5cGUgPSAxOwogCiAJY3JlYXRldGV4dChjcywgIm1zZyIpOwogCWNoYW5wcmludChjcy0+ Y3RsLCAibXNnIGltYWdlIHBhbGV5ZWxsb3ciKTsKQEAgLTUzNCw2ICs1MzUsNyBAQAogCS8qIGNy ZWF0ZSBhIG5ldyBjb250cm9sIHNldCBmb3IgdGhlIGNvbmZpcm1hdGlvbiAqLwogCW9wZW5rbXIo KTsKIAljcyA9IG5ld2NvbnRyb2xzZXQoc2NyZWVuLCBrYmRjLCBtb3VzZWMsIHJlc2l6ZWMpOwor CWNzLT5jbGlja3RvdHlwZSA9IDE7CiAKIAkvKiBjb3VudCBhdHRyaWJ1dGVzIGFuZCBhbGxvY2F0 ZSBlbnRyeSBjb250cm9scyAqLwogCWVudHJpZXMgPSAwOwo= --000000000000fd660105c92856fb--