From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <9front-bounces@9front.inri.net> X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.4 Received: from 9front.inri.net (9front.inri.net [107.161.22.3]) by inbox.vuxu.org (Postfix) with ESMTP id 500CC2F712 for ; Sat, 23 Nov 2024 16:34:45 +0100 (CET) Received: from mail-ej1-f43.google.com ([209.85.218.43]) by 9front; Sat Nov 23 10:33:28 -0500 2024 Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-aa5366d3b47so58927166b.0 for <9front@9front.org>; Sat, 23 Nov 2024 07:33:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732376006; x=1732980806; darn=9front.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=84M7U6ViIjnU1x0XZi8D7FCkz5AXV3B8+9RvlQ9stCs=; b=ChqiANQhcDqg3zx5tPtW501FZsDO/SSrPrluf+HaVUMYowttsNAAZzN4aFANq0WPPl Ly1OMDPtyk61155aVZw8Tv47UUotcc5Uv9VFomUm6o7J2HTATWU8e5/C0VXCVXL4FfvK Gu6/R93BY5T8iPxGK/bzfJhSqk7w6CScxSQ9C5hRxootvCJkahLfrTGTSB9qGoszS2Ah NTxb9sa1Sizq1BGtdG3UI4FS8OJ+OFuYNV81tj0y4BvOxHyIC23qIJqnEg0N55qGF40C QBa/sfuQEzzCs6RtKIMx7cd5n1jcVZ8/50op1t8fnehmMRvY74ZCh3/HeZsv157kdAsM gr4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732376006; x=1732980806; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=84M7U6ViIjnU1x0XZi8D7FCkz5AXV3B8+9RvlQ9stCs=; b=xCoumyjk0ZOsfvoV+j8ImtHekDz8PkIFcAAJ0tPnMZ2TfkVPzbfGL+wztM6Lsd2VHa d5UUXYSsXV6B1cWXEdgWel3Le7KHpjNyNwOYoDyd34pgMQyP2XG55b8CB3T/+BkbBEiW l6HUhnfyF27TWm/JpfBMbpYbpzeWiM/HpvCj65xutLJVFo+WCwzCC+cSMvH/1DAve4r0 oYGujvGhoDBRwUXZFiJFHpRSO0rmIr7yAl4E4+muMSTWJQy/bqqglnpz1o8dH75Pjn+i 6X2HR/pnLOJRbglI/8y8JgTr4jtLQRIUABQ6n1vGiDmNAoPeyZy7knQFSb5ox6klluHh jddQ== X-Gm-Message-State: AOJu0Yx9HxTowpskxX9V+CnF22bt+5ZWyCqV0wfRlCMtMB4bFTmbKDC0 l7M9SMTZmzhbOESdaH7IF6y3Txm20GeQYSvErnnvqAcn/KhQ/jrCa6/nzpSN2ZlgjX1yKha30KB Jrag/cL3qQCrIJm9mtNYgVaumhCTC0kdl X-Gm-Gg: ASbGncvQefLhxAQuXPuJSpl3fr13gLDUZd1WdrqEHhG/By8/MAUsu5UOuefQs8A6+Q2 31hhtgcOkCXwBGaw90vMGsnvkHkAaXIo= X-Google-Smtp-Source: AGHT+IEoJPCmBicwCLJcS8v480Sumwyc7aw1CXT6j3tjbLpDe0JCl4iZ9GMPba3oX/M6lev5KaxfUHmoY7UCgpDvE3g= X-Received: by 2002:a17:906:3cb1:b0:aa5:391e:cadf with SMTP id a640c23a62f3a-aa5391ecd0emr135066566b.42.1732376005802; Sat, 23 Nov 2024 07:33:25 -0800 (PST) MIME-Version: 1.0 From: Alexander Kapshuk Date: Sat, 23 Nov 2024 17:32:54 +0200 Message-ID: To: 9front@9front.org Content-Type: text/plain; charset="UTF-8" List-ID: <9front.9front.org> List-Help: X-Glyph: ➈ X-Bullshit: agile cache metadata GPU framework Subject: [9front] [patch] games/blit: Make 32-bit unsigned complement zero-extended to 64 bits explicit to silence compiler warning Reply-To: 9front@9front.org Precedence: bulk Compilation outputs these warnings: cpu% mk 6c -FTVw blit.c 6c -FTVw cpu.c 6c -FTVw mem.c 6c -FTVw telnet.c warning: cpu.c:244 32-bit unsigned complement zero-extended to 64 bits warning: cpu.c:255 32-bit unsigned complement zero-extended to 64 bits warning: cpu.c:266 32-bit unsigned complement zero-extended to 64 bits 6l -o 6.out blit.6 cpu.6 mem.6 telnet.6 Type cast one of the u32int variables involved in the expression to u64int to make zero-extension explicit and silence compiler warning. diff 0676a1ba51784e2b44ce9100965e4554e13e48b9 uncommitted --- a/sys/src/games/blit/cpu.c +++ b/sys/src/games/blit/cpu.c @@ -241,7 +241,7 @@ rS |= FLAGC; if((v & 0x80) != 0) rS |= FLAGN; - if((~(w ^ u) & (v ^ u) & 0x80) != 0) + if((~((u64int)w ^ u) & (v ^ u) & 0x80) != 0) rS |= FLAGV; if((u8int)v != 0) rS &= ~FLAGZ; @@ -252,7 +252,7 @@ rS |= FLAGC; if((v & 0x8000) != 0) rS |= FLAGN; - if((~(w ^ u) & (v ^ u) & 0x8000) != 0) + if((~((u64int)w ^ u) & (v ^ u) & 0x8000) != 0) rS |= FLAGV; if((u16int)v != 0) rS &= ~FLAGZ; @@ -263,7 +263,7 @@ rS |= FLAGC; if((v & 0x80000000) != 0) rS |= FLAGN; - if((~(w ^ u) & (v ^ u) & 0x80000000) != 0) + if((~((u64int)w ^ u) & (v ^ u) & 0x80000000) != 0) rS |= FLAGV; if((u32int)v != 0) rS &= ~FLAGZ;