From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_ADSP_CUSTOM_MED,
	DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE autolearn=no
	autolearn_force=no version=3.4.4
Received: (qmail 7245 invoked from network); 18 Dec 2020 08:25:36 -0000
Received: from ewsd.inri.net (107.191.116.128)
  by inbox.vuxu.org with ESMTPUTF8; 18 Dec 2020 08:25:36 -0000
Received: from mail-io1-f49.google.com ([209.85.166.49]) by ewsd; Fri Dec 18 03:22:36 -0500 2020
Received: by mail-io1-f49.google.com with SMTP id 81so1251329ioc.13
        for <9front@9front.org>; Fri, 18 Dec 2020 00:22:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=from:content-transfer-encoding:mime-version:subject:message-id:date
         :to;
        bh=WhC9Gz3XGDjfqHrlZI8iQkGZFI5IJmsQ2EJh/RmcA3s=;
        b=gfl9T4qInm/2zpVbIlBa1HMDN4jwCKpGy+XaS7S7zr6DhJgpW1LPm1c4beB9vWkqrC
         6zx7u6wL4JNr2w/4hYZHn2Ru5736WFiDWnthoX+dNTV1PYic1w4M9yK2HBZYs6gPn+FM
         Dk78zmx4fXj/QTfP1Y9zUflZGPUnkHFkf4QwDoODqNK5PdKHmNgYjVkBNTFpTiiL02uv
         AlopAoylZFxg2e9UCSJOS0Q7NFf6Z1MntdkWUulG39aQ8i4wyjQYbXQ7nrduLjz9TXgv
         xsWxA/cXACCnwwbRoENQ/7/Sdg7mq84LLH4N5KB2+RslwAiuTAMfE1iq8bFC9+GDnSNW
         phnQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:from:content-transfer-encoding:mime-version
         :subject:message-id:date:to;
        bh=WhC9Gz3XGDjfqHrlZI8iQkGZFI5IJmsQ2EJh/RmcA3s=;
        b=KdWcO3+A80JVhGdBc2c0kcC5SjgbEYlVpB3xwRBTaAUuEJxp5eQzQXvMMO4oQFd5Yb
         SHYk1mBqYbkHlMVeFlFssxpo+C5hyYHT1iEiAzeKcYlqk0C6U/2qlTOgvKUcDCPuzohq
         Mfv7bjWSmsQSWEgYWiNB8bEPzKR47oMacnVdpKHkAB8z/FJhvD8o9PRtqhhDXEUf5AxW
         JpmbsBEkuF3Xmf3KjjsFfdoBPfSH4NgX+sJv/nrgHOO8ZdeWZKKAtg7DUprgo2gJdFZa
         rfrGAHQviRgt8EPC8SArDNa05CeflU8CwJt6yNcMtFXnUawXSWSiHxeqR8rc4mrI5sed
         AnEA==
X-Gm-Message-State: AOAM532bn5wa9ZcVhUEIug4wIbDomaOY8Kd5q7rlENLgDftq2HrP32d4
	NidMgQydwvJyuuTyG3huRBkFfL4xKes=
X-Google-Smtp-Source: ABdhPJxaD05VQCmj0GPnRG5tAjKWik6WGtIUA6kKdGadxu5DmYZAOwgNU2sG7t9PH061VamI5P29uQ==
X-Received: by 2002:a05:6602:14ca:: with SMTP id b10mr2822103iow.40.1608279747478;
        Fri, 18 Dec 2020 00:22:27 -0800 (PST)
Return-Path: <meta.jxy@gmail.com>
Received: from [10.0.1.7] (c-67-184-39-205.hsd1.il.comcast.net. [67.184.39.205])
        by smtp.gmail.com with ESMTPSA id m19sm5519692ila.81.2020.12.18.00.22.26
        for <9front@9front.org>
        (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
        Fri, 18 Dec 2020 00:22:26 -0800 (PST)
From: Xiao-Yong Jin <meta.jxy@gmail.com>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.40.0.2.32\))
Message-Id: <CEDEBD0B-FC39-43D4-960F-05E348970FE8@gmail.com>
Date: Fri, 18 Dec 2020 02:22:25 -0600
To: 9front@9front.org
X-Mailer: Apple Mail (2.3654.40.0.2.32)
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: non-blocking TOR over XML CMS table-based standard 
Subject: [9front] strndup should use strnlen and memcpy
Reply-To: 9front@9front.org
Precedence: bulk

I just saw the new commit of strndup that uses strlen and memmove.
memmove is unnecessary.
strlen is dangerous.

Here is a reference implementation from musl.

http://git.musl-libc.org/cgit/musl/tree/src/string/strndup.c

#include <stdlib.h>
#include <string.h>

char *strndup(const char *s, size_t n)
{
	size_t l = strnlen(s, n);
	char *d = malloc(l+1);
	if (!d) return NULL;
	memcpy(d, s, l);
	d[l] = 0;
	return d;
}