[9front] [PATCH] cc: take our pickle out of the peephole

[9front] [PATCH] cc: take our pickle out of the peephole

[Anthony Martin]

The -P flag is used to debug the peephole optimizer. The -Z flag is
used to output pickling code for various types. Don't confuse the two.

The pickling code was added in the third edition. It mistakenly reused
the -P flag which was later partially corrected to use the -Z flag in
2004. That change updated lex.c but missed the code in pickle.c.

---
diff 7bf177b3e058925265863979ee50e8dc1822d17a b44281c5cf3db0ca60a22df94bbe99e8bcf9c9e3
--- a/sys/src/cmd/cc/pickle.c	Tue Aug 23 04:38:49 2022
+++ b/sys/src/cmd/cc/pickle.c	Sat Oct 1 15:48:00 2022
@@ -172,9 +172,9 @@
 	int n;
 	char *an;

-	if(!debug['P'])
+	if(!debug['Z'])
 		return;
-	if(debug['P'] > 1) {
+	if(debug['Z'] > 1) {
 		n = 0;
 		for(i=iostack; i; i=i->link)
 			n++;
@@ -221,9 +221,9 @@
 	Type *t;
 	Sym *s1, *s2;

-	if(!debug['P'] || debug['s'])
+	if(!debug['Z'] || debug['s'])
 		return;
-	if(debug['P'] > 1) {
+	if(debug['Z'] > 1) {
 		n = 0;
 		for(i=iostack; i; i=i->link)
 			n++;

Re: [9front] [PATCH] cc: take our pickle out of the peephole

[unobe]

Quoth Anthony Martin <ality@pbrane.org>:
> 
> The -P flag is used to debug the peephole optimizer. The -Z flag is
> used to output pickling code for various types. Don't confuse the two.
> 
> The pickling code was added in the third edition. It mistakenly reused
> the -P flag which was later partially corrected to use the -Z flag in
> 2004. That change updated lex.c but missed the code in pickle.c.
> 
> ...

So this applies to 9legacy, too?  Would it be a nice gesture to
cross-post to 9fans?

Re: [9front] [PATCH] cc: take our pickle out of the peephole

[Anthony Martin]

unobe@cpan.org once said:
> So this applies to 9legacy, too?  Would it be a nice gesture to
> cross-post to 9fans?

Sure. I'll send a note. Though, I think anyone that actually uses
Plan 9 should be subscribed to both lists.

Cheers,
  Anthony

Re: [9front] [PATCH] cc: take our pickle out of the peephole

[Noam Preil]

Meh.

I use 9front as my main system, and I unsubscribed from 9fans months
ago.

That place is a cesspool.

- Noam Preil

- Noam Preil

Re: [9front] [PATCH] cc: take our pickle out of the peephole

[Steve Simon]

> On 13 Oct 2022, at 04:08, Noam Preil <noam@pixelhero.dev> wrote:
> 
> Meh.
> 
> I use 9front as my main system, and I unsubscribed from 9fans months
> ago.
> 
> That place is a cesspool.
> 
> - Noam Preil
> 
> - Noam Preil
> 

cesspool? what, one email a month?

Re: [9front] [PATCH] cc: take our pickle out of the peephole

[hiro]

cesspooling is not about quantity but about attitude

On 10/13/22, Steve Simon <steve@quintile.net> wrote:
>
>
>> On 13 Oct 2022, at 04:08, Noam Preil <noam@pixelhero.dev> wrote:
>>
>> Meh.
>>
>> I use 9front as my main system, and I unsubscribed from 9fans months
>> ago.
>>
>> That place is a cesspool.
>>
>> - Noam Preil
>>
>> - Noam Preil
>>
>
> cesspool? what, one email a month?
>
>

Re: [9front] [PATCH] cc: take our pickle out of the peephole

[ori]

Quoth Anthony Martin <ality@pbrane.org>:
> 
> The -P flag is used to debug the peephole optimizer. The -Z flag is
> used to output pickling code for various types. Don't confuse the two.
> 
> The pickling code was added in the third edition. It mistakenly reused
> the -P flag which was later partially corrected to use the -Z flag in
> 2004. That change updated lex.c but missed the code in pickle.c.
> 
> ---
> diff 7bf177b3e058925265863979ee50e8dc1822d17a b44281c5cf3db0ca60a22df94bbe99e8bcf9c9e3
> --- a/sys/src/cmd/cc/pickle.c	Tue Aug 23 04:38:49 2022
> +++ b/sys/src/cmd/cc/pickle.c	Sat Oct 1 15:48:00 2022
> @@ -172,9 +172,9 @@
>  	int n;
>  	char *an;
> 
> -	if(!debug['P'])
> +	if(!debug['Z'])
>  		return;
> -	if(debug['P'] > 1) {
> +	if(debug['Z'] > 1) {
>  		n = 0;
>  		for(i=iostack; i; i=i->link)
>  			n++;
> @@ -221,9 +221,9 @@
>  	Type *t;
>  	Sym *s1, *s2;
> 
> -	if(!debug['P'] || debug['s'])
> +	if(!debug['Z'] || debug['s'])
>  		return;
> -	if(debug['P'] > 1) {
> +	if(debug['Z'] > 1) {
>  		n = 0;
>  		for(i=iostack; i; i=i->link)
>  			n++;

looks good, done.