From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 6200 invoked from network); 11 Dec 2023 22:58:58 -0000 Received: from 9front.inri.net (168.235.81.73) by inbox.vuxu.org with ESMTPUTF8; 11 Dec 2023 22:58:58 -0000 Received: from pb-smtp2.pobox.com ([64.147.108.71]) by 9front; Mon Dec 11 17:55:59 -0500 2023 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 0617A1B4F4D for <9front@9front.org>; Mon, 11 Dec 2023 17:55:55 -0500 (EST) (envelope-from unobe@cpan.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=message-id :to:subject:date:from:in-reply-to:mime-version:content-type :content-transfer-encoding; s=sasl; bh=8xr4VFsA+DJaMSAxh1st5d9+F l+jfTMTdYz/2PjJ9pA=; b=liyCwzIRNyhWj3REnlNfBMzHgShPgj/JVQbbibKB2 lypAl6t1iuu0uF1PT7Kel32npMGrlXetWTrBXK8MwtfM3sEEYgOn7usMYNegNZz2 8F3zEaWcgBI9/RLeZsdmqHO9J2P0K4SZfkKBYnAjYMkZENuMRAbigZrTViYtwGQR Sk= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id F1B4D1B4F4B for <9front@9front.org>; Mon, 11 Dec 2023 17:55:54 -0500 (EST) (envelope-from unobe@cpan.org) Received: from strider.localdomain (unknown [24.205.13.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id BFAD61B4F4A for <9front@9front.org>; Mon, 11 Dec 2023 17:55:53 -0500 (EST) (envelope-from unobe@cpan.org) Message-ID: To: 9front@9front.org Date: Mon, 11 Dec 2023 14:55:52 -0800 From: unobe@cpan.org In-Reply-To: <3706D8B23648E2758A3C35FDAEAC0A12@eigenstate.org> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Pobox-Relay-ID: 7012255C-9878-11EE-8E3C-25B3960A682E-09620299!pb-smtp2.pobox.com List-ID: <9front.9front.org> List-Help: X-Glyph: ➈ X-Bullshit: leveraged table general-purpose optimizer Subject: Re: [9front] [PATCH 3/6] nusb/ptp: add mention to nusb man page and fix implementation per spec to start with transaction id 1, not 0. Reply-To: 9front@9front.org Precedence: bulk Quoth ori@eigenstate.org: > Looks reasonable; is there any reason you needed to change the session > id here too? I just removed its initialization, since it's overwritten anyway to the pid. (Setting to 1 at the top superfluous.) > > Quoth Romano : > > > > Apple iPhones can now be used to transfer images. There is still an issue with the iPhone permission, wherein an actor has to be pretty quick on the trigger to Allow the connection from the iPhone side, but that would require a pause somewhere in the handshake that I did not have time to look into further. This patch at least allows the connection to succeed when permitted. > > --- > > diff c9c5d6455a6502ffb0f5490d5602396852261f4c 755ac2c11ce134f76d83a2a42edb07a6304d1de8 > > --- a/sys/man/4/nusb > > +++ b/sys/man/4/nusb > > @@ -194,6 +194,10 @@ > > The > > .B ctl > > file supplies the device geometry and partitions when read. > > +.I Ptp > > +configures and exposes a camera's (and often a mobile > > +device's) storage to allow transferring data via the > > +Picture Transfer Protocol (PTP). > > .SS Ethernet > > .I Ether > > handles USB ethernet devices. The file system provided is > > --- a/sys/src/cmd/nusb/ptp/ptp.c > > +++ b/sys/src/cmd/nusb/ptp/ptp.c > > @@ -75,9 +75,8 @@ > > > > static int debug = 0; > > static ulong time0; > > -static int maxpacket = 64; > > -static int sessionId = 1; > > -static int transId = 1; > > +static int sessionId; > > +static int transId; > > > > static Node **nodes; > > static int nnodes; > > @@ -556,7 +555,7 @@ > > } > > > > /* > > - * another proc migh'v come in and done it for us, > > + * another proc might've come in and done it for us, > > * so check the cache again. > > */ > > if(y = cachednode(path, &f)) > > @@ -1048,6 +1047,7 @@ > > sendp(iochan, ioproc()); > > > > sessionId = getpid(); > > + transId = 0; > > if(ptprpc(nil, OpenSession, 1, sessionId) < 0) > > sysfatal("open session: %r"); > > > > > > >