From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.0 required=5.0 tests=T_SCC_BODY_TEXT_LINE
	autolearn=ham autolearn_force=no version=3.4.4
Received: (qmail 31740 invoked from network); 3 May 2023 19:03:23 -0000
Received: from 9front.inri.net (168.235.81.73)
  by inbox.vuxu.org with ESMTPUTF8; 3 May 2023 19:03:23 -0000
Received: from mslow1.mail.gandi.net ([217.70.178.240]) by 9front; Wed May  3 15:01:39 -0400 2023
Received: from relay4-d.mail.gandi.net (unknown [217.70.183.196])
	by mslow1.mail.gandi.net (Postfix) with ESMTP id EC7D7D5B27
	for <9front@9front.org>; Wed,  3 May 2023 18:55:02 +0000 (UTC)
Received: (Authenticated sender: oholiab@grimmwa.re)
	by mail.gandi.net (Postfix) with ESMTPSA id D126CE0003
	for <9front@9front.org>; Wed,  3 May 2023 18:54:58 +0000 (UTC)
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Wed, 03 May 2023 19:54:58 +0100
Message-Id: <CSCVDAR396SF.1AAIPVAPPFHLL@meagr>
From: "Matt Carroll" <oholiab@grimmwa.re>
To: <9front@9front.org>
X-Mailer: aerc 0.14.0
References: <CS46OWSDVPK3.10AKPB8RTRU56@meagr>
 <1C631E48FC0511FA69A0342C80D45005@eigenstate.org>
In-Reply-To: <1C631E48FC0511FA69A0342C80D45005@eigenstate.org>
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: managed CMS-scale cloud realtime interface 
Subject: Re: [9front] [PATCH] Fix rune size in `acid`
Reply-To: 9front@9front.org
Precedence: bulk

On Wed May 3, 2023 at 6:54 PM BST,  wrote:
> Quoth grimmware <oholiab@grimmwa.re>:
> > --- a/sys/src/cmd/acid/exec.c
> > +++ b/sys/src/cmd/acid/exec.c
> > @@ -244,6 +244,7 @@
> >  	uchar cval;
> >  	ushort sval;
> >  	char buf[512], reg[12];
> > +	int rsize;
> > =20
> >  	r->op =3D OCONST;
> >  	r->fmt =3D fmt;
> > @@ -264,7 +265,6 @@
> >  	case 'u':
> >  	case 'o':
> >  	case 'q':
> > -	case 'r':
> >  		r->type =3D TINT;
> >  		ret =3D get2(m, addr, &sval);
> >  		if (ret < 0)
> > @@ -286,6 +286,7 @@
> >  	case 'U':
> >  	case 'O':
> >  	case 'Q':
> > +	case 'r':
> >  		r->type =3D TINT;
> >  		ret =3D get4(m, addr, &lval);
> >  		if (ret < 0)
> > @@ -317,12 +318,13 @@
> >  		r->string =3D strnode(buf);
> >  		break;
> >  	case 'R':
> > +		rsize =3D sizeof(Rune);
>
> why make rsize a variable? seems like you could just directly
> use sizeof(Rune).

I misremembered sizeof being runtime instead of compile time, I'll fix
it up and send another patch.