From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,FROM_LOCAL_NOVOWEL,HK_RANDOM_FROM, RCVD_IN_DNSWL_NONE autolearn=no autolearn_force=no version=3.4.4 Received: (qmail 9221 invoked from network); 18 Dec 2020 08:41:43 -0000 Received: from ewsd.inri.net (107.191.116.128) by inbox.vuxu.org with ESMTPUTF8; 18 Dec 2020 08:41:43 -0000 Received: from mail-lf1-f43.google.com ([209.85.167.43]) by ewsd; Fri Dec 18 03:38:12 -0500 2020 Received: by mail-lf1-f43.google.com with SMTP id m12so3383878lfo.7 for <9front@9front.org>; Fri, 18 Dec 2020 00:38:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:to:subject:from:date:in-reply-to:mime-version; bh=D2YgYzkK2BSoSiCJcO0rnhF4qYGOlu0FGQpcp4wS5wY=; b=Ff0n1yZ7oqEjVzGJ6x4BspzYHWB1j+sAjqXrQZbxm+BT8Wq50rlgHFmf+afW87p3qg PLgSb0Vgb2ts29COEs3dng5hAfe6H6jMfRG49VmKuF7pftcm1LPnnZLi6Cm0tnAgplp3 DE7pdmwsAJQFnSoGBWrDR+F4X37vBMqStdPp911T2qffD7W5sLd9FOQlnWrCBy3/r999 bYc8KuGgDMELLf4x+hJRh4TS4HMWydooFvoiTVBwoFNyPtgBOMWn1gAf1NMvg9L1E9BU Ca6LE/1RVAEyPZw5MZ1leNcJAY4PZRRfgbSq5IXKlDXchVH1PegD8Msb1e8IJUoPECo7 eS+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:to:subject:from:date:in-reply-to :mime-version; bh=D2YgYzkK2BSoSiCJcO0rnhF4qYGOlu0FGQpcp4wS5wY=; b=fzI9vLey3MUo/iS0tgpFQi4LqUhuFTLSXIwO8zlLqUTFEe9Gme6x1JfTfNaFmnTe4m sW+Jd4B7cdVbM0P90/ZCO2ebjd0iTAYHzwt/6qgQBaPlEKzJYMd5kKV2nlUgtcPGXcvq 4Q24AODEBFld9NxBweV/8+N11515gvn9FKxCgJQsaNZ+GVd3YIwT+vU+0qLDg6cr65ID FlnQpOTlJ3sH7sEDW/S+a2UZWdwe8FsyOKq5Gd3o7Laz0L9QemraEbwDU+wXpvj36cEK 8lsKR+5EWR9eqd64UXixnauf8LG+U4igdCi8OJHphynDCSZv1t4gQQz/WwJznXQvSwoA 4ndQ== X-Gm-Message-State: AOAM531GBfuq2Xg8NrowlrJj8GrXH6sukc4inKi2tmubVPhpJ2YQwBcB MxiCe0rdMAqguTmHnCEkadg= X-Google-Smtp-Source: ABdhPJyw0hnOdTkSafN7ULA8GeNAP/pDi8XxX2KjQLbQ7kTKlGJc4hzDvqeXokGP+d82r4qr83pCXQ== X-Received: by 2002:a2e:88d6:: with SMTP id a22mr1341775ljk.150.1608280682935; Fri, 18 Dec 2020 00:38:02 -0800 (PST) Return-Path: Received: from localhost (c-adc9e655.027-406-73746f40.bbcust.telenor.se. [85.230.201.173]) by smtp.gmail.com with ESMTPSA id n10sm942992ljg.139.2020.12.18.00.38.02 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 18 Dec 2020 00:38:02 -0800 (PST) Message-ID: To: meta.jxy@gmail.com, 9front@9front.org From: "Sigrid Solveig Haflínudóttir" Date: Fri, 18 Dec 2020 09:38:00 +0100 In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="upas-bqpzguxbtyiozrotcnkgcsstxw" List-ID: <9front.9front.org> List-Help: X-Glyph: ➈ X-Bullshit: open-source DOM dependency cache Subject: Re: [9front] strndup should use strnlen and memcpy Reply-To: 9front@9front.org Precedence: bulk This is a multi-part message in MIME format. --upas-bqpzguxbtyiozrotcnkgcsstxw Content-Disposition: inline Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit In 9front, memcpy == memmove. Why is strlen dangerous? --upas-bqpzguxbtyiozrotcnkgcsstxw Content-Type: message/rfc822 Content-Disposition: inline Delivered-To: ftrvxmtrx@gmail.com Received: by 2002:ab0:3579:0:0:0:0:0 with SMTP id e25csp1892173uaa; Fri, 18 Dec 2020 00:22:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJw7C6wJ2SRgZz9LYgXtaZpUBfdHWsY1qJUAl9n7rtvlCW4HnmO75zvB7H4qhtEfPC5BVPvB X-Received: by 2002:a62:2946:0:b029:19e:6b80:669a with SMTP id p67-20020a6229460000b029019e6b80669amr3260844pfp.42.1608279771023; Fri, 18 Dec 2020 00:22:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608279771; cv=none; d=google.com; s=arc-20160816; b=exftF2nRCbYQIs5taXdWLHo7gfc346pgdv1DdEBAvhF/dpI3YQ9HXZ2zwr3QB0YJsQ RX07WYMoOCRtirlt+kXrMvUFZGRnIyf9qw45a+ssQLDKV4wrFSUwdXeg+Ys12aEf/h66 lkJtz0E4zyKglNK4f26tYBgACYjScSd1ORGHeboJ/yQYKK7oYEp0w+72SDUWhaIq9hGP c2wRkTUIrtmuWstuxZkuloYZYyM9pb7FLzbbjz7kb4U+wxT+JXnIEb1U9OTwWhBL0jgn 4sb92jOIsSObY40EI+5l3hBqxyZv5Ymgy89ttkkXovYSRIAb7PdLrF9IkX0k564YbjXj BY4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=precedence:reply-to:subject:list-help:list-id:to:date:message-id :mime-version:content-transfer-encoding:from:dkim-signature; bh=WhC9Gz3XGDjfqHrlZI8iQkGZFI5IJmsQ2EJh/RmcA3s=; b=Ny4HeauQnQf2Gbvfjba6aVBEj+ttuXgcdZro4DZHth36TDsG0W8MxXvWSoz0Dgptst D3eRbaIosdv4Q84/Z6oRAlnM6VtDfHi3sNxnPnRwDcLrQsHIupU4GD1mNG3fRaVKyz0k 5wkw+vHPzRmCshVFLkzXyZXtaIrQYxcW8kg5BeV1J65svEvKbK0g2+L2Y84idvXkfn2D aYJAgZrUi1o3KK4bzyIpagAsIJ1U5wfOsvhSfxP39iK607IpG3h55yTGWK6NKKDXR3aO Elv1H1QCqkOmBqAo12DZEZtoDn4daXQvrZvc3EbGKscLR5h8fs+AuWEUi75vD5ql1WU+ KcOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=gfl9T4qI; spf=pass (google.com: domain of 9front-bounces@ewsd.inri.net designates 107.191.116.128 as permitted sender) smtp.mailfrom=9front-bounces@ewsd.inri.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: <9front-bounces@ewsd.inri.net> Received: from ewsd.inri.net (ewsd.inri.net. [107.191.116.128]) by mx.google.com with ESMTP id 62si6506574ple.48.2020.12.18.00.22.46; Fri, 18 Dec 2020 00:22:51 -0800 (PST) Received-SPF: pass (google.com: domain of 9front-bounces@ewsd.inri.net designates 107.191.116.128 as permitted sender) client-ip=107.191.116.128; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=gfl9T4qI; spf=pass (google.com: domain of 9front-bounces@ewsd.inri.net designates 107.191.116.128 as permitted sender) smtp.mailfrom=9front-bounces@ewsd.inri.net; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-io1-f49.google.com ([209.85.166.49]) by ewsd; Fri Dec 18 03:22:36 -0500 2020 Received: by mail-io1-f49.google.com with SMTP id 81so1251329ioc.13 for <9front@9front.org>; Fri, 18 Dec 2020 00:22:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:content-transfer-encoding:mime-version:subject:message-id:date :to; bh=WhC9Gz3XGDjfqHrlZI8iQkGZFI5IJmsQ2EJh/RmcA3s=; b=gfl9T4qInm/2zpVbIlBa1HMDN4jwCKpGy+XaS7S7zr6DhJgpW1LPm1c4beB9vWkqrC 6zx7u6wL4JNr2w/4hYZHn2Ru5736WFiDWnthoX+dNTV1PYic1w4M9yK2HBZYs6gPn+FM Dk78zmx4fXj/QTfP1Y9zUflZGPUnkHFkf4QwDoODqNK5PdKHmNgYjVkBNTFpTiiL02uv AlopAoylZFxg2e9UCSJOS0Q7NFf6Z1MntdkWUulG39aQ8i4wyjQYbXQ7nrduLjz9TXgv xsWxA/cXACCnwwbRoENQ/7/Sdg7mq84LLH4N5KB2+RslwAiuTAMfE1iq8bFC9+GDnSNW phnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:to; bh=WhC9Gz3XGDjfqHrlZI8iQkGZFI5IJmsQ2EJh/RmcA3s=; b=KdWcO3+A80JVhGdBc2c0kcC5SjgbEYlVpB3xwRBTaAUuEJxp5eQzQXvMMO4oQFd5Yb SHYk1mBqYbkHlMVeFlFssxpo+C5hyYHT1iEiAzeKcYlqk0C6U/2qlTOgvKUcDCPuzohq Mfv7bjWSmsQSWEgYWiNB8bEPzKR47oMacnVdpKHkAB8z/FJhvD8o9PRtqhhDXEUf5AxW JpmbsBEkuF3Xmf3KjjsFfdoBPfSH4NgX+sJv/nrgHOO8ZdeWZKKAtg7DUprgo2gJdFZa rfrGAHQviRgt8EPC8SArDNa05CeflU8CwJt6yNcMtFXnUawXSWSiHxeqR8rc4mrI5sed AnEA== X-Gm-Message-State: AOAM532bn5wa9ZcVhUEIug4wIbDomaOY8Kd5q7rlENLgDftq2HrP32d4 NidMgQydwvJyuuTyG3huRBkFfL4xKes= X-Received: by 2002:a05:6602:14ca:: with SMTP id b10mr2822103iow.40.1608279747478; Fri, 18 Dec 2020 00:22:27 -0800 (PST) Return-Path: Received: from [10.0.1.7] (c-67-184-39-205.hsd1.il.comcast.net. [67.184.39.205]) by smtp.gmail.com with ESMTPSA id m19sm5519692ila.81.2020.12.18.00.22.26 for <9front@9front.org> (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Dec 2020 00:22:26 -0800 (PST) From: Xiao-Yong Jin Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.40.0.2.32\)) Message-Id: Date: Fri, 18 Dec 2020 02:22:25 -0600 To: 9front@9front.org X-Mailer: Apple Mail (2.3654.40.0.2.32) List-ID: <9front.9front.org> List-Help: X-Glyph: ➈ X-Bullshit: non-blocking TOR over XML CMS table-based standard Subject: [9front] strndup should use strnlen and memcpy Reply-To: 9front@9front.org Precedence: bulk I just saw the new commit of strndup that uses strlen and memmove. memmove is unnecessary. strlen is dangerous. Here is a reference implementation from musl. http://git.musl-libc.org/cgit/musl/tree/src/string/strndup.c #include #include char *strndup(const char *s, size_t n) { size_t l = strnlen(s, n); char *d = malloc(l+1); if (!d) return NULL; memcpy(d, s, l); d[l] = 0; return d; } --upas-bqpzguxbtyiozrotcnkgcsstxw--