9front - general discussion about 9front
 help / color / mirror / Atom feed
From: "Timothy Robert Bednarzyk" <mail@trbsw.dev>
To: <9front@9front.org>
Subject: Re: [9front] [PATCH] Fix shift release events in X11 drawterm with shift:both_capslock xmodmap option
Date: Sun, 30 Jun 2024 15:22:57 -0400	[thread overview]
Message-ID: <D2DLHPQHEY2C.11BDT7PHOVIK6@trbsw.dev> (raw)
In-Reply-To: <ab3d151b-05bf-4048-bdf5-1f71ccc1a6f3@posixcafe.org>

> I just want to avoid oversharing in the comment to raise more questions then
> it answers. I thought that the later portions of the comment can be safely
> extrapolated from the cause of the bug as is described, so I feel it's filler.

Honestly, fair enough. I'm probably so used to seeing filler comments
(hell, I've genuinely seen "my funky dunky code" as a comment in some
code that I encountered at my day job) that I've just sort of
internalized them and have become guilty of making them myself. That
being said, I still do like having _something_ provide context to what
would otherwise appear to be completely nonsensical.

> This is your work though not mine so I won't die no this hill over some comment
> bikeshedding. Let me know what you would like.

I agree with hiro that it would be good enough to just put a link to
this thread as the comment if this change actually gets pushed upstream.
However, as I already said in my reply to hiro, I want to try to get the
actual problem in X11 fixed first so that there's no need to specially
handle broken behavior in drawterm itself.

--
trb

  reply	other threads:[~2024-06-30 19:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-28 23:53 Timothy Robert Bednarzyk
2024-06-29  0:30 ` Jacob Moody
2024-06-29 11:16   ` Timothy Robert Bednarzyk
2024-06-30 16:53     ` Jacob Moody
2024-06-30 19:22       ` Timothy Robert Bednarzyk [this message]
2024-06-29 16:31 ` hiro
2024-06-29 17:19   ` Timothy Robert Bednarzyk
2024-06-30 16:39     ` hiro
2024-06-30 19:08       ` Timothy Robert Bednarzyk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D2DLHPQHEY2C.11BDT7PHOVIK6@trbsw.dev \
    --to=mail@trbsw.dev \
    --cc=9front@9front.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).