From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <9front-bounces@9front.inri.net> X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.4 Received: from 9front.inri.net (9front.inri.net [168.235.81.73]) by inbox.vuxu.org (Postfix) with ESMTP id 26B9520283 for ; Sun, 30 Jun 2024 21:23:55 +0200 (CEST) Received: from out-184.mta1.migadu.com ([95.215.58.184]) by 9front; Sun Jun 30 15:23:05 -0400 2024 X-Envelope-To: 9front@9front.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trbsw.dev; s=key1; t=1719775382; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QCew3wriqTKDR77hh9KaMwfDRcZONDqHgFRWHClJVpg=; b=CbU7Jm3LxSX7UDIX0gLYAyO+nvteuGqM8qD+9Jfc6vbLfBUI12PSM2lunqQezNl8LlVjSb ctXYrJbN+DrFMwjr1U2Pph85aXssIUCm0nqtM2gFTXeZ6cpCNrOrGi46en1NNhRQGMh1q7 BuqFARs8s1QxLwPjahIRafUe5CAvYnc= Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 30 Jun 2024 15:22:57 -0400 Message-Id: X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Timothy Robert Bednarzyk" To: <9front@9front.org> References: <0e48ff1e-f33e-49ed-b40c-ea2f442e4c56@posixcafe.org> In-Reply-To: X-Migadu-Flow: FLOW_OUT List-ID: <9front.9front.org> List-Help: X-Glyph: ➈ X-Bullshit: proxy event realtime-based layer Subject: Re: [9front] [PATCH] Fix shift release events in X11 drawterm with shift:both_capslock xmodmap option Reply-To: 9front@9front.org Precedence: bulk > I just want to avoid oversharing in the comment to raise more questions t= hen > it answers. I thought that the later portions of the comment can be safel= y > extrapolated from the cause of the bug as is described, so I feel it's fi= ller. Honestly, fair enough. I'm probably so used to seeing filler comments (hell, I've genuinely seen "my funky dunky code" as a comment in some code that I encountered at my day job) that I've just sort of internalized them and have become guilty of making them myself. That being said, I still do like having _something_ provide context to what would otherwise appear to be completely nonsensical. > This is your work though not mine so I won't die no this hill over some c= omment > bikeshedding. Let me know what you would like. I agree with hiro that it would be good enough to just put a link to this thread as the comment if this change actually gets pushed upstream. However, as I already said in my reply to hiro, I want to try to get the actual problem in X11 fixed first so that there's no need to specially handle broken behavior in drawterm itself. -- trb