From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 22854 invoked from network); 6 Mar 2022 03:49:47 -0000 Received: from 4ess.inri.net (216.126.196.42) by inbox.vuxu.org with ESMTPUTF8; 6 Mar 2022 03:49:47 -0000 Received: from mimir.eigenstate.org ([206.124.132.107]) by 4ess; Sat Mar 5 22:44:51 -0500 2022 Received: from abbatoir.myfiosgateway.com (pool-74-108-56-225.nycmny.fios.verizon.net [74.108.56.225]) by mimir.eigenstate.org (OpenSMTPD) with ESMTPSA id 0db609dc (TLSv1.2:ECDHE-RSA-AES256-SHA:256:NO) for <9front@9front.org>; Sat, 5 Mar 2022 19:44:26 -0800 (PST) Message-ID: To: 9front@9front.org Date: Sat, 05 Mar 2022 22:44:24 -0500 From: ori@eigenstate.org In-Reply-To: <6223bab7.1c69fb81.6fc89.a14b@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit List-ID: <9front.9front.org> List-Help: X-Glyph: ➈ X-Bullshit: transactional RESTful XML over ACPI dependency just-in-time rails event Subject: Re: [9front] git lca bug Reply-To: 9front@9front.org Precedence: bulk Quoth Michael Forney : > > However, I don't understand that commit message. The definition of > LCA(b, g) that I've read is "the lowest node that has both b and g > as descendents". In the graph How do you define 'lowest' in this case? especially without walking the whole graph from the initial commit, which is very slow in large repos? It was initially being done by 'smallest number of steps from the starting points', but that's not correct, because in the graph above, the shortest sum of steps goes via 'h' to 'a'. > It returns M rather than I. That's definitely not intended. > Any idea on how best to fix this? Not yet. Tweaking repainting to sum the weight when colors meet seems like it may fix it, but I haven't thought it through yet.