From: ori@eigenstate.org
To: 9front@9front.org
Subject: Re: [9front] fix race condition on writes to #v/vgactl
Date: Wed, 17 Aug 2022 08:17:56 -0400 [thread overview]
Message-ID: <E0E3AFD2115807B9BE1CF2149363304E@eigenstate.org> (raw)
In-Reply-To: <E6BE7674A70057AE1801CCEA6209D436@wopr.sciops.net>
Quoth qwx@sciops.net:
> case CMdrawinit:
> - if(scr->gscreen == nil)
> + canqlock(&drawlock);
> + if(scr->gscreen == nil){
> + qunlock(&drawlock);
> error(Enoscreen);
> + }
this canqlock without an if looks supsicious to me;
if someone else holds the lock, the canqlock fails,
but that means we unlock *someone elses* lock.
next prev parent reply other threads:[~2022-08-17 12:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 6:12 qwx
2022-08-16 20:44 ` qwx
2022-08-16 20:51 ` Jacob Moody
2022-08-16 23:02 ` Anthony Martin
2022-08-17 12:10 ` qwx
2022-08-17 12:17 ` ori [this message]
2022-08-17 20:21 ` qwx
2022-08-18 2:23 ` ori
2022-08-18 5:36 ` qwx
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E0E3AFD2115807B9BE1CF2149363304E@eigenstate.org \
--to=ori@eigenstate.org \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).