9front - general discussion about 9front
 help / color / mirror / Atom feed
From: Romano <unobe@cpan.org>
To: 9front@9front.org
Subject: Re: [9front] [PATCH] rio: resize border and scrollbar based on font
Date: Fri, 10 May 2024 21:31:22 -0700	[thread overview]
Message-ID: <E34884BCF95C6780D14FF9080661214F@smtp.pobox.com> (raw)
In-Reply-To: <e2d76efa-0b99-413d-b236-ab5430102545@posixcafe.org>

I looked back over my replies and I couldn't see where I was pushing
for inclusion.  I thanked you for your feedback to begin with.  I
wasn't rejecting your review but I wanted to understand some of your
feedback better.  I understood what you were saying in regards to it
not being accepted.

But based on your last response I think you didn't understand what I
was saying, or rather the context in which I was saying what I was
saying.  Perhaps when I wrote, "But I think this is a start, and
makes things more bearable at least for me." you took that as me
pushing for inclusion?  Or in my last reply re: not letting the
perfect be the enemy of the good?  In my responses, I was explaining
how it was useful for me, and of course that's anecdotal: patches
often are.  I thought my question before my "more bearable " comment
re: just the scrollbars and my followup questions after (all in the
same email) would make it clear I wasn't pushing for inclusion. But
that didn't mean that I thought the discussion was over regarding
different paths forward. Your last response made it clear to me that
you (and perhaps others) thought I was pushing for inclusion. Sorry
about that.

My last email response was with the understanding that I knew it was
rejected and I wasn't trying to force its inclusion.  I did have
comments regarding what was considered hacky and how I've seen commits
accepted that do (knowingly) break assumptions/previous interfaces.
Things that I've seen done around here.

Anyway, in an attempt not to be misunderstood in the future I will try
the following boilerplate response: "
Thank you for reviewing.  I understand by your response that the patch
is rejected by you.  However, I have some related follow-up questions
and comments.  I don't expect any reply, especially if you consider my
follow-ups have already been addressed.  I also don't want to make you
think I am pushing for the patch as written to be included: I am not.

So having said that, ...  [my follow-ups] ..."

In the past I have followed up on patches I sent to the mailing list
but which were never commented on. I was told earlier (I think in
January, IIRC) that if no comment had bern given after a week it's
okay to follow-up.

And I often have seen messages here like "patches welcome" and
also lambasting those who ask about something to be changed given a
response akin to "talk is cheap, show me the code." So up until now I
have figured showing at least some effort with a patch (which might
very well be rejected) is better than just asking about scaling and
sizing.

Again, thank you for all you have helped me with on this list and on
gridchat.

  parent reply	other threads:[~2024-05-11  4:33 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-10  6:13 Romano
2024-05-10 13:27 ` Kristo
2024-05-10 14:01   ` Stanley Lieber
2024-05-10 14:17 ` Jacob Moody
2024-05-10 18:43   ` Romano
2024-05-10 19:15     ` Jacob Moody
2024-05-10 19:40       ` ori
2024-05-11 16:45         ` hiro
2024-05-11  4:31       ` Romano [this message]
2024-05-11 15:00         ` Jacob Moody
2024-05-11 16:54           ` hiro
2024-05-13  5:18           ` Romano
2024-05-11 16:42       ` hiro
2024-05-10 21:00     ` sl
2024-05-11  4:34       ` Romano
2024-05-13  5:38         ` Romano
  -- strict thread matches above, loose matches on Subject: below --
2024-05-09 21:04 Romano
2024-05-10  0:14 ` Jacob Moody
2024-05-10  0:34   ` sl
2024-05-10  6:20   ` Kurt H Maier
2024-05-10 14:10     ` Jacob Moody
2024-05-10 14:16       ` Stanley Lieber
2024-05-10 14:20         ` Jacob Moody
2024-05-10 14:23           ` Stanley Lieber
2024-05-10 14:21         ` ori
2024-05-10 14:33           ` Stanley Lieber
2024-05-10 14:37             ` Stanley Lieber
2024-05-10 14:58       ` Kurt H Maier
2024-05-10 15:28         ` Stuart Morrow
2024-05-10 16:11           ` Stanley Lieber
2024-05-10 16:43             ` Stuart Morrow
2024-05-10 16:50               ` Stuart Morrow
2024-05-11 16:36               ` hiro
2024-05-11 16:30             ` hiro
2024-05-11 16:27       ` hiro
2024-05-11 16:36         ` Jacob Moody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E34884BCF95C6780D14FF9080661214F@smtp.pobox.com \
    --to=unobe@cpan.org \
    --cc=9front@9front.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).