[9front] Patch: snarf paste support for (e)enter, and refactoring

[9front] Patch: snarf paste support for (e)enter, and refactoring

[sirjofri]

Hello,

This patch adds snarf and paste support to the two library functions enter and eenter. It also adds an internal function _genenter to share lots of the code. This does not change the interfaces of (e)enter though, for compatibility reasons.

In total, this adds 100 lines of code, but removes duplicate code for drawing and interpreting input.

I did test it with standard ascii, as well as some simple sequences of greek letters, but there could still be bugs. UTF-8 handling code is mostly inspired by/copied from acme.

More importantly, I can imagine you don't like the structure here and there, as it's more complex than the simple approach we currently have. Just let me know and I'll adjust it accordingly.

The patch is pretty long, so here's just a link to the file. If needed, I can also paste the data directly, just let me know.

https://sirjofri.de/oat/patches/eesp.diff

sirjofri

Re: [9front] Patch: snarf paste support for (e)enter, and refactoring

[thedaemon]

Quoth sirjofri <sirjofri+ml-9front@sirjofri.de>:
> Hello,
> 
> This patch adds snarf and paste support to the two library functions enter and eenter. It also adds an internal function _genenter to share lots of the code. This does not change the interfaces of (e)enter though, for compatibility reasons.
> 
> In total, this adds 100 lines of code, but removes duplicate code for drawing and interpreting input.
> 
> I did test it with standard ascii, as well as some simple sequences of greek letters, but there could still be bugs. UTF-8 handling code is mostly inspired by/copied from acme.
> 
> More importantly, I can imagine you don't like the structure here and there, as it's more complex than the simple approach we currently have. Just let me know and I'll adjust it accordingly.
> 
> The patch is pretty long, so here's just a link to the file. If needed, I can also paste the data directly, just let me know.
> 
> https://sirjofri.de/oat/patches/eesp.diff
> 
> sirjofri
Thank you!  I
will try this out as soon as I can figure out how to apply this.  One
day I'll use diff enough to memorize the command, that is not today.

Re: [9front] Patch: snarf paste support for (e)enter, and refactoring

[sirjofri]

Hi,

Any news on this? Ping?

sirjofri

Re: [9front] Patch: snarf paste support for (e)enter, and refactoring

[umbraticus]

Firtstly, thanks for going at this: we continue to edge
ever closer to a consistent text interface...

I haven't been able to go through the code yet & probably
not qualified to comment anyway, but I found a few things:

Serious problem:

Snarfing seems to work fine but pasting is busted. First one
works, subsequent B1–B3s insert all kinds of nonsense...

Convenience:

Your diff didn't include the necessary additions to OFILES
and HFILES lists in the mkfile.

Nice-to-haves, down the line:

It would be nice if you could select with B1 and have B2 do
the snarf even if the cursor has moved outside the box.

As mentioned probably thru another channel, clicking 
in the label portion being equivalent to pressing enter
is probably undesireable...

Double-clicking behaviour.

umbraticus