* [9front] mklib, upas/common: clean up libcommon properly
@ 2021-02-02 20:14 mikan
2021-02-03 14:49 ` Amavect
0 siblings, 1 reply; 2+ messages in thread
From: mikan @ 2021-02-02 20:14 UTC (permalink / raw)
To: 9front
Despite pervious efforts, mk clean still doesn't remove libcommon.a*
files from cmd/upas/common/.
To fix this, let's tell cmd/mklib to do the job instead:
Remove CLEANFILES from cmd/upas/common/mkfile
Add *.a[$OS] to clean rule in cmd/mklib
diff -r 40a5f1266803 sys/src/cmd/mklib
--- a/sys/src/cmd/mklib Tue Feb 02 07:21:47 2021 -0800
+++ b/sys/src/cmd/mklib Tue Feb 02 20:05:11 2021 +0000
@@ -39,7 +39,7 @@
rm -f *.[$OS] y.tab.? y.output y.error $CLEANFILES $LIB
clean:V:
- rm -f *.[$OS] y.tab.? y.output y.error $CLEANFILES
+ rm -f *.[$OS] *.a[$OS] y.tab.? y.output y.error $CLEANFILES
%.acid:V:
$CC $CFLAGS -a `{basename $stem .$objtype}^.c >$target
diff -r 40a5f1266803 sys/src/cmd/upas/common/mkfile
--- a/sys/src/cmd/upas/common/mkfile Tue Feb 02 07:21:47 2021 -0800
+++ b/sys/src/cmd/upas/common/mkfile Tue Feb 02 20:05:11 2021 +0000
@@ -15,6 +15,4 @@
common.h\
sys.h\
-CLEANFILES=libcommon.a[$OS]
-
</sys/src/cmd/mklib
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [9front] mklib, upas/common: clean up libcommon properly
2021-02-02 20:14 [9front] mklib, upas/common: clean up libcommon properly mikan
@ 2021-02-03 14:49 ` Amavect
0 siblings, 0 replies; 2+ messages in thread
From: Amavect @ 2021-02-03 14:49 UTC (permalink / raw)
To: 9front
rc doesn't expand regexp inside variables, which was my mistake.
Changeset 8293 seems to indicate that we want to clean the local libs, while nuke is for removing the syslibs. So, I think this is a good patch.
For completeness, we should also remove the CLEANFILES from other local lib mkfiles.
Thanks,
Amavect
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-03 14:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-02 20:14 [9front] mklib, upas/common: clean up libcommon properly mikan
2021-02-03 14:49 ` Amavect
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).