9front - general discussion about 9front
 help / color / mirror / Atom feed
From: ori@eigenstate.org
To: 9front@9front.org
Subject: Re: [9front] git/pull: fetch all branches (please test)
Date: Tue, 19 Apr 2022 23:42:32 -0400	[thread overview]
Message-ID: <ED7872BB757346BAD3518CF9FDAFE8BA@eigenstate.org> (raw)
In-Reply-To: <CAGw6cBsezD_G=xbvWBWGGUn5+Z_ZHbBf=xzPyN=ALoYBuqAKOQ@mail.gmail.com>

Quoth Michael Forney <mforney@mforney.org>:
> On 2022-04-11, ori@eigenstate.org <ori@eigenstate.org> wrote:
> I've been looking over the http-protocol docs, and it describes an
> algorithm involving a priority queue and commit graph traversal that
> we don't seem to do.
> How does this work when our refs have several local commits that the
> server doesn't have?

Yeah. We currently fetch too much. In practice it seems to
not come up too often, but I would like to implement that
queue/ack/nak algorithm (and implement multi-ack while
I'm there). It'd be a separate commit.

> > +	 * Work around torvalds git bug: we get duplicate have lines
> Do you mean duplicate ACK lines? From my reading of the protocol docs,
> "have" lines are only sent by us (the client).

I do. Good catch.

> In fact, I don't really see much about ACK lines at all. Do you know
> if this is described anywhere in the git docs?

It's described in the pack protocol, as well as the

> Now that $branch is unused, I think you can remove the corresponding
> positional parameter in the update function, as well as the git/pull
> -a and -b options.

Yes. thanks.

      reply	other threads:[~2022-04-20  3:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11  3:19 ori
2022-04-11 21:32 ` ori
2022-04-12  2:55   ` ori
2022-04-19 19:31     ` Michael Forney
2022-04-20  3:42       ` ori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ED7872BB757346BAD3518CF9FDAFE8BA@eigenstate.org \
    --to=ori@eigenstate.org \
    --cc=9front@9front.org \
    --subject='Re: [9front] git/pull: fetch all branches (please test)' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).