Re: [9front] git/pull: fetch all branches (please test)

[ori@eigenstate.org]

Quoth Michael Forney <mforney@mforney.org>:
> On 2022-04-11, ori@eigenstate.org <ori@eigenstate.org> wrote:
> I've been looking over the http-protocol docs, and it describes an
> algorithm involving a priority queue and commit graph traversal that
> we don't seem to do.
> 
> How does this work when our refs have several local commits that the
> server doesn't have?

Yeah. We currently fetch too much. In practice it seems to
not come up too often, but I would like to implement that
queue/ack/nak algorithm (and implement multi-ack while
I'm there). It'd be a separate commit.


> > +	 * Work around torvalds git bug: we get duplicate have lines
> 
> Do you mean duplicate ACK lines? From my reading of the protocol docs,
> "have" lines are only sent by us (the client).

I do. Good catch.

> In fact, I don't really see much about ACK lines at all. Do you know
> if this is described anywhere in the git docs?

It's described in the pack protocol, as well as the
extensions.

	git/Documentation/technical/pack-protocol.txt
	git/Documentation/technical/protocol-capabilities.txt
 
> Now that $branch is unused, I think you can remove the corresponding
> positional parameter in the update function, as well as the git/pull
> -a and -b options.

Yes. thanks.