From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham
	autolearn_force=no version=3.4.4
Received: (qmail 32299 invoked from network); 20 Apr 2022 03:43:58 -0000
Received: from 9front.inri.net (168.235.81.73)
  by inbox.vuxu.org with ESMTPUTF8; 20 Apr 2022 03:43:58 -0000
Received: from mimir.eigenstate.org ([206.124.132.107]) by 9front; Tue Apr 19 23:42:47 -0400 2022
Received: from abbatoir.myfiosgateway.com (pool-74-108-56-225.nycmny.fios.verizon.net [74.108.56.225])
	by mimir.eigenstate.org (OpenSMTPD) with ESMTPSA id 4d3bc725 (TLSv1.2:ECDHE-RSA-AES256-SHA:256:NO)
	for <9front@9front.org>;
	Tue, 19 Apr 2022 20:42:34 -0700 (PDT)
Message-ID: <ED7872BB757346BAD3518CF9FDAFE8BA@eigenstate.org>
To: 9front@9front.org
Date: Tue, 19 Apr 2022 23:42:32 -0400
From: ori@eigenstate.org
In-Reply-To: <CAGw6cBsezD_G=xbvWBWGGUn5+Z_ZHbBf=xzPyN=ALoYBuqAKOQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: asynchronous hosting AJAX self-signing-scale service service solution 
Subject: Re: [9front] git/pull: fetch all branches (please test)
Reply-To: 9front@9front.org
Precedence: bulk

Quoth Michael Forney <mforney@mforney.org>:
> On 2022-04-11, ori@eigenstate.org <ori@eigenstate.org> wrote:
> I've been looking over the http-protocol docs, and it describes an
> algorithm involving a priority queue and commit graph traversal that
> we don't seem to do.
> 
> How does this work when our refs have several local commits that the
> server doesn't have?

Yeah. We currently fetch too much. In practice it seems to
not come up too often, but I would like to implement that
queue/ack/nak algorithm (and implement multi-ack while
I'm there). It'd be a separate commit.


> > +	 * Work around torvalds git bug: we get duplicate have lines
> 
> Do you mean duplicate ACK lines? From my reading of the protocol docs,
> "have" lines are only sent by us (the client).

I do. Good catch.

> In fact, I don't really see much about ACK lines at all. Do you know
> if this is described anywhere in the git docs?

It's described in the pack protocol, as well as the
extensions.

	git/Documentation/technical/pack-protocol.txt
	git/Documentation/technical/protocol-capabilities.txt
 
> Now that $branch is unused, I think you can remove the corresponding
> positional parameter in the update function, as well as the git/pull
> -a and -b options.

Yes. thanks.