* [9front] [PATCH] tee: remove unused variable in
@ 2022-11-09 13:46 mkf9
2022-11-15 22:07 ` mkf9
2022-11-16 1:47 ` Sigrid Solveig Haflínudóttir
0 siblings, 2 replies; 7+ messages in thread
From: mkf9 @ 2022-11-09 13:46 UTC (permalink / raw)
To: 9front
--- /sys/src/cmd/tee.c
+++ tee.c
@@ -9,7 +9,6 @@
FDSTART = 3,
};
-int uflag;
int aflag;
char in[8192];
@@ -32,7 +31,6 @@
break;
case 'u':
- uflag++;
/* uflag is ignored and undocumented; it's a relic from Unix */
break;
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [9front] [PATCH] tee: remove unused variable in
2022-11-09 13:46 [9front] [PATCH] tee: remove unused variable in mkf9
@ 2022-11-15 22:07 ` mkf9
2022-11-16 1:47 ` Sigrid Solveig Haflínudóttir
1 sibling, 0 replies; 7+ messages in thread
From: mkf9 @ 2022-11-15 22:07 UTC (permalink / raw)
To: 9front
ping
Nov 9, 2022 17:17:03 mkf9@riseup.net:
> --- /sys/src/cmd/tee.c
> +++ tee.c
> @@ -9,7 +9,6 @@
> FDSTART = 3,
> };
>
> -int uflag;
> int aflag;
>
> char in[8192];
> @@ -32,7 +31,6 @@
> break;
>
> case 'u':
> - uflag++;
> /* uflag is ignored and undocumented; it's a relic from Unix */
> break;
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [9front] [PATCH] tee: remove unused variable in
2022-11-09 13:46 [9front] [PATCH] tee: remove unused variable in mkf9
2022-11-15 22:07 ` mkf9
@ 2022-11-16 1:47 ` Sigrid Solveig Haflínudóttir
2022-11-16 2:57 ` Michael Forney
2022-11-16 10:34 ` mkf9
1 sibling, 2 replies; 7+ messages in thread
From: Sigrid Solveig Haflínudóttir @ 2022-11-16 1:47 UTC (permalink / raw)
To: mkf9, 9front
Applied, thanks.
Your original patch looks wrong - git/import could
not apply it. Git/export is supposed to produce the
right thing.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [9front] [PATCH] tee: remove unused variable in
2022-11-16 1:47 ` Sigrid Solveig Haflínudóttir
@ 2022-11-16 2:57 ` Michael Forney
2022-11-16 3:01 ` Sigrid Solveig Haflínudóttir
2022-11-16 3:09 ` ori
2022-11-16 10:34 ` mkf9
1 sibling, 2 replies; 7+ messages in thread
From: Michael Forney @ 2022-11-16 2:57 UTC (permalink / raw)
To: 9front
Sigrid Solveig Haflínudóttir <sigrid@ftrv.se> wrote:
> Your original patch looks wrong - git/import could
> not apply it. Git/export is supposed to produce the
> right thing.
Although the patch isn't what you'd get with git/commit and git/export,
I don't think anything is wrong with it apart from being a bit
unconventional. We should be able to deal with it with our tools.
There are two issues here:
1. The patch relies on standard filename detection behavior that
our new patch implementation doesn't follow. There are plenty
of patches in the wild like this, and I mentioned it in the
`patch(1) filename detection thread` a while back. I have a local
patch patch in my queue that fixes this.
2. git/import has no way to forward -p arguments to patch. git am
has this, and it seems both useful and easy to add to git/import.
With both of those fixed, git/import -p0 would do the trick.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [9front] [PATCH] tee: remove unused variable in
2022-11-16 2:57 ` Michael Forney
@ 2022-11-16 3:01 ` Sigrid Solveig Haflínudóttir
2022-11-16 3:09 ` ori
1 sibling, 0 replies; 7+ messages in thread
From: Sigrid Solveig Haflínudóttir @ 2022-11-16 3:01 UTC (permalink / raw)
To: mforney, 9front
Perhaps the original email should have had a subject like
[DIFF] ...
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [9front] [PATCH] tee: remove unused variable in
2022-11-16 2:57 ` Michael Forney
2022-11-16 3:01 ` Sigrid Solveig Haflínudóttir
@ 2022-11-16 3:09 ` ori
1 sibling, 0 replies; 7+ messages in thread
From: ori @ 2022-11-16 3:09 UTC (permalink / raw)
To: 9front
Quoth Michael Forney <mforney@mforney.org>:
> Sigrid Solveig Haflínudóttir <sigrid@ftrv.se> wrote:
> > Your original patch looks wrong - git/import could
> > not apply it. Git/export is supposed to produce the
> > right thing.
>
> Although the patch isn't what you'd get with git/commit and git/export,
> I don't think anything is wrong with it apart from being a bit
> unconventional. We should be able to deal with it with our tools.
>
> There are two issues here:
> 1. The patch relies on standard filename detection behavior that
> our new patch implementation doesn't follow. There are plenty
> of patches in the wild like this, and I mentioned it in the
> `patch(1) filename detection thread` a while back. I have a local
> patch patch in my queue that fixes this.
> 2. git/import has no way to forward -p arguments to patch. git am
> has this, and it seems both useful and easy to add to git/import.
>
> With both of those fixed, git/import -p0 would do the trick.
seems sane to me.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [9front] [PATCH] tee: remove unused variable in
2022-11-16 1:47 ` Sigrid Solveig Haflínudóttir
2022-11-16 2:57 ` Michael Forney
@ 2022-11-16 10:34 ` mkf9
1 sibling, 0 replies; 7+ messages in thread
From: mkf9 @ 2022-11-16 10:34 UTC (permalink / raw)
To: 9front
thanks, will use it for next patchs.
Nov 16, 2022 05:18:33 Sigrid Solveig Haflínudóttir <sigrid@ftrv.se>:
> Applied, thanks.
> Your original patch looks wrong - git/import could
> not apply it. Git/export is supposed to produce the
> right thing.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-11-16 10:37 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-09 13:46 [9front] [PATCH] tee: remove unused variable in mkf9
2022-11-15 22:07 ` mkf9
2022-11-16 1:47 ` Sigrid Solveig Haflínudóttir
2022-11-16 2:57 ` Michael Forney
2022-11-16 3:01 ` Sigrid Solveig Haflínudóttir
2022-11-16 3:09 ` ori
2022-11-16 10:34 ` mkf9
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).