From: Romano <unobe@cpan.org>
To: 9front@9front.org
Subject: [9front] [patch] nusb/serial: rndis handled by nusbrc
Date: Wed, 07 Apr 2021 00:50:34 -0700 [thread overview]
Message-ID: <EF8C785600FC254AB7E4DCD37DA7CB0F@smtp.pobox.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 544 bytes --]
See attached.
These changes keep nusb/serial from attempting to use an RNDIS
endpoint. Without this patch, nusb/serial will generate an error
like:
nusb/serial: getdev: '/dev/usb/ep17.0/data' device or object already in use
when an RNDIS endpoint has already been found (e.g., a pinephone usb
tether). I had unfortunately overlooked this part when I submitting
my previous patch for nusb/ether.
Additionally, if there is no ethernet on boot, don't attempt to look
for an address.
The last bit is just updating a comment to match the code.
[-- Attachment #2: nusb.patch --]
[-- Type: text/plain, Size: 1311 bytes --]
diff -r 18e1e1c3aaf1 rc/bin/cpurc
--- a/rc/bin/cpurc Tue Apr 06 14:43:38 2021 +0200
+++ b/rc/bin/cpurc Wed Apr 07 00:39:55 2021 -0700
@@ -59,7 +59,8 @@
addrs=`{ndb/query -a sys $sysname ether}
if(! ~ $#addrs 0){
for(ether in /net/ether*){
- addr=`{cat $ether/addr}
+ if (test -d $ether)
+ addr=`{cat $ether/addr}
switch($addr){
case $addrs
# try /lib/ndb first, then do dhcp/slaac
diff -r 18e1e1c3aaf1 rc/bin/nusbrc
--- a/rc/bin/nusbrc Tue Apr 06 14:43:38 2021 +0200
+++ b/rc/bin/nusbrc Wed Apr 07 00:39:55 2021 -0700
@@ -14,8 +14,9 @@
case *01
nusb/audio $id
case *02
- # serial and ethernet
- nusb/serial $id
+ # serial and ethernet: 0xff0202 is RNDIS, handled by nusbrc
+ if (! ~ $4 ff0202)
+ nusb/serial $id
# handled /sys/src/9/boot/nusbrc
# nusb/ether $id
case *03
diff -r 18e1e1c3aaf1 sys/src/cmd/nusb/ether/ether.c
--- a/sys/src/cmd/nusb/ether/ether.c Tue Apr 06 14:43:38 2021 +0200
+++ b/sys/src/cmd/nusb/ether/ether.c Wed Apr 07 00:39:55 2021 -0700
@@ -849,7 +849,7 @@
nerr = 0;
for(;;){
- /* receive allocates buffer and calls etheriq(b, 1); */
+ /* receive allocates buffer and calls etheriq(b); */
if((*epreceive)(epin) < 0){
rerrstr(err, sizeof(err));
if(strstr(err, "interrupted") || strstr(err, "timed out"))
next reply other threads:[~2021-04-07 7:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 7:50 Romano [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-04-07 7:49 Romano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EF8C785600FC254AB7E4DCD37DA7CB0F@smtp.pobox.com \
--to=unobe@cpan.org \
--cc=9front@9front.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).